All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: dave.jiang@intel.com, dan.j.williams@intel.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] libnvdimm: prevent nvdimm from requesting key when security" failed to apply to 5.3-stable tree
Date: Wed, 9 Oct 2019 12:11:38 -0400	[thread overview]
Message-ID: <20191009161138.GS1396@sasha-vm> (raw)
In-Reply-To: <157056215310918@kroah.com>

On Tue, Oct 08, 2019 at 09:15:53PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.3-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 674f31a352da5e9f621f757b9a89262f486533a0 Mon Sep 17 00:00:00 2001
>From: Dave Jiang <dave.jiang@intel.com>
>Date: Tue, 24 Sep 2019 10:34:49 -0700
>Subject: [PATCH] libnvdimm: prevent nvdimm from requesting key when security
> is disabled
>
>Current implementation attempts to request keys from the keyring even when
>security is not enabled. Change behavior so when security is disabled it
>will skip key request.
>
>Error messages seen when no keys are installed and libnvdimm is loaded:
>
>    request-key[4598]: Cannot find command to construct key 661489677
>    request-key[4606]: Cannot find command to construct key 34713726
>
>Cc: stable@vger.kernel.org
>Fixes: 4c6926a23b76 ("acpi/nfit, libnvdimm: Add unlock of nvdimm support for Intel DIMMs")
>Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>Link: https://lore.kernel.org/r/156934642272.30222.5230162488753445916.stgit@djiang5-desk3.ch.intel.com
>Signed-off-by: Dan Williams <dan.j.williams@intel.com>

The issue was that the way we represent security flags changed due to
d78c620a2e824 ("libnvdimm/security: Introduce a 'frozen' attribute"). I
fixed up 674f31a352da5 to address that and queued it for 5.3.

  reply	other threads:[~2019-10-09 16:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 19:15 FAILED: patch "[PATCH] libnvdimm: prevent nvdimm from requesting key when security" failed to apply to 5.3-stable tree gregkh
2019-10-09 16:11 ` Sasha Levin [this message]
2019-10-09 16:43   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191009161138.GS1396@sasha-vm \
    --to=sashal@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.