* [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync
@ 2019-10-09 13:39 ` Ben Dooks
0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2019-10-09 13:39 UTC (permalink / raw)
To: linux-kernel
Cc: Tony Lindgren, linux-omap, Ben Dooks, Russell King,
linux-arm-kernel
Force the type of omap_interconnect_sync to avoid the
following sparse warnign:
arch/arm/mach-omap2/omap4-common.c:142:27: warning: incorrect type in assignment (different address spaces)
arch/arm/mach-omap2/omap4-common.c:142:27: expected void [noderef] <asn:2> *static [toplevel] sram_sync
arch/arm/mach-omap2/omap4-common.c:142:27: got void *
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org
---
arch/arm/mach-omap2/omap4-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
index 5c3845730dbf..d27c5f61d708 100644
--- a/arch/arm/mach-omap2/omap4-common.c
+++ b/arch/arm/mach-omap2/omap4-common.c
@@ -139,7 +139,7 @@ static int __init omap4_sram_init(void)
pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
__func__);
else
- sram_sync = (void *)gen_pool_alloc(sram_pool, PAGE_SIZE);
+ sram_sync = (void __force __iomem *)gen_pool_alloc(sram_pool, PAGE_SIZE);
return 0;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync
@ 2019-10-09 13:39 ` Ben Dooks
0 siblings, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2019-10-09 13:39 UTC (permalink / raw)
To: linux-kernel
Cc: Tony Lindgren, linux-omap, Ben Dooks, Russell King,
linux-arm-kernel
Force the type of omap_interconnect_sync to avoid the
following sparse warnign:
arch/arm/mach-omap2/omap4-common.c:142:27: warning: incorrect type in assignment (different address spaces)
arch/arm/mach-omap2/omap4-common.c:142:27: expected void [noderef] <asn:2> *static [toplevel] sram_sync
arch/arm/mach-omap2/omap4-common.c:142:27: got void *
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org
---
arch/arm/mach-omap2/omap4-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
index 5c3845730dbf..d27c5f61d708 100644
--- a/arch/arm/mach-omap2/omap4-common.c
+++ b/arch/arm/mach-omap2/omap4-common.c
@@ -139,7 +139,7 @@ static int __init omap4_sram_init(void)
pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
__func__);
else
- sram_sync = (void *)gen_pool_alloc(sram_pool, PAGE_SIZE);
+ sram_sync = (void __force __iomem *)gen_pool_alloc(sram_pool, PAGE_SIZE);
return 0;
}
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync
2019-10-09 13:39 ` Ben Dooks
@ 2019-10-09 16:14 ` Russell King - ARM Linux admin
-1 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux admin @ 2019-10-09 16:14 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, Tony Lindgren, linux-omap, linux-arm-kernel
On Wed, Oct 09, 2019 at 02:39:02PM +0100, Ben Dooks wrote:
> Force the type of omap_interconnect_sync to avoid the
> following sparse warnign:
>
> arch/arm/mach-omap2/omap4-common.c:142:27: warning: incorrect type in assignment (different address spaces)
> arch/arm/mach-omap2/omap4-common.c:142:27: expected void [noderef] <asn:2> *static [toplevel] sram_sync
> arch/arm/mach-omap2/omap4-common.c:142:27: got void *
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-omap@vger.kernel.org
> ---
> arch/arm/mach-omap2/omap4-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
> index 5c3845730dbf..d27c5f61d708 100644
> --- a/arch/arm/mach-omap2/omap4-common.c
> +++ b/arch/arm/mach-omap2/omap4-common.c
> @@ -139,7 +139,7 @@ static int __init omap4_sram_init(void)
> pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
> __func__);
> else
> - sram_sync = (void *)gen_pool_alloc(sram_pool, PAGE_SIZE);
> + sram_sync = (void __force __iomem *)gen_pool_alloc(sram_pool, PAGE_SIZE);
Not sure about this one - did you check whether the memory returned
here really is iomem memory? If it isn't iomem memory, then the
warning should remain.
Never hide a valid sparse warning - to do so goes against the whole
point of sparse checks. It isn't "pointing out that a cast is missing,
we must add a cast", the point of sparse is to find and identify where
the code is actually incorrect - in other words, MMIO accessors are
used on memory that is not MMIO, or direct dereferences are used on
memory that is MMIO. If we go around merely casting the warnings away,
it makes sparse completely pointless.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync
@ 2019-10-09 16:14 ` Russell King - ARM Linux admin
0 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux admin @ 2019-10-09 16:14 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, Tony Lindgren, linux-omap, linux-arm-kernel
On Wed, Oct 09, 2019 at 02:39:02PM +0100, Ben Dooks wrote:
> Force the type of omap_interconnect_sync to avoid the
> following sparse warnign:
>
> arch/arm/mach-omap2/omap4-common.c:142:27: warning: incorrect type in assignment (different address spaces)
> arch/arm/mach-omap2/omap4-common.c:142:27: expected void [noderef] <asn:2> *static [toplevel] sram_sync
> arch/arm/mach-omap2/omap4-common.c:142:27: got void *
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-omap@vger.kernel.org
> ---
> arch/arm/mach-omap2/omap4-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
> index 5c3845730dbf..d27c5f61d708 100644
> --- a/arch/arm/mach-omap2/omap4-common.c
> +++ b/arch/arm/mach-omap2/omap4-common.c
> @@ -139,7 +139,7 @@ static int __init omap4_sram_init(void)
> pr_warn("%s:Unable to get sram pool needed to handle errata I688\n",
> __func__);
> else
> - sram_sync = (void *)gen_pool_alloc(sram_pool, PAGE_SIZE);
> + sram_sync = (void __force __iomem *)gen_pool_alloc(sram_pool, PAGE_SIZE);
Not sure about this one - did you check whether the memory returned
here really is iomem memory? If it isn't iomem memory, then the
warning should remain.
Never hide a valid sparse warning - to do so goes against the whole
point of sparse checks. It isn't "pointing out that a cast is missing,
we must add a cast", the point of sparse is to find and identify where
the code is actually incorrect - in other words, MMIO accessors are
used on memory that is not MMIO, or direct dereferences are used on
memory that is MMIO. If we go around merely casting the warnings away,
it makes sparse completely pointless.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-09 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-09 13:39 [PATCH] ARM: OMAP2+: force iomem for omap_interconnect_sync Ben Dooks
2019-10-09 13:39 ` Ben Dooks
2019-10-09 16:14 ` Russell King - ARM Linux admin
2019-10-09 16:14 ` Russell King - ARM Linux admin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.