From: Eric Biggers <ebiggers@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@lists.codethink.co.uk,
Ben Dooks <ben.dooks@codethink.co.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/namespace: make to_mnt_ns static
Date: Wed, 9 Oct 2019 16:13:00 -0700 [thread overview]
Message-ID: <20191009231259.GA125579@gmail.com> (raw)
In-Reply-To: <20191009145211.16614-1-ben.dooks@codethink.co.uk>
On Wed, Oct 09, 2019 at 03:52:11PM +0100, Ben Dooks wrote:
> The to_mnt_ns() is not exported outside the file so
> make it static to fix the following sparse warning:
>
> fs/namespace.c:1731:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/namespace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index fe0e9e1410fe..b87b127fdce4 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -1728,7 +1728,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
> dentry->d_fsdata == &mntns_operations;
> }
>
> -struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> +static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
> {
> return container_of(ns, struct mnt_namespace, ns);
> }
> --
> 2.23.0
>
Al, this patch has been sent to you 11 times by 8 different people over 2 years:
https://lore.kernel.org/linux-fsdevel/20191009145211.16614-1-ben.dooks@codethink.co.uk/
https://lore.kernel.org/linux-fsdevel/20190822154014.14401-1-ebiggers@kernel.org/
https://lore.kernel.org/linux-fsdevel/20190529212108.164246-1-ebiggers@kernel.org/
https://lore.kernel.org/linux-fsdevel/20190414191913.GA11798@bharath12345-Inspiron-5559/
https://lore.kernel.org/linux-fsdevel/20190319151756.96768-1-maowenan@huawei.com/
https://lore.kernel.org/linux-fsdevel/20190110204147.120073-1-ebiggers@kernel.org/
https://lore.kernel.org/linux-fsdevel/20181115000930.47611-1-ebiggers@kernel.org/
https://lore.kernel.org/linux-fsdevel/20180630120447.17861-1-colin.king@canonical.com/
https://lore.kernel.org/linux-fsdevel/20170111104846.26220-1-tklauser@distanz.ch/
https://lore.kernel.org/linux-fsdevel/20181207204318.1920-1-malat@debian.org/
https://lore.kernel.org/linux-fsdevel/a2cc7bd9cd4cd5be54303090c7ba6654d7b04b4f.1443364195.git.geliangtang@163.com/
No response from you to any of them. I guess this means you're just not taking
these types of obvious cleanups? Should people be sending them to Andrew Morton
instead?
- Eric
prev parent reply other threads:[~2019-10-09 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:52 [PATCH] fs/namespace: make to_mnt_ns static Ben Dooks
2019-10-09 23:13 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009231259.GA125579@gmail.com \
--to=ebiggers@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.