From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: olivier.matz@6wind.com, harry.van.haaren@intel.com,
konstantin.ananyev@intel.com, mattias.ronnblom@ericsson.com,
bruce.richardson@intel.com, arybchenko@solarflare.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 2/2] mbuf: add bulk free function
Date: Thu, 10 Oct 2019 07:51:52 -0700 [thread overview]
Message-ID: <20191010075152.2737bbbc@hermes.lan> (raw)
In-Reply-To: <20191010082621.45899-3-mb@smartsharesystems.com>
On Thu, 10 Oct 2019 08:26:21 +0000
Morten Brørup <mb@smartsharesystems.com> wrote:
> Add function for freeing a bulk of mbufs.
>
> v6:
> * Remove __rte_always_inline from static function.
> The compiler will inline anyway.
> v5:
> * Rename variables from "free" to "pending" for improved readability.
> * Add prefix __ to rte_pktmbuf_free_seg_via_array().
> * Add array size parameter to __rte_pktmbuf_free_seg_via_array().
> The compiler will optimize the parameter away anyway.
> * Add description to __rte_pktmbuf_free_seg_via_array().
> * Minor description updates.
> v4:
> * Mark as experimental by adding __rte_experimental.
> * Add function to experimental section of map file.
> * Fix source code formatting regarding pointer to pointer.
> * Squash multiple modifications into one.
> v3:
> * Bugfix: Handle pakets with multiple segments.
> * Add inline helper function, mainly for readability.
> * Fix source code formatting regarding indentation.
> v2:
> * Function is not inline.
> * Optimize to free multible mbufs belonging to the same mempool in
> bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers
> in the array, just like rte_pktmbuf_free() can take a NULL pointer.
> * Use unsigned int instead of unsigned. Passes checkpatch, but
> mismatches the original coding style of the modified files.
> * Fix a typo in the description headline: mempools is plural.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
These two could be squashed together when merged
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2019-10-10 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 8:26 [dpdk-dev] [PATCH v6 0/2] mbuf: add bulk free function Morten Brørup
2019-10-10 8:26 ` [dpdk-dev] [PATCH v6 1/2] " Morten Brørup
2019-10-10 8:26 ` [dpdk-dev] [PATCH v6 2/2] " Morten Brørup
2019-10-10 14:51 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-10 9:34 [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
2019-10-10 9:34 ` [dpdk-dev] [PATCH v6 2/2] " Morten Brørup
2019-10-09 13:55 [dpdk-dev] [PATCH v5 1/1] " Morten Brørup
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 0/2] " Morten Brørup
2019-10-10 8:33 ` [dpdk-dev] [PATCH v6 2/2] " Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010075152.2737bbbc@hermes.lan \
--to=stephen@networkplumber.org \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.