From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Thu, 10 Oct 2019 10:09:44 +0200 Subject: [U-Boot] [PATCH v3 3/4] arm: socfpga: Convert system manager from struct to defines In-Reply-To: References: <1570688406-35914-1-git-send-email-ley.foon.tan@intel.com> <1570688406-35914-4-git-send-email-ley.foon.tan@intel.com> Message-ID: <20191010100944.6c1e3aba@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 10 Oct 2019 09:16:14 +0200 Simon Goldschmidt simon.k.r.goldschmidt at gmail.com wrote: > On Thu, Oct 10, 2019 at 8:20 AM Ley Foon Tan wrote: > > > > Convert system manager for Gen5, Arria 10 and Stratix 10 from struct > > to defines. > > Same as 2/4: please add a description about the "read address from dts" thing. Why is this required? In the past we have rejected all new code adding defines instead of structs for register accesses. Have we changed our mind now? -- Anatolij