From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F4EC10F14 for ; Thu, 10 Oct 2019 11:07:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3549208C3 for ; Thu, 10 Oct 2019 11:07:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732008AbfJJLHk (ORCPT ); Thu, 10 Oct 2019 07:07:40 -0400 Received: from verein.lst.de ([213.95.11.211]:57595 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727727AbfJJLHj (ORCPT ); Thu, 10 Oct 2019 07:07:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id BF6F768C65; Thu, 10 Oct 2019 13:07:35 +0200 (CEST) Date: Thu, 10 Oct 2019 13:07:35 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Keith Busch , Jens Axboe , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates Subject: Re: [PATCH v9 08/12] nvmet-tcp: don't check data_len in nvmet_tcp_map_data() Message-ID: <20191010110735.GA28392@lst.de> References: <20191009192530.13079-1-logang@deltatee.com> <20191009192530.13079-10-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009192530.13079-10-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Oct 09, 2019 at 01:25:26PM -0600, Logan Gunthorpe wrote: > With passthru, the data_len is no longer guaranteed to be set > for all requests. Therefore, we should not check for it to be > non-zero. Instead check if the SGL length is zero and map > when appropriate. > > None of the other transports check data_len which is verified > in core code. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Sagi Grimberg I think the issue here is deeper. Yes, this patch is correct, but nvmet-tcp has another use of req.data_len in nvmet_tcp_handle_req_failure, which looks completely bogus. Please try to audit that as well and send out fixes to the list separately from this series, as both look like potentially serious bugs. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D496ECE596 for ; Thu, 10 Oct 2019 11:07:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3E06208C3 for ; Thu, 10 Oct 2019 11:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZyoHbpja" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3E06208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9D24NW7BPxRiDcParaZaZLeuX6HnH7SX2qW25trFO4A=; b=ZyoHbpjaIwcIwF drKT74Sn5OP8VD2FJ+3U3cSuWVSvOTNGtDq/GZa2FIlxOgzHlB6taeur74632MnGfnxMM7QamXgGy 3g4ePksuhVNgH7j8LT5BwV2+ykEbUNp4pLJSm6VMyhhjqEghiWAk8mku3E0qwEiim58KAR0zB+LSb 6KAJONg3P42vDOd/UUImWrqVhwAQ+Yj3obicTPTSzonAfdmAeYMzo0Xcr8GwRt5SxkZVk47yp3rR5 4+Vve3HOlv6B73LZ5W79/tTMGRat8uyCMG/mOFmXPYKAqWmuepjqvLKd9yIIEpZL3/9AapVmG9joZ w0t+a4cjZL4Kmr8YuFhw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIWII-0007fw-Db; Thu, 10 Oct 2019 11:07:42 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIWIF-0007fX-Q8 for linux-nvme@lists.infradead.org; Thu, 10 Oct 2019 11:07:41 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BF6F768C65; Thu, 10 Oct 2019 13:07:35 +0200 (CEST) Date: Thu, 10 Oct 2019 13:07:35 +0200 From: Christoph Hellwig To: Logan Gunthorpe Subject: Re: [PATCH v9 08/12] nvmet-tcp: don't check data_len in nvmet_tcp_map_data() Message-ID: <20191010110735.GA28392@lst.de> References: <20191009192530.13079-1-logang@deltatee.com> <20191009192530.13079-10-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191009192530.13079-10-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_040739_995167_E1436608 X-CRM114-Status: GOOD ( 10.64 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Sagi Grimberg , Chaitanya Kulkarni , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , linux-block@vger.kernel.org, Keith Busch , linux-fsdevel@vger.kernel.org, Max Gurtovoy , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2019 at 01:25:26PM -0600, Logan Gunthorpe wrote: > With passthru, the data_len is no longer guaranteed to be set > for all requests. Therefore, we should not check for it to be > non-zero. Instead check if the SGL length is zero and map > when appropriate. > > None of the other transports check data_len which is verified > in core code. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Sagi Grimberg I think the issue here is deeper. Yes, this patch is correct, but nvmet-tcp has another use of req.data_len in nvmet_tcp_handle_req_failure, which looks completely bogus. Please try to audit that as well and send out fixes to the list separately from this series, as both look like potentially serious bugs. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme