From: Luis Chamberlain <mcgrof@kernel.org>
To: Tuowen Zhao <ztuowen@gmail.com>
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, acelan.kao@canonical.com,
bhelgaas@google.com, kai.heng.feng@canonical.com
Subject: Re: [PATCH v3 2/2] mfd: intel-lpss: use devm_ioremap_uc for MMIO
Date: Thu, 10 Oct 2019 12:08:23 +0000 [thread overview]
Message-ID: <20191010120823.GD16384@42.do-not-panic.com> (raw)
In-Reply-To: <20191010030335.204974-2-ztuowen@gmail.com>
On Wed, Oct 09, 2019 at 09:03:35PM -0600, Tuowen Zhao wrote:
> Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci
> in MTRR. This will cause the system to hang during boot. If possible,
> this bug could be corrected with a firmware update.
>
> This patch use devm_ioremap_uc to overwrite/ignore the MTRR settings
> by forcing the use of strongly uncachable pages for intel-lpss.
>
> The BIOS bug is present on Dell XPS 13 7390 2-in-1:
>
> [ 0.001734] 5 base 4000000000 mask 6000000000 write-combining
>
> 4000000000-7fffffffff : PCI Bus 0000:00
> 4000000000-400fffffff : 0000:00:02.0 (i915)
> 4010000000-4010000fff : 0000:00:15.0 (intel-lpss-pci)
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203485
> Tested-by: AceLan Kao <acelan.kao@canonical.com>
> Signed-off-by: Tuowen Zhao <ztuowen@gmail.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I think you'll want to Cc stable for this, as well as the last patch.
LTS kernels with the ioremap_uc will be able to leverage the fix.
Luis
next prev parent reply other threads:[~2019-10-10 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 3:03 [PATCH v3 1/2] lib: devres: add a helper function for ioremap_uc Tuowen Zhao
2019-10-10 3:03 ` [PATCH v3 2/2] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-10 12:08 ` Luis Chamberlain [this message]
2019-10-14 7:06 ` Lee Jones
2019-10-10 12:06 ` [PATCH v3 1/2] lib: devres: add a helper function for ioremap_uc Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010120823.GD16384@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ztuowen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.