From: Wambui Karuga <wambui.karugax@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals
Date: Thu, 10 Oct 2019 16:10:07 +0300 [thread overview]
Message-ID: <20191010131007.GB15405@wambui> (raw)
In-Reply-To: <20191010085916.GA452879@kroah.com>
On Thu, Oct 10, 2019 at 10:59:16AM +0200, Greg KH wrote:
> On Thu, Oct 10, 2019 at 07:49:05AM +0300, Wambui Karuga wrote:
> > Remove most comparisons to NULL in conditionals in
> > drivers/staging/rtl8723bs/core/rtw_mlme.c
> > Issues reported by checkpatch.pl as:
> > CHECK: Comparison to NULL could be written
> >
> > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_mlme.c | 46 +++++++++++------------
> > 1 file changed, 23 insertions(+), 23 deletions(-)
>
> Due to lots of other changes in this file recently, this patch does not
> apply, and so the rest of this series does not apply either.
>
> Can you please rebase this against my staging-testing branch and resend?
>
> thanks,
>
> greg k-h
Will do! Thanks
Wambui Karuga
next prev parent reply other threads:[~2019-10-10 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 4:49 [PATCH v2 0/4] staging: rtl8723bs: Style clean-up in rtw_mlme.c Wambui Karuga
2019-10-10 4:49 ` [PATCH v2 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals Wambui Karuga
2019-10-10 8:59 ` Greg KH
2019-10-10 13:10 ` Wambui Karuga [this message]
2019-10-10 4:49 ` [PATCH v2 2/4] staging: rtl8723bs: Remove unnecessary braces for single statements Wambui Karuga
2019-10-10 4:49 ` [PATCH v2 3/4] staging: rtl8723bs: Remove comparisons to booleans in conditionals Wambui Karuga
2019-10-10 4:49 ` [PATCH v2 4/4] staging: rtl8723bs: Remove unnecessary blank lines Wambui Karuga
2019-10-10 9:03 ` [PATCH v2 0/4] staging: rtl8723bs: Style clean-up in rtw_mlme.c Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010131007.GB15405@wambui \
--to=wambui.karugax@gmail.com \
--cc=20191010085916.GA452879@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.