From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A405AC4360C for ; Thu, 10 Oct 2019 13:50:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FF9C2196E for ; Thu, 10 Oct 2019 13:50:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="TQZ07FMv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725972AbfJJNus (ORCPT ); Thu, 10 Oct 2019 09:50:48 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45088 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbfJJNus (ORCPT ); Thu, 10 Oct 2019 09:50:48 -0400 Received: by mail-ed1-f66.google.com with SMTP id h33so5502405edh.12 for ; Thu, 10 Oct 2019 06:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=o898Z3trs0jH/OlBQbiOm8e/1sEfrvM2Vk3WyyK56M4=; b=TQZ07FMvCXrWciJ7O9lR+yonpxUCVIcHnhmodCVsy5Dh/Y5im2arlnqViBllsFZMoz FX1zMJwHMqtbjlVh/VFK76TKJ5qMTJkhvErbbOvUl3k+Ss1ZPSUdmEOoFoKO4bV2Iigr iZ9kCTkHefQMk+aqix6L1jZn0EltF9d/5eWS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=o898Z3trs0jH/OlBQbiOm8e/1sEfrvM2Vk3WyyK56M4=; b=HMUbtv0OGOV1UgbzmFHUPQFlgEOO2ZXIVmlobTlRpi/cgrISB6/wwc1diwqR1o/iGn y8yxotJNI4DkFhqP7se5X73DVJ/zY59fb8iRcLCwMOFG341uQVmKohi4+ppQheA29gJP ZYESokRDNxAbS9tvGbO+3zb57CIJL0LgOdHeJHXSOqSVf1PAVU+Fo+YOTnwcO7YB7DgO qqZm7qcMt3NG2tEsLMta8GL8Kdo7Op0k8aWLe3zduVR4ei2fwyoDMrod3oEtSK1e9VjS QVxwzWdRyd80OgLjK8zRd/vLW+2kgtw45LraFeND63KhtHfudLNMmbiCG3XD9NYpLyCO vmdg== X-Gm-Message-State: APjAAAV/RjYX1yk4nEK1k2oT52VYMPbJW6omQyRU6rdYbtKyOZfRbxgZ R5kS/hpUpL1I5Q9fgvss2EvCMw== X-Google-Smtp-Source: APXvYqwDTtGo4w8HEdRUZir73TR7uahsebmS6NjOfoevZfEYTOWdmz2kjDkxMdcPaAEi5/omDEtt/g== X-Received: by 2002:a17:906:7e17:: with SMTP id e23mr374597ejr.205.1570715446752; Thu, 10 Oct 2019 06:50:46 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id 36sm988776edz.92.2019.10.10.06.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 06:50:45 -0700 (PDT) Date: Thu, 10 Oct 2019 15:50:43 +0200 From: Daniel Vetter To: Johan Hovold Cc: Rob Clark , Sean Paul , Fabien Dessenne , Mauro Carvalho Chehab , Harald Freudenberger , David Airlie , Daniel Vetter , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 0/4] treewide: fix interrupted release Message-ID: <20191010135043.GA16989@phenom.ffwll.local> Mail-Followup-To: Johan Hovold , Rob Clark , Sean Paul , Fabien Dessenne , Mauro Carvalho Chehab , Harald Freudenberger , David Airlie , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman References: <20191010131333.23635-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010131333.23635-1-johan@kernel.org> X-Operating-System: Linux phenom 5.2.0-2-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > Two old USB drivers had a bug in them which could lead to memory leaks > if an interrupted process raced with a disconnect event. > > Turns out we had a few more driver in other subsystems with the same > kind of bug in them. > > Note that all but the s390 patch have only been compile tested, while > the s390 one has not even been built. Random funny idea: Could we do some debug annotations (akin to might_sleep) that splats when you might_sleep_interruptible somewhere where interruptible sleeps are generally a bad idea? Like in fops->release? Something like non_block_start/end that I've recently done, but for interruptible sleeps only? Would need might_sleep_interruptibly() annotations and non_interruptly_sleep_start/end annotations. -Daniel > > Johan > > > Johan Hovold (4): > drm/msm: fix memleak on release > media: bdisp: fix memleak on release > media: radio: wl1273: fix interrupt masking on release > s390/zcrypt: fix memleak at release > > drivers/gpu/drm/msm/msm_debugfs.c | 6 +----- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- > drivers/media/radio/radio-wl1273.c | 3 +-- > drivers/s390/crypto/zcrypt_api.c | 3 +-- > 4 files changed, 4 insertions(+), 11 deletions(-) > > -- > 2.23.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/4] treewide: fix interrupted release Date: Thu, 10 Oct 2019 15:50:43 +0200 Message-ID: <20191010135043.GA16989@phenom.ffwll.local> References: <20191010131333.23635-1-johan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191010131333.23635-1-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Johan Hovold Cc: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Vasily Gorbik , linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Carstens , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fabien Dessenne , Christian Borntraeger , Rob Clark , Harald Freudenberger , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Vetter , Greg Kroah-Hartman , Mauro Carvalho Chehab , Sean Paul , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTAsIDIwMTkgYXQgMDM6MTM6MjlQTSArMDIwMCwgSm9oYW4gSG92b2xkIHdy b3RlOgo+IFR3byBvbGQgVVNCIGRyaXZlcnMgaGFkIGEgYnVnIGluIHRoZW0gd2hpY2ggY291bGQg bGVhZCB0byBtZW1vcnkgbGVha3MKPiBpZiBhbiBpbnRlcnJ1cHRlZCBwcm9jZXNzIHJhY2VkIHdp dGggYSBkaXNjb25uZWN0IGV2ZW50Lgo+IAo+IFR1cm5zIG91dCB3ZSBoYWQgYSBmZXcgbW9yZSBk cml2ZXIgaW4gb3RoZXIgc3Vic3lzdGVtcyB3aXRoIHRoZSBzYW1lCj4ga2luZCBvZiBidWcgaW4g dGhlbS4KPiAKPiBOb3RlIHRoYXQgYWxsIGJ1dCB0aGUgczM5MCBwYXRjaCBoYXZlIG9ubHkgYmVl biBjb21waWxlIHRlc3RlZCwgd2hpbGUKPiB0aGUgczM5MCBvbmUgaGFzIG5vdCBldmVuIGJlZW4g YnVpbHQuCgpSYW5kb20gZnVubnkgaWRlYTogQ291bGQgd2UgZG8gc29tZSBkZWJ1ZyBhbm5vdGF0 aW9ucyAoYWtpbiB0bwptaWdodF9zbGVlcCkgdGhhdCBzcGxhdHMgd2hlbiB5b3UgbWlnaHRfc2xl ZXBfaW50ZXJydXB0aWJsZSBzb21ld2hlcmUKd2hlcmUgaW50ZXJydXB0aWJsZSBzbGVlcHMgYXJl IGdlbmVyYWxseSBhIGJhZCBpZGVhPyBMaWtlIGluCmZvcHMtPnJlbGVhc2U/CgpTb21ldGhpbmcg bGlrZSBub25fYmxvY2tfc3RhcnQvZW5kIHRoYXQgSSd2ZSByZWNlbnRseSBkb25lLCBidXQgZm9y CmludGVycnVwdGlibGUgc2xlZXBzIG9ubHk/IFdvdWxkIG5lZWQgbWlnaHRfc2xlZXBfaW50ZXJy dXB0aWJseSgpCmFubm90YXRpb25zIGFuZCBub25faW50ZXJydXB0bHlfc2xlZXBfc3RhcnQvZW5k IGFubm90YXRpb25zLgotRGFuaWVsCgo+IAo+IEpvaGFuCj4gCj4gCj4gSm9oYW4gSG92b2xkICg0 KToKPiAgIGRybS9tc206IGZpeCBtZW1sZWFrIG9uIHJlbGVhc2UKPiAgIG1lZGlhOiBiZGlzcDog Zml4IG1lbWxlYWsgb24gcmVsZWFzZQo+ICAgbWVkaWE6IHJhZGlvOiB3bDEyNzM6IGZpeCBpbnRl cnJ1cHQgbWFza2luZyBvbiByZWxlYXNlCj4gICBzMzkwL3pjcnlwdDogZml4IG1lbWxlYWsgYXQg cmVsZWFzZQo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kZWJ1Z2ZzLmMgICAgICAgICAg ICAgfCA2ICstLS0tLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3N0aS9iZGlzcC9iZGlzcC12 NGwyLmMgfCAzICstLQo+ICBkcml2ZXJzL21lZGlhL3JhZGlvL3JhZGlvLXdsMTI3My5jICAgICAg ICAgICAgfCAzICstLQo+ICBkcml2ZXJzL3MzOTAvY3J5cHRvL3pjcnlwdF9hcGkuYyAgICAgICAg ICAgICAgfCAzICstLQo+ICA0IGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTEgZGVs ZXRpb25zKC0pCj4gCj4gLS0gCj4gMi4yMy4wCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxp bmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v