From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D7FECE58E for ; Thu, 10 Oct 2019 14:01:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C46F206B6 for ; Thu, 10 Oct 2019 14:01:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T4Mlo7UK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C46F206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ujkc4J0JM8S8i74GJ6ShJI1uR8HZUcPuD2DA5nBGZCc=; b=T4Mlo7UKHJf6Yy mCHjg6Gi3ZQIjswXsrMsqceEo349V8+Wz0/6198st8QkwRk+pKnHvksmuGW9hIV8IVBUKL09H7fSh BDG9UBsoUa860jC5Oz6l6+7dtieP015esIG8Wxm9uhYKZMsZXQgq0vesVJVJvYZZzGBQ5ZP7fvERC 8IGhoLw8kDp+P+M6Da2ePaQqNDD9uMnEG+sRRz2fWEZ+KJvVdz6Ktb63BwN0uO3xiG8VvGDteM2Gz PHxWNVhPPhffzjvLGyXCgh8RinYtQiBfkQxUAcfetsm5apWJ4+e+zFqeu7iHhzTX8jtqDbp5uPQv0 HMtQk50lWSna0t8ZyizQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIZ0T-0004vn-24; Thu, 10 Oct 2019 14:01:29 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIZ0P-0004vH-Vx for linux-nvme@lists.infradead.org; Thu, 10 Oct 2019 14:01:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E1F5468C65; Thu, 10 Oct 2019 16:01:21 +0200 (CEST) Date: Thu, 10 Oct 2019 16:01:21 +0200 From: Christoph Hellwig To: Bjorn Helgaas Subject: Re: [PATCH 1/1] PCI/ASPM: Remove pcie_aspm_enabled() unnecessary locking Message-ID: <20191010140121.GA31701@lst.de> References: <20191010124746.2882-1-helgaas@kernel.org> <20191010124746.2882-2-helgaas@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010124746.2882-2-helgaas@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_070126_179186_9EF527DE X-CRM114-Status: UNSURE ( 6.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Mario Limonciello , linux-pci@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Keith Busch , Kai-Heng Feng , Bjorn Helgaas , Rajat Jain , Christoph Hellwig , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 07:47:46AM -0500, Bjorn Helgaas wrote: > + return bridge->link_state ? !!bridge->link_state->aspm_enabled : false; Can we unobsfucated this while we're at it? if (!bridge->link_state) return false; return bridge->link_state->aspm_enabled; _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A6EECE58E for ; Thu, 10 Oct 2019 14:01:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4980E206B6 for ; Thu, 10 Oct 2019 14:01:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbfJJOB1 (ORCPT ); Thu, 10 Oct 2019 10:01:27 -0400 Received: from verein.lst.de ([213.95.11.211]:58372 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfJJOB1 (ORCPT ); Thu, 10 Oct 2019 10:01:27 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E1F5468C65; Thu, 10 Oct 2019 16:01:21 +0200 (CEST) Date: Thu, 10 Oct 2019 16:01:21 +0200 From: Christoph Hellwig To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, "Rafael J . Wysocki" , Sagi Grimberg , Mario Limonciello , Keith Busch , Kai-Heng Feng , Rajat Jain , Christoph Hellwig , Heiner Kallweit , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Bjorn Helgaas Subject: Re: [PATCH 1/1] PCI/ASPM: Remove pcie_aspm_enabled() unnecessary locking Message-ID: <20191010140121.GA31701@lst.de> References: <20191010124746.2882-1-helgaas@kernel.org> <20191010124746.2882-2-helgaas@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010124746.2882-2-helgaas@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Oct 10, 2019 at 07:47:46AM -0500, Bjorn Helgaas wrote: > + return bridge->link_state ? !!bridge->link_state->aspm_enabled : false; Can we unobsfucated this while we're at it? if (!bridge->link_state) return false; return bridge->link_state->aspm_enabled;