From: Christoph Hellwig <hch@infradead.org>
To: Omer Shpigelman <oshpigelman@habana.ai>
Cc: "oded.gabbay@gmail.com" <oded.gabbay@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] habanalabs: support vmalloc memory mapping
Date: Thu, 10 Oct 2019 07:09:50 -0700 [thread overview]
Message-ID: <20191010140950.GA27176@infradead.org> (raw)
In-Reply-To: <20191010140615.26460-1-oshpigelman@habana.ai>
On Thu, Oct 10, 2019 at 02:06:22PM +0000, Omer Shpigelman wrote:
> This patch adds support in mapping of vmalloc memory.
> In contrary to user memory, vmalloc memory is already pinned and has no
> vm_area structure. Therefore a new capability was needed in order to map
> this memory.
Unless I am missing something you mix user and kernel pointers in
your is_vmalloc_addr checks. That will break on those architectures
that have separate kernel and user address spaces.
> Mapping vmalloc memory is needed for Gaudi ASIC.
How does that ASIC pass in the vmalloc memory? I don't fully understand
the code, but it seems like the addresses are fed from ioctl, which
means they only come from userspace.
next prev parent reply other threads:[~2019-10-10 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:06 [PATCH 1/2] habanalabs: support vmalloc memory mapping Omer Shpigelman
2019-10-10 14:06 ` [PATCH 2/2] habanalabs: handle large memory on MMU Omer Shpigelman
2019-10-10 14:09 ` Christoph Hellwig [this message]
2019-10-10 19:54 ` [PATCH 1/2] habanalabs: support vmalloc memory mapping Omer Shpigelman
2019-10-11 8:10 ` Christoph Hellwig
2019-10-11 9:19 ` Oded Gabbay
2019-10-11 9:26 ` Christoph Hellwig
2019-10-11 9:27 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010140950.GA27176@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
--cc=oshpigelman@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.