From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org,
Edmund Nadolski <edmund.nadolski@intel.com>,
Judy Brock <judy.brock@samsung.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCHv3 5/5] nvme: Wait for reset state when required
Date: Thu, 10 Oct 2019 18:18:47 +0200 [thread overview]
Message-ID: <20191010161847.GA1942@lst.de> (raw)
In-Reply-To: <20191010160527.22376-6-kbusch@kernel.org>
> +int nvme_reset_schedule(struct nvme_ctrl *ctrl)
> {
> if (ctrl->state != NVME_CTRL_RESETTING)
> return -EBUSY;
> @@ -133,6 +133,7 @@ static int nvme_reset_schedule(struct nvme_ctrl *ctrl)
> return -EBUSY;
> return 0;
> }
> +EXPORT_SYMBOL_GPL(nvme_reset_schedule);
Oh well, forgot we grow more users later. The naming of the thing
still puzlles me, though. Maybe something like nvme_schedule_reset_work
is a little better? Not that I'm fully happy with that either.
> static void nvme_reset_done(struct pci_dev *pdev)
> {
> struct nvme_dev *dev = pci_get_drvdata(pdev);
> - nvme_reset_ctrl_sync(&dev->ctrl);
> +
> + if (!nvme_reset_schedule(&dev->ctrl))
> + flush_work(&dev->ctrl.reset_work);
Do we need a comment on the flush?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-10 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:05 [PATCHv3 0/5] nvme: double reset prevention Keith Busch
2019-10-10 16:05 ` [PATCHv3 1/5] nvme-pci: Free tagset if no IO queues Keith Busch
2019-10-10 16:05 ` [PATCHv3 2/5] nvme: Remove ADMIN_ONLY state Keith Busch
2019-10-10 16:05 ` [PATCHv3 3/5] nvme: Restart request timers in resetting state Keith Busch
2019-10-10 16:05 ` [PATCHv3 4/5] nvme: Prevent resets during paused controller state Keith Busch
2019-10-10 16:09 ` Christoph Hellwig
2019-10-10 16:17 ` Keith Busch
2019-10-10 16:05 ` [PATCHv3 5/5] nvme: Wait for reset state when required Keith Busch
2019-10-10 16:18 ` Christoph Hellwig [this message]
2019-10-10 16:30 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010161847.GA1942@lst.de \
--to=hch@lst.de \
--cc=edmund.nadolski@intel.com \
--cc=james.smart@broadcom.com \
--cc=judy.brock@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.