From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10AD0C10F14 for ; Thu, 10 Oct 2019 17:19:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDD9C20659 for ; Thu, 10 Oct 2019 17:19:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OBcHY7Oe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDD9C20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SEc0TkClg68OPGe1C62tMYPIYNXhYrJF1gxDc0Gu4bI=; b=OBcHY7Oemk1hNF e9H3QYbqJnQ0vmYbAFhFQ6e/DsIev+bWuBKJPKOJYDlDy8QoiHsxTyg3cTH7S/3iG/zW33rmq03LZ G8yy8NjDeeKVzrJBuBCMfIH4cQdqyeM+2z+T/7e6dGF8SfNyMo50rHGBX+vZfFF4RJol+EQSllWgR h90h8sO7EU5JQ90lKkl+uX25/6Se5/L2A9j0Qi8AHst3O4cmTLBYwHDtLi4Ew4wvrYNvrEoyAyhph LmiLjL/Nnc3QQJAKYPEsXSgt8aeAWoHCdRw97RioXtqkNPNXRKKnakRHzsFRtmxWCIXmI/asZT6h7 I2+X7xhXPo9Yrgnf7FjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIc5w-0000U0-Fw; Thu, 10 Oct 2019 17:19:20 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIc5u-0000Sz-5Q for linux-nvme@lists.infradead.org; Thu, 10 Oct 2019 17:19:19 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 4CC6F68CFC; Thu, 10 Oct 2019 19:19:13 +0200 (CEST) Date: Thu, 10 Oct 2019 19:19:13 +0200 From: Christoph Hellwig To: "Wunderlich, Mark" Subject: Re: [PATCH v2] nvme-tcp: Initialize sk->sk_ll_usec only with NET_RX_BUSY_POLL Message-ID: <20191010171913.GA3104@lst.de> References: <20191010150622.reqmasxgavug4amm@linutronix.de> <20191010150719.GA617@lst.de> <20191010151023.gru6fhrhy7gxxwye@linutronix.de> <20191010151444.GA638@lst.de> <20191010152924.jlr53aunkj7de5js@linutronix.de> <20191010152958.GA1057@lst.de> <20191010153411.6uetttizkto6rv65@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_101918_354347_51834DFE X-CRM114-Status: UNSURE ( 7.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Sebastian Andrzej Siewior , "linux-nvme@lists.infradead.org" , Jens Axboe , Keith Busch , "tglx@linutronix.de" , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 05:08:27PM +0000, Wunderlich, Mark wrote: > Should there also be a check here to honor any non-zero value of sk_ll_usec ( via sysctl_net_busy_read ), before setting here to hard coded default of 1? > Or maybe best to have this as a separate patch to consider? Let's keep that separate. If you want to enhance that area, we probably shouldn't build nvme_tcp_poll at all without CONFIG_NET_RX_BUSY_POLL as well. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme