From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:e804:0:0:0:0:0 with SMTP id o4csp539230wrm; Fri, 11 Oct 2019 01:30:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZdVlKORxm/fcRaHwHFV7iUTtCpWCcbgn7tA/eq3iCIRefACr3WvfUcVwcRHzf4wbeReXV X-Received: by 2002:a50:f296:: with SMTP id f22mr12365306edm.69.1570782630786; Fri, 11 Oct 2019 01:30:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1570782630; cv=pass; d=google.com; s=arc-20160816; b=El+4S99GqnUGc6DaATuEmLmYGHzhu2Bae01KMX9v4dUHU1yb76RTlH7kFSyDhggxxN X672MaiWuiIkc7w3ahsbbrlHCMu22M2n2rBjqkQCSGa4oAk1ho5cCiwLyQufZfoQn13a hbNSMlIAGkiGt0e3W4f7IXWHBjFKVya4quqnoPdesnVIGPxw/2/a36ZsTSGVuDSQpEFV 1fVZEs9NlxjhrS/mm5LPo27UIva5fzlYUCIoNyMfjd5rt2fhVFMMGEMrt1NVxKptjnIL AELslVS4+jXxIPj3BfqpbCojho3zc6hQOBLuKhmlYCBamrw4tXFvQ8d9DYqhy+NajqLx Lcog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:content-id:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:to:from:dkim-signature:dkim-signature; bh=m3XYUSzhgopgd9Xgbyy4u+oJ/hfJs7vLDyu/QJZTF/k=; b=gXS/8BJ4EI+i9FJA23GVM0EcMwSozkfGRXBpIldEUTeKCZwNP/+V8CUw8HMRiUq+n+ iIFRehr94F0GAQDodrvUCXGCw+mJSxKiYQFcBnUO3aPbNK/yhmlQlSipUBuiDW/QY/lZ k7Rn3linrOGZswkqVv8k4H/jkFMSw/ZxHVTiva5b49iP4IRIlIvDRcS3gHhx5mRTbics DWJCmCdSMm5Zvqnn34O3nxyzUpIkcdB9RHKieC4Jg3MHZ5ubtk4IwFchg+SlK7vki+hQ GZ4uiUwFlomIBwKFa0hWHxgLAqJ6DPMIxssjldibBhhsj89I95uDmhX3WLXz9VWtCca5 j4fA== ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@marvell.com header.s=pfpt0818 header.b=LMwGLrdD; dkim=pass header.i=@marvell.onmicrosoft.com header.s=selector2-marvell-onmicrosoft-com header.b=c6VATaQX; arc=pass (i=1 spf=pass spfdomain=marvell.com dkim=pass dkdomain=marvell.com dmarc=pass fromdomain=marvell.com); spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=marvell.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id f33si4666187edb.281.2019.10.11.01.30.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Oct 2019 01:30:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@marvell.com header.s=pfpt0818 header.b=LMwGLrdD; dkim=pass header.i=@marvell.onmicrosoft.com header.s=selector2-marvell-onmicrosoft-com header.b=c6VATaQX; arc=pass (i=1 spf=pass spfdomain=marvell.com dkim=pass dkdomain=marvell.com dmarc=pass fromdomain=marvell.com); spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=marvell.com Received: from localhost ([::1]:47200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqJh-0001hD-Ks for alex.bennee@linaro.org; Fri, 11 Oct 2019 04:30:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43804) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqJV-0001d3-5V for qemu-arm@nongnu.org; Fri, 11 Oct 2019 04:30:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqJU-00068T-1p for qemu-arm@nongnu.org; Fri, 11 Oct 2019 04:30:17 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:50310 helo=mx0b-0016f401.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqJR-000669-7y; Fri, 11 Oct 2019 04:30:13 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9B8TjeF025858; Fri, 11 Oct 2019 01:30:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0818; bh=m3XYUSzhgopgd9Xgbyy4u+oJ/hfJs7vLDyu/QJZTF/k=; b=LMwGLrdDDMaLcw7DSGejHv/avUcFtVDTqd0hiFlPqpzuVT6rL+uEjr5ksdCBaj2ThwK+ xHnX+ApybLh9yzaPhsKz//99AIJbpo+J+7wIFC9iEqFDKy95s1EkTd71ezo+TYorBm6c w9HlZP0t8UN95MM0zZhLej56yODoaCkVJZyyYm7U1+kXf1EQ8S6bV7fy3kpX94nSVuCG ET5wB/yP/jFcgl/vxMFOGI0op39pYIVzuvI6SbAFuZGGD7AUGiCszYPzcBN8rr25ptWa kNE3cj2IrkHz++lcDex0kOcHyltxKefkTgAX7rbHNGfvhAnsDjomgY41gufIiuyO2kyZ OQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2vjj6v0tkj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 11 Oct 2019 01:30:05 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 11 Oct 2019 01:30:04 -0700 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.56) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 11 Oct 2019 01:30:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfypCrWjKskgySj6h/R731jqBmKJsDJmTmDUzbRP2NOKb5qrNsKaaKOssKcb5Qh4/cyKl4q2t5C6AmW2/F7ehlbuWHM1RItiDPTL+R6FxW3q8ftGVBSJz5vejEWiSfItlkaEOX7BUlkRRAR4I0BAKh9MnXnv8Yb1XKTfwL1brVbykfkHGduVfoKloP72ZmgqMBPVUB6kwvr5xj3Q3bQzWzC0PI4Cl5A84Lm92ecatDUQbXY70tlbvrfoYwUMHtB8Bjlczf1e1HAz/YS5psXm/ytDcuSUfmS/uWjt2ualFrJ2Ro/0e0EIsu836f8atweTEYEK/TSpPeE6uI1WiL+q6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m3XYUSzhgopgd9Xgbyy4u+oJ/hfJs7vLDyu/QJZTF/k=; b=EgX+ghkv7eR+5jTnnA5G3FPnXFrQ5KquZQcbKU1Yr0Hgi+Ac5Vbssb37dypRUt6PzjsEhtQrtweaMPYCuTI9SFs8NBVarXanwtSEQTBSmzntKRPerCA9+iatirfiSMeyEHX3qTMmdXhJRHlBlkSaglyOPeFOc22WpVYjm2EOM0br7hKmlebksQi24Uj+jSNlVoOxm524zbiNhbiK1IvMKwZpzsG8rd0w4BlnCgohSZ5w7MSHI/AVUCcBYpAgCuicAdrjgKAgpMxm7Q0pz1SEjcjGzSv5ZE4ip5W3itrcLeSn3sjIbSIaXmOe4b+ImnyilGJeGZv7DPiZnl9u4DSmUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m3XYUSzhgopgd9Xgbyy4u+oJ/hfJs7vLDyu/QJZTF/k=; b=c6VATaQXAs0qHZfXEqg4or1jFhBYNbKqfhwq7xSHEO/kZB1mIQJRkD518kNXnNosAZER1gkSC4gHLOL9iGWOQtr0tqemY4uLSyfLMMqN0vVQWNs01nQVuLpabA9gsfHCFP6JANx5odh7rCh08tVaQGBC30GhBjHPM9HHODxfoZE= Received: from DM6PR18MB3001.namprd18.prod.outlook.com (20.179.104.143) by DM6PR18MB2954.namprd18.prod.outlook.com (20.179.50.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Fri, 11 Oct 2019 08:30:02 +0000 Received: from DM6PR18MB3001.namprd18.prod.outlook.com ([fe80::11c2:98e0:b9d9:5dba]) by DM6PR18MB3001.namprd18.prod.outlook.com ([fe80::11c2:98e0:b9d9:5dba%5]) with mapi id 15.20.2347.016; Fri, 11 Oct 2019 08:30:02 +0000 From: Jan Glauber To: Paolo Bonzini Subject: Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues Thread-Topic: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues Thread-Index: AQHVgA4T6nIqkEBuW02+19lJnMn2Pw== Date: Fri, 11 Oct 2019 08:30:02 +0000 Message-ID: <20191011082954.GA10493@hc> References: <1864070a-2f84-1d98-341e-f01ddf74ec4b@ubuntu.com> <20190924202517.GA21422@xps13.dannf> <20191002092253.GA3857@hc> <6dd73749-49b0-0fbc-b9bb-44c3736642b8@redhat.com> <20191007144432.GA29958@xps13.dannf> <065a52a9-5bb0-1259-6c73-41af60e0a05d@redhat.com> <20191009080220.GA2905@hc> <20191011060518.GA6920@hc> <966c119d-aa76-2149-108f-867aebd772f7@redhat.com> In-Reply-To: <966c119d-aa76-2149-108f-867aebd772f7@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM0PR0102CA0056.eurprd01.prod.exchangelabs.com (2603:10a6:208::33) To DM6PR18MB3001.namprd18.prod.outlook.com (2603:10b6:5:182::15) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [46.5.207.169] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26b2a556-686f-4ca6-9767-08d74e2535de x-ms-traffictypediagnostic: DM6PR18MB2954: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0187F3EA14 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(4636009)(39860400002)(136003)(376002)(396003)(366004)(346002)(199004)(189003)(66446008)(305945005)(71200400001)(2906002)(14444005)(6916009)(229853002)(3846002)(316002)(4326008)(256004)(6246003)(33716001)(7736002)(6436002)(33656002)(54906003)(6486002)(6116002)(71190400001)(6512007)(99286004)(386003)(76176011)(486006)(6506007)(52116002)(9686003)(102836004)(8676002)(478600001)(66556008)(5660300002)(53546011)(81156014)(1076003)(4744005)(476003)(14454004)(86362001)(64756008)(66946007)(446003)(25786009)(8936002)(11346002)(26005)(66066001)(186003)(66476007)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR18MB2954; H:DM6PR18MB3001.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ic9s9TPBHW9V9oJWdmXE/ZW5+Tzk5uy+yM8bT38TiM/2UHKqukbfkgAvon+v/r80Gw89xwwurkXHHRwkWwhUrdpJq3SCvEhA1dcGLMxpJje3P1M6RMv517rj9EGjJoD0cmKUygfUXKiDOrJx52FCPjGd8ASpg/+5k9989vI9RFRqzv2C1gbUE5BpX1lcXFQGVoxnu4h0QVfaQRCwEVgJVYmzd2ABe2e8+TtDEgdCgRMFfNl7LRH+iaBTD1879sUNba2WsstLZOwr1o++WjhdollB5Qg7+wKz8ZF9D5wAcsnNJjYg096JUjqzY6QDWpOn1caLaKdB8FxxwIDiQqxWuXFVWUgPk37TvuIh/i9LDdZU017194CelI8N7h0/tEoaDSxEjQ3pUpnGjY/hLMMTe3ZXtsc9gDPagXPcrBf/cZ4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 26b2a556-686f-4ca6-9767-08d74e2535de X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 08:30:02.3439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r66uR2IFxhtphSWIzWoIcMSDY1/SwfWq1pkkF/eNV6IFMekDDHd9YsDDUc0ysEH1DsVEXnV4egMiCefULGWYfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2954 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-11_05:2019-10-10,2019-10-11 signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 67.231.148.174 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rafael David Tinoco , lizhengui , dann frazier , QEMU Developers , Bug 1805256 <1805256@bugs.launchpad.net>, QEMU Developers - ARM Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: lvidC3SO+0sV On Fri, Oct 11, 2019 at 10:18:18AM +0200, Paolo Bonzini wrote: > On 11/10/19 08:05, Jan Glauber wrote: > > On Wed, Oct 09, 2019 at 11:15:04AM +0200, Paolo Bonzini wrote: > >>> ...but if I bump notify_me size to uint64_t the issue goes away. > >> > >> Ouch. :) Is this with or without my patch(es)? >=20 > You didn't answer this question. Oh, sorry... I did but the mail probably didn't make it out. I have both of your changes applied (as I think they make sense). > >> Also, what if you just add a dummy uint32_t after notify_me? > >=20 > > With the dummy the testcase also runs fine for 500 iterations. >=20 > You might be lucky and causing list_lock to be in another cache line. > What if you add __attribute__((aligned(16)) to notify_me (and keep the > dummy)? Good point. I'll try to force both into the same cacheline. --Jan > Paolo >=20 > > Dann, can you try if this works on the Hi1620 too? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DFB5C47404 for ; Fri, 11 Oct 2019 08:41:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0177E214E0 for ; Fri, 11 Oct 2019 08:41:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0177E214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqUo-0001XU-5j for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 04:41:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45349) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqUB-00018f-Ss for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:41:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqUA-0002bD-EC for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:41:19 -0400 Received: from indium.canonical.com ([91.189.90.7]:35228) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIqUA-0002b3-8I for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:41:18 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1iIqU8-0003pV-Ki for ; Fri, 11 Oct 2019 08:41:16 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 982182E80C9 for ; Fri, 11 Oct 2019 08:41:16 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Fri, 11 Oct 2019 08:30:02 -0000 From: Jan Glauber To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=kunpeng920; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug: product=qemu; status=In Progress; importance=Undecided; assignee=rafaeldtinoco@kernelpath.com; X-Launchpad-Bug: distribution=ubuntu; sourcepackage=qemu; component=main; status=In Progress; importance=Medium; assignee=rafaeldtinoco@kernelpath.com; X-Launchpad-Bug: distribution=ubuntu; distroseries=bionic; sourcepackage=qemu; component=main; status=New; importance=Medium; assignee=None; X-Launchpad-Bug: distribution=ubuntu; distroseries=disco; sourcepackage=qemu; component=main; status=New; importance=Medium; assignee=None; X-Launchpad-Bug: distribution=ubuntu; distroseries=eoan; sourcepackage=qemu; component=main; status=In Progress; importance=Medium; assignee=rafaeldtinoco@kernelpath.com; X-Launchpad-Bug: distribution=ubuntu; distroseries=ff-series; sourcepackage=qemu; component=None; status=New; importance=Medium; assignee=None; X-Launchpad-Bug-Tags: qemu-img X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: dannf jan-glauber-i jnsnow lizhengui rafaeldtinoco X-Launchpad-Bug-Reporter: dann frazier (dannf) X-Launchpad-Bug-Modifier: Jan Glauber (jan-glauber-i) References: <154327283728.15443.11625169757714443608.malonedeb@soybean.canonical.com> Message-Id: <20191011082954.GA10493@hc> Subject: [Bug 1805256] Re: [Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="af2eefe214bd95389a09b7c956720881bab16807"; Instance="production-secrets-lazr.conf" X-Launchpad-Hash: 3c097e47f2b88607b2fb5ed4f58d20cf9b0de5a9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 91.189.90.7 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1805256 <1805256@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20191011083002.w6wyGE_ORZcvu2haQJGv0A3wgjYpYtO8fopaoGnFHJI@z> On Fri, Oct 11, 2019 at 10:18:18AM +0200, Paolo Bonzini wrote: > On 11/10/19 08:05, Jan Glauber wrote: > > On Wed, Oct 09, 2019 at 11:15:04AM +0200, Paolo Bonzini wrote: > >>> ...but if I bump notify_me size to uint64_t the issue goes away. > >> > >> Ouch. :) Is this with or without my patch(es)? > = > You didn't answer this question. Oh, sorry... I did but the mail probably didn't make it out. I have both of your changes applied (as I think they make sense). > >> Also, what if you just add a dummy uint32_t after notify_me? > > = > > With the dummy the testcase also runs fine for 500 iterations. > = > You might be lucky and causing list_lock to be in another cache line. > What if you add __attribute__((aligned(16)) to notify_me (and keep the > dummy)? Good point. I'll try to force both into the same cacheline. --Jan > Paolo > = > > Dann, can you try if this works on the Hi1620 too? -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images Status in kunpeng920: New Status in QEMU: In Progress Status in qemu package in Ubuntu: In Progress Status in qemu source package in Bionic: New Status in qemu source package in Disco: New Status in qemu source package in Eoan: In Progress Status in qemu source package in FF-Series: New Bug description: Command: qemu-img convert -f qcow2 -O qcow2 ./disk01.qcow2 ./output.qcow2 Hangs indefinitely approximately 30% of the runs. ---- Workaround: qemu-img convert -m 1 -f qcow2 -O qcow2 ./disk01.qcow2 ./output.qcow2 Run "qemu-img convert" with "a single coroutine" to avoid this issue. ---- (gdb) thread 1 ... (gdb) bt #0 0x0000ffffbf1ad81c in __GI_ppoll #1 0x0000aaaaaabcf73c in ppoll #2 qemu_poll_ns #3 0x0000aaaaaabd0764 in os_host_main_loop_wait #4 main_loop_wait ... (gdb) thread 2 ... (gdb) bt #0 syscall () #1 0x0000aaaaaabd41cc in qemu_futex_wait #2 qemu_event_wait (ev=3Dev@entry=3D0xaaaaaac86ce8 ) #3 0x0000aaaaaabed05c in call_rcu_thread #4 0x0000aaaaaabd34c8 in qemu_thread_start #5 0x0000ffffbf25c880 in start_thread #6 0x0000ffffbf1b6b9c in thread_start () (gdb) thread 3 ... (gdb) bt #0 0x0000ffffbf11aa20 in __GI___sigtimedwait #1 0x0000ffffbf2671b4 in __sigwait #2 0x0000aaaaaabd1ddc in sigwait_compat #3 0x0000aaaaaabd34c8 in qemu_thread_start #4 0x0000ffffbf25c880 in start_thread #5 0x0000ffffbf1b6b9c in thread_start ---- (gdb) run Starting program: /usr/bin/qemu-img convert -f qcow2 -O qcow2 ./disk01.ext4.qcow2 ./output.qcow2 [New Thread 0xffffbec5ad90 (LWP 72839)] [New Thread 0xffffbe459d90 (LWP 72840)] [New Thread 0xffffbdb57d90 (LWP 72841)] [New Thread 0xffffacac9d90 (LWP 72859)] [New Thread 0xffffa7ffed90 (LWP 72860)] [New Thread 0xffffa77fdd90 (LWP 72861)] [New Thread 0xffffa6ffcd90 (LWP 72862)] [New Thread 0xffffa67fbd90 (LWP 72863)] [New Thread 0xffffa5ffad90 (LWP 72864)] [Thread 0xffffa5ffad90 (LWP 72864) exited] [Thread 0xffffa6ffcd90 (LWP 72862) exited] [Thread 0xffffa77fdd90 (LWP 72861) exited] [Thread 0xffffbdb57d90 (LWP 72841) exited] [Thread 0xffffa67fbd90 (LWP 72863) exited] [Thread 0xffffacac9d90 (LWP 72859) exited] [Thread 0xffffa7ffed90 (LWP 72860) exited] """ All the tasks left are blocked in a system call, so no task left to call qemu_futex_wake() to unblock thread #2 (in futex()), which would unblock thread #1 (doing poll() in a pipe with thread #2). Those 7 threads exit before disk conversion is complete (sometimes in the beginning, sometimes at the end). ---- [ Original Description ] On the HiSilicon D06 system - a 96 core NUMA arm64 box - qemu-img frequently hangs (~50% of the time) with this command: qemu-img convert -f qcow2 -O qcow2 /tmp/cloudimg /tmp/cloudimg2 Where "cloudimg" is a standard qcow2 Ubuntu cloud image. This qcow2->qcow2 conversion happens to be something uvtool does every time it fetches images. Once hung, attaching gdb gives the following backtrace: (gdb) bt #0 0x0000ffffae4f8154 in __GI_ppoll (fds=3D0xaaaae8a67dc0, nfds=3D187650= 274213760, =C2=A0=C2=A0=C2=A0=C2=A0timeout=3D, timeout@entry=3D0x0, s= igmask=3D0xffffc123b950) =C2=A0=C2=A0=C2=A0=C2=A0at ../sysdeps/unix/sysv/linux/ppoll.c:39 #1 0x0000aaaabbefaf00 in ppoll (__ss=3D0x0, __timeout=3D0x0, __nfds=3D, =C2=A0=C2=A0=C2=A0=C2=A0__fds=3D) at /usr/include/aarch64-= linux-gnu/bits/poll2.h:77 #2 qemu_poll_ns (fds=3D, nfds=3D, =C2=A0=C2=A0=C2=A0=C2=A0timeout=3Dtimeout@entry=3D-1) at util/qemu-timer.= c:322 #3 0x0000aaaabbefbf80 in os_host_main_loop_wait (timeout=3D-1) =C2=A0=C2=A0=C2=A0=C2=A0at util/main-loop.c:233 #4 main_loop_wait (nonblocking=3D) at util/main-loop.c:497 #5 0x0000aaaabbe2aa30 in convert_do_copy (s=3D0xffffc123bb58) at qemu-im= g.c:1980 #6 img_convert (argc=3D, argv=3D) at qemu-= img.c:2456 #7 0x0000aaaabbe2333c in main (argc=3D7, argv=3D) at qemu= -img.c:4975 Reproduced w/ latest QEMU git (@ 53744e0a182) To manage notifications about this bug go to: https://bugs.launchpad.net/kunpeng920/+bug/1805256/+subscriptions