From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIqZ9-0006S6-CT for ath10k@lists.infradead.org; Fri, 11 Oct 2019 08:46:28 +0000 MIME-Version: 1.0 Subject: Re: [PATCH][next] ath10k: fix null dereference on pointer crash_data From: Kalle Valo In-Reply-To: <20191004160227.31577-1-colin.king@canonical.com> References: <20191004160227.31577-1-colin.king@canonical.com> Message-Id: <20191011084627.105B0605FE@smtp.codeaurora.org> Date: Fri, 11 Oct 2019 08:46:27 +0000 (UTC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Colin King Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S . Miller" Colin King wrote: > Currently when pointer crash_data is null the present null check > will also check that crash_data->ramdump_buf is null and will cause > a null pointer dereference on crash_data. Fix this by using the || > operator instead of &&. > > Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a69d3bdd4d40 ath10k: fix null dereference on pointer crash_data -- https://patchwork.kernel.org/patch/11174955/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k