From: Kalle Valo <kvalo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: "David S. Miller" <davem@davemloft.net>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Niklas Cassel <niklas.cassel@linaro.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] ath10k: Correct error check of dma_map_single()
Date: Fri, 11 Oct 2019 11:57:32 +0000 (UTC) [thread overview]
Message-ID: <20191011115732.173FC60ADE@smtp.codeaurora.org> (raw)
In-Reply-To: <20191010162653.141303-1-bjorn.andersson@linaro.org>
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> The return value of dma_map_single() should be checked for errors using
> dma_mapping_error(), rather than testing for NULL. Correct this.
>
> Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi")
> Cc: stable@vger.kernel.org
> Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Did this fix any real bug? Or is this just something found during code review?
--
https://patchwork.kernel.org/patch/11183923/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-11 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 16:26 [PATCH] ath10k: Correct error check of dma_map_single() Bjorn Andersson
2019-10-10 16:26 ` Bjorn Andersson
2019-10-11 11:57 ` Kalle Valo
2019-10-11 17:16 ` Bjorn Andersson
2019-10-11 17:16 ` Bjorn Andersson
2019-10-14 8:32 ` Kalle Valo
2019-10-14 8:32 ` Kalle Valo
2019-10-11 11:57 ` Kalle Valo [this message]
2019-10-11 18:28 ` [PATCH v2] ath10k: Correct error handling " Bjorn Andersson
2019-10-11 18:28 ` Bjorn Andersson
2019-10-14 8:43 ` Kalle Valo
2019-10-14 8:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011115732.173FC60ADE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.