From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-omap@vger.kernel.org, Jyri Sarha <jsarha@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var
Date: Fri, 11 Oct 2019 09:10:08 -0700 [thread overview]
Message-ID: <20191011161008.GY5610@atomide.com> (raw)
In-Reply-To: <d7cb0f2a-1645-29ff-aaf2-2ec5188dbc24@ti.com>
* Tomi Valkeinen <tomi.valkeinen@ti.com> [191011 10:25]:
> On 10/10/2019 16:24, Tony Lindgren wrote:
>
> > Hmm so what register does this clock actually change?
> >
> > I'm seeing an increase of few tens of extra mW, which means at
> > least one day of standby time less for me :) It does not happen
> > always, maybe half of the time.
>
> I have no idea why this would affect power consumption. As far as I can
> understand, the bits written here are a clk divider MCLK. I don't see why
> that would affect.
Yeah you're right, and I just got lucky initially.
I have seen the power consumption stay higher already with
the patch applied. The clocks seem just fine.
> Maybe Jyri or Peter has an idea, I have never looked at the HDMI audio side.
I'll try dumping out the hdmi registers before and after
when I get a chance.
Regards,
Tony
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-10-11 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 10:38 [PATCHv2 0/7] drm/omap: misc improvements Tomi Valkeinen
2019-09-30 10:38 ` [PATCHv2 1/7] drm/omap: drop unneeded locking from mgr_fld_write() Tomi Valkeinen
2019-09-30 10:38 ` [PATCHv2 2/7] drm/omap: avoid copy in mgr_fld_read/write Tomi Valkeinen
2019-10-04 7:02 ` Laurent Pinchart
2019-09-30 10:38 ` [PATCHv2 3/7] drm/omap: tweak HDMI DDC timings Tomi Valkeinen
2019-09-30 10:38 ` [PATCHv2 4/7] drm/omap: fix missing scaler pixel fmt limitations Tomi Valkeinen
2019-09-30 10:38 ` [PATCHv2 5/7] drm/omap: dss: move platform_register_drivers() to dss.c and remove core.c Tomi Valkeinen
2019-09-30 10:38 ` [PATCHv2 6/7] drm/omap: hdmi5: automatically choose limited/full range output Tomi Valkeinen
2019-09-30 10:38 ` [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var Tomi Valkeinen
2019-10-04 7:03 ` Laurent Pinchart
2019-10-08 14:13 ` Tony Lindgren
2019-10-08 14:16 ` Tomi Valkeinen
2019-10-08 14:21 ` Tony Lindgren
2019-10-10 6:47 ` Tomi Valkeinen
2019-10-10 13:24 ` Tony Lindgren
2019-10-11 10:25 ` Tomi Valkeinen
2019-10-11 16:10 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011161008.GY5610@atomide.com \
--to=tony@atomide.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.