All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Chris Laplante <chris.laplante@agilent.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 0/9] BitBake Vim indentation plugin
Date: Fri, 11 Oct 2019 19:43:51 +0200	[thread overview]
Message-ID: <20191011174351.GA1563@jama> (raw)
In-Reply-To: <cover.1570810590.git.chris.laplante@agilent.com>

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

On Fri, Oct 11, 2019 at 12:22:58PM -0400, Chris Laplante via bitbake-devel wrote:
> This patchset adds Vim indentation support for the BitBake language.
> 
> It supports indenting variable assignments, Python and shell tasks/functions.
> To accomplish Python indentation, it uses a hacked-up version of the Python indenter
> from Vim upstream. The upstream shell indenter is used directly, without
> modification, however in the future it will be necessary to modify the shell
> indenter to properly support "fakeroot" shell tasks.

Thank you. As vim user I'll test this soon.

Does the above mean that it will use 4 spaces for python and tabs for
shell tasks like oe-core is using?

Would it be possible to simply modify it locally to use 4 spaces for
indentation everywhere like other OE layers are using?

https://www.openembedded.org/wiki/Styleguide#Format_Guidelines

Cheers,

> The following changes since commit 94f6b31befda5c496f65e863a6f8152b42d7ebf0:
> 
>   build-appliance-image: Update to master head revision (2019-10-09 22:28:50 +0100)
> 
> are available in the git repository at:
> 
>   git://git.yoctoproject.org/poky-contrib cpl/bitbake-vim
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=cpl/bitbake-vim
> 
> Chris Laplante (9):
>   bitbake: contrib/vim: initial commit, with unmodified code from
>     indent/python.vim
>   bitbake: contrib/vim: Modify Python indentation to work with 'python
>     do_task {'
>   bitbake: contrib/vim: More Python indenting; move indent file to
>     correct directory
>   bitbake: contrib/vim: Special handling of bb.fatal
>   bitbake: contrib/vim: don't redeclare indenter
>   bitbake: contrib/vim: renaming & comments
>   bitbake: contrib/vim: indenting for assignments; tweak Python
>     indenting
>   bitbake: contrib/vim: handle shell indenting
>   bitbake: contrib/vim: Add copyright and license notice
> 
>  bitbake/contrib/vim/indent/bitbake.vim | 342 +++++++++++++++++++++++++++++++++
>  1 file changed, 342 insertions(+)
>  create mode 100644 bitbake/contrib/vim/indent/bitbake.vim
> 
> --
> 2.7.4
> 
> -- 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  parent reply	other threads:[~2019-10-11 17:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11 16:22 [PATCH 0/9] BitBake Vim indentation plugin Chris Laplante
2019-10-11 16:23 ` [PATCH 1/9] bitbake: contrib/vim: initial commit, with unmodified code from indent/python.vim Chris Laplante
2019-10-11 20:16   ` Paul Barker
2019-10-11 20:27     ` chris.laplante
2019-10-11 16:23 ` [PATCH 2/9] bitbake: contrib/vim: Modify Python indentation to work with 'python do_task {' Chris Laplante
2019-10-11 16:23 ` [PATCH 3/9] bitbake: contrib/vim: More Python indenting; move indent file to correct directory Chris Laplante
2019-10-11 16:23 ` [PATCH 4/9] bitbake: contrib/vim: Special handling of bb.fatal Chris Laplante
2019-10-11 16:23 ` [PATCH 5/9] bitbake: contrib/vim: don't redeclare indenter Chris Laplante
2019-10-11 16:23 ` [PATCH 6/9] bitbake: contrib/vim: renaming & comments Chris Laplante
2019-10-11 16:23 ` [PATCH 7/9] bitbake: contrib/vim: indenting for assignments; tweak Python indenting Chris Laplante
2019-10-11 16:23 ` [PATCH 8/9] bitbake: contrib/vim: handle shell indenting Chris Laplante
2019-10-11 16:23 ` [PATCH 9/9] bitbake: contrib/vim: Add copyright and license notice Chris Laplante
2019-10-11 17:43 ` Martin Jansa [this message]
2019-10-11 17:52   ` [PATCH 0/9] BitBake Vim indentation plugin chris.laplante

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011174351.GA1563@jama \
    --to=martin.jansa@gmail.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=chris.laplante@agilent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.