From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B95C47404 for ; Fri, 11 Oct 2019 18:39:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5F33206CD for ; Fri, 11 Oct 2019 18:39:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5F33206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIzp3-0006Vj-Sp for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 14:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57049) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIzXy-00036I-7S for qemu-devel@nongnu.org; Fri, 11 Oct 2019 14:21:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIzXw-0004uH-AV for qemu-devel@nongnu.org; Fri, 11 Oct 2019 14:21:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35847) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIzXw-0004tm-3Z for qemu-devel@nongnu.org; Fri, 11 Oct 2019 14:21:48 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4BC6A30024DA; Fri, 11 Oct 2019 18:21:47 +0000 (UTC) Received: from localhost (ovpn-116-20.phx2.redhat.com [10.3.116.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id A55355DC1E; Fri, 11 Oct 2019 18:21:44 +0000 (UTC) Date: Fri, 11 Oct 2019 15:21:43 -0300 From: Eduardo Habkost To: Xiaoyao Li Subject: Re: [PATCH v2] target/i386: Add Snowridge-v2 (noMPX) CPU model Message-ID: <20191011182143.GD4084@habkost.net> References: <20191011145349.123425-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191011145349.123425-1-xiaoyao.li@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 11 Oct 2019 18:21:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Oct 11, 2019 at 10:53:49PM +0800, Xiaoyao Li wrote: > Add new version of Snowridge CPU model that removes MPX feature. > > MPX support is being phased out by Intel. GCC has dropped it, Linux kernel > and kvm are also going to do that in the future. > > Signed-off-by: Xiaoyao Li > --- > Changes in v2: > - Use CPU model versioning mechanism instead of machine-type compat > --- > target/i386/cpu.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 44f1bbdcac76..27b0a17b46a8 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -2793,6 +2793,19 @@ static X86CPUDefinition builtin_x86_defs[] = { > CPUID_6_EAX_ARAT, > .xlevel = 0x80000008, > .model_id = "Intel Atom Processor (SnowRidge)", > + .versions = (X86CPUVersionDefinition[]) { > + { .version = 1 }, > + { > + .version = 2, > + .alias = "Snowridge-noMPX", The intention is to stop creating new funny names for CPU model variations, now, and stick to -v1, -v2, -v3, etc. The .alias field is optional, and was added only for compatibility with the existing -noTSX and -IBRS CPU models. > + .props = (PropValue[]) { > + { "mpx", "off" }, > + { "model-id", "Intel Atom Processor (Snowridge, no MPX)" }, Do you think it's important to report a different model-id? I would keep it the same and only add mpx=off. > + { /* end of list */ }, > + }, > + }, > + { /* end of list */ }, > + }, > }, > { > .name = "KnightsMill", > -- > 2.19.1 > -- Eduardo