From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>,
dmurphy@ti.com, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] leds: tlc591xx: update the maximum brightness
Date: Sun, 13 Oct 2019 13:45:08 +0200 [thread overview]
Message-ID: <20191013114508.GI5653@amd> (raw)
In-Reply-To: <91864098-a6e8-e275-4b07-e4bb15469f78@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
Hi!
> > @@ -112,11 +113,11 @@ tlc591xx_brightness_set(struct led_classdev *led_cdev,
> > struct tlc591xx_priv *priv = led->priv;
> > int err;
> >
> > - switch (brightness) {
> > + switch ((int)brightness) {
> > case 0:
Can we get a rid of the cast here? Do we need to move away from the
enum for the brightness?
> Added tag:
>
> Fixes: e370d010a5fe ("leds: tlc591xx: Driver for the TI 8/16 Channel i2c
> LED driver")
>
> and applied to the for-5.5 branch.
Actually, careful with the Fixes tag. -stable people will want to
apply it, and it may not be a good idea in this case. Maximum
brightness of 256 is pretty unusual, so I'd call this "a bit risky".
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-10-13 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 10:02 [PATCH] leds: tlc591xx: update the maximum brightness Jean-Jacques Hiblot
2019-09-24 19:26 ` Jacek Anaszewski
2019-10-13 11:45 ` Pavel Machek [this message]
2019-10-13 16:36 ` Jacek Anaszewski
2019-10-14 10:37 ` Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013114508.GI5653@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.