From: Pavel Machek <pavel@ucw.cz>
To: Andrew Macks <andypoo@gmail.com>,
stable@kernel.org, Greg KH <greg@kroah.com>,
kernel list <linux-kernel@vger.kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: Regression in longterm 4.19: f2fs: use generic EFSBADCRC/EFSCORRUPTED
Date: Sun, 13 Oct 2019 23:44:41 +0200 [thread overview]
Message-ID: <20191013214440.GA20196@amd> (raw)
In-Reply-To: <CAFeYvHXQQPfu+r0kLpTXWRZJr8SFF1QyUWzOkjJYFE2_UVSrUA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]
On Sat 2019-10-12 21:55:24, Andrew Macks wrote:
> Sorry for version typo in the previous message.
>
> In addition to 4.19, the issue was also backported to 4.14 and 5.2.
>
> 4.14, 4.19 and 5.2 are all missing the EINVAL fix from 5.3.
Ouch.
Well, when I seen the patch, I thought "looks like the bug is not
serious enough for -stable". I guess I should have spoken up.
Anyway, I guess we need to either revert 59a5cea41dd0a or backport
38fb6d0ea34299d97b too....
So I guess Greg and lists need to be cc-ed... and
Thanks for the report and sorry for the trouble....
Pavel
> Andrew.
>
> On Sat, 12 Oct 2019 at 21:39, Andrew Macks <andypoo@gmail.com> wrote:
>
> > Hi - there is a nasty regression which was recently introduced into
> > longterm 4.19.76.
> >
> > 59a5cea41dd0ae706ab83f8ecd64199aadefb493 was committed to 4.19, however it
> > introduces a regression that filesystems no longer mount if do_mounts
> > iterates through them after F2FS. This surfaced on one of my servers as
> > F2FS superblock check happens before btrfs mount is attempted.
> >
> > With this code, my server panicked after kernel upgrade as btrfs mount
> > wasn't attempted.
> >
> > This issue has already been fixed in 5.3 with this patch in July, but it
> > was missed from the 4.19 backport.
> >
> > 38fb6d0ea34299d97b031ed64fe994158b6f8eb3
> > f2fs: use EINVAL for superblock with invalid magic
> >
> > Andypoo.
> >
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next parent reply other threads:[~2019-10-13 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFeYvHWC=RZJr2ZSAvRy=r1kAJU8YW-hxkZ3uBAd2OQEerKmag@mail.gmail.com>
[not found] ` <CAFeYvHXQQPfu+r0kLpTXWRZJr8SFF1QyUWzOkjJYFE2_UVSrUA@mail.gmail.com>
2019-10-13 21:44 ` Pavel Machek [this message]
2019-10-14 16:37 ` Regression in longterm 4.19: f2fs: use generic EFSBADCRC/EFSCORRUPTED Jaegeuk Kim
2019-10-15 6:18 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013214440.GA20196@amd \
--to=pavel@ucw.cz \
--cc=andypoo@gmail.com \
--cc=greg@kroah.com \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.