From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xin Ji Subject: Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding Date: Mon, 14 Oct 2019 02:53:33 +0000 Message-ID: <20191014025322.GA2390@xin-VirtualBox> References: <75bb8a47d2c3c1f979c6d62158c21988b846e79b.1570760115.git.xji@analogixsemi.com> <3c6067de-9f3c-b93c-f263-fa5dd09c3270@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <3c6067de-9f3c-b93c-f263-fa5dd09c3270@samsung.com> Content-Language: en-US Content-ID: <7D2EC0DAA8B81945BC9C60B8717ED260@namprd04.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: Andrzej Hajda Cc: "devel@driverdev.osuosl.org" , Laurent Pinchart , Dan Carpenter , Neil Armstrong , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Sheng Pan List-Id: dri-devel@lists.freedesktop.org Hi Andrzej Hajda, please check my comment below. Thanks, Xin On Fri, Oct 11, 2019 at 01:21:43PM +0200, Andrzej Hajda wrote: > On 11.10.2019 04:21, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > > > You can add support to your board with binding. > > > > Example: > > anx7625_bridge: encoder@58 { > > compatible =3D "analogix,anx7625"; > > reg =3D <0x58>; > > status =3D "okay"; > > panel-flags =3D <1>; > > enable-gpios =3D <&pio 45 GPIO_ACTIVE_HIGH>; > > reset-gpios =3D <&pio 73 GPIO_ACTIVE_HIGH>; > > #address-cells =3D <1>; > > #size-cells =3D <0>; > > > > port@0 { > > reg =3D <0>; > > anx_1_in: endpoint { > > remote-endpoint =3D <&mipi_dsi>; > > }; > > }; > > > > port@3 { > > reg =3D <3>; > > anx_1_out: endpoint { > > remote-endpoint =3D <&panel_in>; > > }; > > }; > > }; > > > > Signed-off-by: Xin Ji > > --- > > .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++= ++++++++ > > 1 file changed, 96 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/an= x7625.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.y= aml b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml > > new file mode 100644 > > index 0000000..fc84683 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml > > @@ -0,0 +1,96 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +# Copyright 2019 Analogix Semiconductor, Inc. > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) > > + > > +maintainers: > > + - Xin Ji > > + > > +description: | > > + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter > > + designed for portable devices. > > + > > +properties: > > + "#address-cells": true > > + "#size-cells": true > > + > > + compatible: > > + items: > > + - const: analogix,anx7625 > > + > > + reg: > > + maxItems: 1 > > + > > + panel-flags: > > + description: indicate the panel is internal or external > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + enable-gpios: > > + description: used for power on chip control, POWER_EN pin D2. > > + maxItems: 1 > > + > > + reset-gpios: > > + description: used for reset chip control, RESET_N pin B7. > > + maxItems: 1 > > + > > + port@0: > > + type: object > > + description: > > + A port node pointing to MIPI DSI host port node. > > + > > + port@1: > > + type: object > > + description: > > + A port node pointing to MIPI DPI host port node. > > + > > + port@2: > > + type: object > > + description: > > + A port node pointing to external connector port node. > > + > > + port@3: > > + type: object > > + description: > > + A port node pointing to eDP port node. >=20 >=20 > Decrypting available product brief[1], there are following physical lines= : >=20 > Input: >=20 > - MIPI DSI/DPI - video data, are DSI and DPI lines shared? >=20 > - I2S - audio data, >=20 > - I2C - control line, >=20 > - ALERT/INTP - interrupt, >=20 > - USB 3.1 SSRc/Tx - for USB forwarding, >=20 > Output: >=20 > - SS1, SS2, >=20 > - SBU/AUX, >=20 > - CC1/2. At this application, we didn't use CC1/2 line, we only use the video format convert(MIPI to DP) feature on anx7625. >=20 >=20 > Having this information I try to understand ports defined by you: >=20 > - port@2 you have defined as pointing to external port, but here the > port should be rather subnode of ANX7625 - the chip has CC lines, see > beginning of [2]. The port@2 is for Chromium book external port low power mode control, the driver according this port to register external connector notify interface to receive "connect/disconnect" event to do low power control. >=20 > - port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In > USB-C binding SBU and SS lines are represented by different ports, > different approach, but maybe better in this case. >=20 >=20 > Maybe it would be good to add 2nd example with USB-C port. No need to add 2nd example with USB-C port, as I said, we didn't use the USB Type-C PD feature at anx7625. >=20 >=20 > [1]: > https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief= .pdf >=20 > [2]: Documentation/devicetree/bindings/connector/usb-connector.txt >=20 >=20 > Regards >=20 > Andrzej >=20 >=20 > > + > > +required: > > + - "#address-cells" > > + - "#size-cells" > > + - compatible > > + - reg > > + - port@0 > > + - port@3 > > + > > +example: > > + - | > > + anx7625_bridge: encoder@58 { > > + compatible =3D "analogix,anx7625"; > > + reg =3D <0x58>; > > + status =3D "okay"; > > + panel-flags =3D <1>; > > + enable-gpios =3D <&pio 45 GPIO_ACTIVE_HIGH>; > > + reset-gpios =3D <&pio 73 GPIO_ACTIVE_HIGH>; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + port@0 { > > + reg =3D <0>; > > + anx_1_in: endpoint { > > + remote-endpoint =3D <&mipi_dsi>; > > + }; > > + }; > > + > > + port@3 { > > + reg =3D <3>; > > + anx_1_out: endpoint { > > + remote-endpoint =3D <&panel_in>; > > + }; > > + }; > > + }; >=20