Re: [PATCH v7 5/5] backlight: add led-backlight driver

[Lee Jones <lee.jones@linaro.org>]

On Fri, 04 Oct 2019, Jean-Jacques Hiblot wrote:

> Hi Lee,
> 
> On 04/10/2019 16:39, Lee Jones wrote:
> > On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
> > 
> > > From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > 
> > > This patch adds a led-backlight driver (led_bl), which is similar to
> > > pwm_bl except the driver uses a LED class driver to adjust the
> > > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > > 
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > ---
> > >   drivers/video/backlight/Kconfig  |   7 +
> > >   drivers/video/backlight/Makefile |   1 +
> > >   drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++
> > >   3 files changed, 268 insertions(+)
> > >   create mode 100644 drivers/video/backlight/led_bl.c
> > Applied, thanks.
> 
> It will break the build because it relies on functions not yet in the LED
> core (devm_led_get() for v7 or devm_of_led_get() for v8)

You're right, un-applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog