From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH 4/4] qemu-nbd: Support help options for --object
Date: Mon, 14 Oct 2019 11:47:02 +0200 [thread overview]
Message-ID: <20191014094702.GB7173@localhost.localdomain> (raw)
In-Reply-To: <8b1b33d0-eb17-1e1d-1731-37870d1f3ac5@redhat.com>
Am 11.10.2019 um 23:39 hat Eric Blake geschrieben:
> On 10/11/19 3:55 PM, Kevin Wolf wrote:
> > Instead of parsing help options as normal object properties and
> > returning an error, provide the same help functionality as the system
> > emulator in qemu-nbd, too.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
> Missing a change in qemu-nbd.texi for man page coverage.
Hm... Both qemu-img and qemu-nbd manpages refer to qemu(1) for the
details. I wouldn't mind copying the text for '-object help' from there
anyway, but unfortunately it doesn't even exist. :-)
So this looks like a separate patch that fixes it for qemu, too.
> But the patch is a strict improvement, so even if we have to add a
> followup patch for documentation, I'm okay with:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> This patch touches NBD, but I'm assuming it's easier to take the series
> through your tree.
Yes, thanks.
Kevin
prev parent reply other threads:[~2019-10-14 9:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 20:55 [PATCH 0/4] qemu-img/io/nbd: Support help options for --object Kevin Wolf
2019-10-11 20:55 ` [PATCH 1/4] vl: Split off user_creatable_print_help() Kevin Wolf
2019-10-11 21:35 ` Eric Blake
2019-10-14 9:55 ` Kevin Wolf
2019-10-14 14:18 ` Eric Blake
2019-10-11 20:55 ` [PATCH 2/4] qemu-io: Support help options for --object Kevin Wolf
2019-10-11 21:36 ` Eric Blake
2019-10-11 20:55 ` [PATCH 3/4] qemu-img: " Kevin Wolf
2019-10-11 21:37 ` Eric Blake
2019-10-11 20:55 ` [PATCH 4/4] qemu-nbd: " Kevin Wolf
2019-10-11 21:39 ` Eric Blake
2019-10-14 9:47 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014094702.GB7173@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.