Re: [PATCH] keys: Do not check the retval of commit_creds in join_session_keyring

["Marcus Hüwe" <suse-tux@gmx.de>]

Just a gentle ping - any news on this?:)

On 2019-09-10 16:07:59 +0200, Marcus Huewe wrote:
> Do not check the return value of the commit_creds call in
> join_session_keyring in order to make the code more concise.
> Since commit_creds always returns 0, the if-statement is not needed
> and the session keyring's serial can be directly assigned to the
> "ret" variable.
>
> Signed-off-by: Marcus Huewe <suse-tux@gmx.de>
> ---
>  security/keys/process_keys.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
> index 09541de31f2f..e7cd1ff84709 100644
> --- a/security/keys/process_keys.c
> +++ b/security/keys/process_keys.c
> @@ -840,7 +840,7 @@ long join_session_keyring(const char *name)
>  	const struct cred *old;
>  	struct cred *new;
>  	struct key *keyring;
> -	long ret, serial;
> +	long ret;
>
>  	new = prepare_creds();
>  	if (!new)
> @@ -853,10 +853,8 @@ long join_session_keyring(const char *name)
>  		if (ret < 0)
>  			goto error;
>
> -		serial = new->session_keyring->serial;
> -		ret = commit_creds(new);
> -		if (ret == 0)
> -			ret = serial;
> +		ret = new->session_keyring->serial;
> +		commit_creds(new);
>  		goto okay;
>  	}
>
> --
> 2.22.0
>