From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20F4C4CECE for ; Mon, 14 Oct 2019 15:49:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C53892133F for ; Mon, 14 Oct 2019 15:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571068141; bh=xq3qBXDUA2E4LNxPIv6VCnTM+7qSpa8isiGjiFst7LU=; h=From:To:Cc:Subject:Date:List-ID:From; b=K9btn+KZA3WTP/qycjVxBcWWUvd5rFki81aTvb+ISfYj30qD3ybwiLgqJObR7cu2O xPRRtlHFvOFmaLIQEbwfze9SDszAhKLVdgtz9CA1AWONoTnVkViKs24wKsRCo33iNX qQBClApqSBzWDcDTDZGFb0iVhjBSCbuy6S707P6U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729992AbfJNPtA (ORCPT ); Mon, 14 Oct 2019 11:49:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbfJNPtA (ORCPT ); Mon, 14 Oct 2019 11:49:00 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 282BB3079B77; Mon, 14 Oct 2019 15:49:00 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.205.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF88D5D9C9; Mon, 14 Oct 2019 15:48:57 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen Subject: [PATCH] perf jvmti: Link in tools/lib/ctype.o Date: Mon, 14 Oct 2019 17:48:56 +0200 Message-Id: <20191014154856.25306-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 14 Oct 2019 15:49:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The libperf-jvmti.so links already with tools/lib/string.o to use strlcpy. However the string.o depends on ctype.o so we need to link it in as well. Fixes: 79743bc927f6 ("perf jvmti: Link against tools/lib/string.o to have weak strlcpy()") Link: http://lkml.kernel.org/n/tip-zitavtnkcu2guqwfgtp7n7bg@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/jvmti/Build | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/jvmti/Build b/tools/perf/jvmti/Build index 1e148bbdf820..7de7f90bf3fb 100644 --- a/tools/perf/jvmti/Build +++ b/tools/perf/jvmti/Build @@ -3,6 +3,7 @@ jvmti-y += jvmti_agent.o # For strlcpy jvmti-y += libstring.o +jvmti-y += libctype.o CFLAGS_jvmti = -fPIC -DPIC -I$(JDIR)/include -I$(JDIR)/include/linux CFLAGS_REMOVE_jvmti = -Wmissing-declarations @@ -15,3 +16,7 @@ CFLAGS_libstring.o += -Wno-unused-parameter -DETC_PERFCONFIG="BUILD_STR($(ETC_PE $(OUTPUT)jvmti/libstring.o: ../lib/string.c FORCE $(call rule_mkdir) $(call if_changed_dep,cc_o_c) + +$(OUTPUT)jvmti/libctype.o: ../lib/ctype.c FORCE + $(call rule_mkdir) + $(call if_changed_dep,cc_o_c) -- 2.21.0