From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7488C4CECE for ; Mon, 14 Oct 2019 15:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E45620673 for ; Mon, 14 Oct 2019 15:51:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="cprVr47S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731357AbfJNPvA (ORCPT ); Mon, 14 Oct 2019 11:51:00 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44930 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730314AbfJNPvA (ORCPT ); Mon, 14 Oct 2019 11:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=V6rqbb+UANVF+/Q8llIZetnk+Zj3g1WyfTEY9wi1GD4=; b=cprVr47S8jsGQKekpBktgrN3PE p2LsiEIAEPzKfcDSu5dX/7PQSgqcb34UC1mDAhLp4kS+yYo1HhxC+a5EibMndo86ZZQh2lcCykZb/ ZWqWOpPI86z5QvtcNwzCF5U81fRdnmOF8iwJCXOIvF9YHXaAwZ7WIpfENtPsSiTkIsmM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iK2cZ-00068I-SD; Mon, 14 Oct 2019 17:50:55 +0200 Date: Mon, 14 Oct 2019 17:50:55 +0200 From: Andrew Lunn To: Igor Russkikh Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , "richardcochran@gmail.com" , Egor Pomozov , Dmitry Bezrukov , Simon Edelhaus Subject: Re: [PATCH v2 net-next 02/12] net: aquantia: unify styling of bit enums Message-ID: <20191014155055.GL21165@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Oct 08, 2019 at 10:56:38AM +0000, Igor Russkikh wrote: > From: Dmitry Bezrukov > > Make some other bit-enums more clear about positioning, > this helps on debugging and development > > Signed-off-by: Dmitry Bezrukov > Signed-off-by: Igor Russkikh Reviewed-by: Andrew Lunn Andrew