From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm list <kvm@vger.kernel.org>,
Liran Alon <liran.alon@oracle.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Dan Cross <dcross@google.com>, Peter Shier <pshier@google.com>
Subject: Re: [PATCH v3] KVM: nVMX: Don't leak L1 MMIO regions to L2
Date: Mon, 14 Oct 2019 12:52:26 -0700 [thread overview]
Message-ID: <20191014195226.GJ22962@linux.intel.com> (raw)
In-Reply-To: <CALMp9eS-xPS2DYK10L_QYkEufUUoTAJU0++rqMEQkSRgu-4KpA@mail.gmail.com>
On Mon, Oct 14, 2019 at 12:37:39PM -0700, Jim Mattson wrote:
> On Mon, Oct 14, 2019 at 12:15 PM Sean Christopherson
> <sean.j.christopherson@intel.com> wrote:
> >
> > On Mon, Oct 14, 2019 at 11:50:37AM -0700, Jim Mattson wrote:
> > > NESTED_VMX_ENTER_NON_ROOT_MODE_STATUS_KVM_INTERNAL_ERROR?
> >
> > I can't tell if you're making fun of me for being pedantic about "Enter VMX",
> > or if you really want to have a 57 character enum. :-)
> >
> > NESTED_VMENTER_?
>
> It's difficult to balance brevity and clarity. I have no problem with
> 57 character enums, but I understand that Linux line-wrapping
> conventions are designed for the VT100, so long enums present a
> challenge. :-)
Heh, the real problem is that I forgot what I was reading by the time I
got to "STATUS".
> How about:
>
> NVMX_VMENTRY_SUCCESS
> NVMX_VMENTRY_VMFAIL
> NVMX_VMENTRY_VMEXIT
> NVMX_VMENTRY_INTERNAL_ERROR
Works for me. Maybe NVMX_VMENTRY_KVM_INTERNAL_ERROR to be consistent?
prev parent reply other threads:[~2019-10-14 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 23:28 [PATCH v3] KVM: nVMX: Don't leak L1 MMIO regions to L2 Jim Mattson
2019-10-14 17:59 ` Sean Christopherson
2019-10-14 18:50 ` Jim Mattson
2019-10-14 19:15 ` Sean Christopherson
2019-10-14 19:37 ` Jim Mattson
2019-10-14 19:52 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014195226.GJ22962@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=dcross@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.