From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH 3/3] perf tools: Make 'struct map_shared' truly shared
Date: Mon, 14 Oct 2019 22:40:32 +0200 [thread overview]
Message-ID: <20191014204032.GC15890@krava> (raw)
In-Reply-To: <20191014194619.GS9933@tassilo.jf.intel.com>
On Mon, Oct 14, 2019 at 12:46:19PM -0700, Andi Kleen wrote:
> > > We may need a COW operation for this (hopefully rare) case.
> >
> > so the jitted mmaps are inserted into the data file
> > and processed during report where they can overload
> > existing maps - thats detected before addition in:
> >
> > thread__insert_map
> > map_groups__fixup_overlappings
> > - which uses COW way -> map__clone(map, false);
> > to create new map
> >
> > other fixups to maps are being done only for kernel maps,
> > where we dont have a problem, because there's only one copy
>
> I assume the same is true for /tmp/perf-* processing?
>
perf-*.map processing adds only symbol for dso,
it does not touch maps, so we're fine
dso__load -> dso__load_perf_map
jirka
prev parent reply other threads:[~2019-10-14 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 15:14 [PATCH 0/3] perf tools: Share struct map after clone Jiri Olsa
2019-10-13 15:14 ` [PATCH 1/3] perf tools: Allow to build with -ltcmalloc Jiri Olsa
2019-10-14 1:33 ` Andi Kleen
2019-10-14 14:01 ` Arnaldo Carvalho de Melo
2019-10-21 23:19 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-10-13 15:14 ` [PATCH 2/3] perf tools: Separate shareable part of 'struct map' into 'struct map_shared' Jiri Olsa
2019-10-13 15:14 ` [PATCH 3/3] perf tools: Make 'struct map_shared' truly shared Jiri Olsa
2019-10-14 3:10 ` Andi Kleen
2019-10-14 8:48 ` Jiri Olsa
2019-10-14 19:20 ` Jiri Olsa
2019-10-14 19:46 ` Andi Kleen
2019-10-14 20:40 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014204032.GC15890@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.