From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E380C4CECE for ; Mon, 14 Oct 2019 21:04:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BD1E2133F for ; Mon, 14 Oct 2019 21:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732055AbfJNVEd (ORCPT ); Mon, 14 Oct 2019 17:04:33 -0400 Received: from mga02.intel.com ([134.134.136.20]:26083 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726304AbfJNVEc (ORCPT ); Mon, 14 Oct 2019 17:04:32 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Oct 2019 14:04:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,296,1566889200"; d="scan'208";a="396595099" Received: from kridax-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.7.178]) by fmsmga006.fm.intel.com with ESMTP; 14 Oct 2019 14:04:30 -0700 Date: Tue, 15 Oct 2019 00:04:29 +0300 From: Jarkko Sakkinen To: Sean Christopherson Cc: linux-sgx@vger.kernel.org Subject: Re: [PATCH for_v23 00/16] x86/vdso: sgx: Major vDSO cleanup Message-ID: <20191014210429.GV15552@linux.intel.com> References: <20191008044613.12350-1-sean.j.christopherson@intel.com> <20191010081019.GA20654@linux.intel.com> <20191010160847.GA23798@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010160847.GA23798@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Thu, Oct 10, 2019 at 09:08:47AM -0700, Sean Christopherson wrote: > On Thu, Oct 10, 2019 at 11:10:19AM +0300, Jarkko Sakkinen wrote: > > On Mon, Oct 07, 2019 at 09:45:57PM -0700, Sean Christopherson wrote: > > > The main purpose of this series is to implement feedback from the original > > > RFC to expand the vDSO[*] that went unaddressed before the expanded > > > function was rushed into v21. > > > > > > The other half of the series is to overhaul the selftest to actually test > > > the exit handler variation of the vDSO, with a bunch of prework to add an > > > assertion framework to standardize the various assertions in the test and > > > improve the readability of the code. > > > > > > The basic ideas for the exit handler subtests are from Cedric's original > > > RFC, but rewritten from scratch to take advantage of the new assertion > > > framework. I haven't yet implemented single-step subtest, ideally that > > > too will get done before v23. > > > > > > [*] https://lkml.kernel.org/r/20190426210017.GA24467@linux.intel.com > > > > > > Sean Christopherson (16): > > > x86/vdso: sgx: Drop the pseudocode "documentation" > > > x86/vdso: sgx: Do not use exception info to pass success/failure > > > x86/vdso: sgx: Rename the enclave exit handler typedef > > > x86/vdso: sgx: Move enclave exit handler declaration to UAPI header > > > x86/vdso: sgx: Add comment regarding kernel-doc shenanigans > > > x86/vdso: sgx: Rewrite __vdso_sgx_enter_enclave() function comment > > > selftests/x86: Fix linker warning in SGX selftest > > > selftests/x86/sgx: Use getauxval() to retrieve the vDSO base address > > > selftests/x86/sgx: Add helper function and macros to assert results > > > selftests/x86/sgx: Handle setup failures via test assertions > > > selftests/x86/sgx: Sanitize the types for sgx_call()'s input params > > > selftests/x86/sgx: Move existing sub-test to a separate helper > > > selftests/x86/sgx: Add a test of the vDSO exception reporting > > > mechanism > > > selftests/x86/sgx: Add test of vDSO with basic exit handler > > > selftests/x86/sgx: Add sub-test for exception behavior with exit > > > handler > > > x86/vdso: sgx: Rework __vdso_sgx_enter_enclave() to prefer "no > > > callback" > > > > > > arch/x86/entry/vdso/vsgx_enter_enclave.S | 228 +++++++------ > > > arch/x86/include/uapi/asm/sgx.h | 18 + > > > tools/testing/selftests/x86/sgx/Makefile | 2 +- > > > tools/testing/selftests/x86/sgx/defines.h | 6 + > > > tools/testing/selftests/x86/sgx/main.c | 384 ++++++++++++++-------- > > > 5 files changed, 387 insertions(+), 251 deletions(-) > > > > > > -- > > > 2.22.0 > > > > > > > vDSO changes look legit. I might do some minor edits (like coding > > style tweaks only). Thanks. > > Let me send v2 to fix the stack alignment issue Cedric pointed out, along > with a selftest enhancement to verify the alignment. Unfortunately I already applied these. /Jarkko