From: Sasha Levin <sashal@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-gpio@vger.kernel.org, stable@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v5.3] gpio: fix getting nonexclusive gpiods from DT
Date: Mon, 14 Oct 2019 19:35:48 -0400 [thread overview]
Message-ID: <20191014233548.GD31224@sasha-vm> (raw)
In-Reply-To: <20191014155341.13145-1-brgl@bgdev.pl>
On Mon, Oct 14, 2019 at 05:53:41PM +0200, Bartosz Golaszewski wrote:
>From: Marco Felsch <m.felsch@pengutronix.de>
>
>Since commit ec757001c818 ("gpio: Enable nonexclusive gpiods from DT
>nodes") we are able to get GPIOD_FLAGS_BIT_NONEXCLUSIVE marked gpios.
>Currently the gpiolib uses the wrong flags variable for the check. We
>need to check the gpiod_flags instead of the of_gpio_flags else we
>return -EBUSY for GPIOD_FLAGS_BIT_NONEXCLUSIVE marked and requested
>gpiod's.
>
>Fixes: ec757001c818 gpio: Enable nonexclusive gpiods from DT nodes
>Cc: stable@vger.kernel.org
>Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>[Bartosz: the function was moved to gpiolib-of.c so updated the patch]
>Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>[Bartosz: backported to v5.3.y]
>Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Queued this one for 5.3, thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-10-14 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 15:53 [PATCH v5.3] gpio: fix getting nonexclusive gpiods from DT Bartosz Golaszewski
2019-10-14 23:35 ` Sasha Levin [this message]
2019-10-16 13:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014233548.GD31224@sasha-vm \
--to=sashal@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.