From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs <linux-xfs@vger.kernel.org>, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfs: change the seconds fields in xfs_bulkstat to signed
Date: Tue, 15 Oct 2019 09:04:22 -0700 [thread overview]
Message-ID: <20191015160422.GD13108@magnolia> (raw)
In-Reply-To: <20191015080230.GD3055@infradead.org>
On Tue, Oct 15, 2019 at 01:02:30AM -0700, Christoph Hellwig wrote:
> On Mon, Oct 14, 2019 at 10:12:11AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > 64-bit time is a signed quantity in the kernel, so the bulkstat
> > structure should reflect that.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Strictly speaking this is a break of the userspace API, but I can't see
> how it causes problems in practice, so:
Yeah, I think I'll add a note to the changelog:
"Note that the structure size stays the same and that we have not yet
published userspace headers for this new ioctl so there are no users to
break."
> Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2019-10-15 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 17:12 [PATCH] xfs: change the seconds fields in xfs_bulkstat to signed Darrick J. Wong
2019-10-14 19:03 ` Carlos Maiolino
2019-10-15 8:02 ` Christoph Hellwig
2019-10-15 16:04 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015160422.GD13108@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.