From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94930ECE588 for ; Tue, 15 Oct 2019 16:28:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 721332086A for ; Tue, 15 Oct 2019 16:28:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 721332086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iKPgi-0003Ji-2H; Tue, 15 Oct 2019 16:28:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iKPgg-0003J8-KM for xen-devel@lists.xenproject.org; Tue, 15 Oct 2019 16:28:42 +0000 X-Inumbo-ID: d9bb7750-ef68-11e9-9396-12813bfff9fa Received: from mx1.redhat.com (unknown [209.132.183.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d9bb7750-ef68-11e9-9396-12813bfff9fa; Tue, 15 Oct 2019 16:28:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9115A20FF; Tue, 15 Oct 2019 16:28:41 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-35.brq.redhat.com [10.40.204.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5778C19C69; Tue, 15 Oct 2019 16:28:22 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Tue, 15 Oct 2019 18:26:39 +0200 Message-Id: <20191015162705.28087-7-philmd@redhat.com> In-Reply-To: <20191015162705.28087-1-philmd@redhat.com> References: <20191015162705.28087-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 15 Oct 2019 16:28:41 +0000 (UTC) Subject: [Xen-devel] [PATCH 06/32] mc146818rtc: always register rtc to rtc list X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Stefano Stabellini , Eduardo Habkost , kvm@vger.kernel.org, Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Markovic , xen-devel@lists.xenproject.org, Anthony Perard , Igor Mammedov , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Richard Henderson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" RnJvbTogSGVydsOpIFBvdXNzaW5lYXUgPGhwb3Vzc2luQHJlYWN0b3Mub3JnPgoKV2UgYXJlIG5v dCByZXF1aXJlZCBhbnltb3JlIHRvIHVzZSBydGNfaW5pdCgpIGZ1bmN0aW9uLgoKQWNrZWQtYnk6 IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+CkFja2VkLWJ5OiBQYW9sbyBCb256 aW5pIDxwYm9uemluaUByZWRoYXQuY29tPgpTaWduZWQtb2ZmLWJ5OiBIZXJ2w6kgUG91c3NpbmVh dSA8aHBvdXNzaW5AcmVhY3Rvcy5vcmc+Ck1lc3NhZ2UtSWQ6IDwyMDE3MTIxNjA5MDIyOC4yODUw NS01LWhwb3Vzc2luQHJlYWN0b3Mub3JnPgpbUE1EOiByZWJhc2VkLCBmaXggT0JKRUNUKCkgdmFs dWVdClNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0 LmNvbT4KLS0tCiBody90aW1lci9tYzE0NjgxOHJ0Yy5jIHwgOCArKy0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ody90 aW1lci9tYzE0NjgxOHJ0Yy5jIGIvaHcvdGltZXIvbWMxNDY4MThydGMuYwppbmRleCAwYzA0Yjc0 YzJlLi44ZjdkM2E5Y2RmIDEwMDY0NAotLS0gYS9ody90aW1lci9tYzE0NjgxOHJ0Yy5jCisrKyBi L2h3L3RpbWVyL21jMTQ2ODE4cnRjLmMKQEAgLTk2MywxNyArOTYzLDE2IEBAIHN0YXRpYyB2b2lk IHJ0Y19yZWFsaXplZm4oRGV2aWNlU3RhdGUgKmRldiwgRXJyb3IgKiplcnJwKQogICAgIG9iamVj dF9wcm9wZXJ0eV9hZGRfdG0oT0JKRUNUKHMpLCAiZGF0ZSIsIHJ0Y19nZXRfZGF0ZSwgTlVMTCk7 CiAKICAgICBxZGV2X2luaXRfZ3Bpb19vdXQoZGV2LCAmcy0+aXJxLCAxKTsKKyAgICBRTElTVF9J TlNFUlRfSEVBRCgmcnRjX2RldmljZXMsIHMsIGxpbmspOwogfQogCiBJU0FEZXZpY2UgKm1jMTQ2 ODE4X3J0Y19pbml0KElTQUJ1cyAqYnVzLCBpbnQgYmFzZV95ZWFyLCBxZW11X2lycSBpbnRlcmNl cHRfaXJxKQogewogICAgIERldmljZVN0YXRlICpkZXY7CiAgICAgSVNBRGV2aWNlICppc2FkZXY7 Ci0gICAgUlRDU3RhdGUgKnM7CiAKICAgICBpc2FkZXYgPSBpc2FfY3JlYXRlKGJ1cywgVFlQRV9N QzE0NjgxOF9SVEMpOwogICAgIGRldiA9IERFVklDRShpc2FkZXYpOwotICAgIHMgPSBNQzE0Njgx OF9SVEMoaXNhZGV2KTsKICAgICBxZGV2X3Byb3Bfc2V0X2ludDMyKGRldiwgImJhc2VfeWVhciIs IGJhc2VfeWVhcik7CiAgICAgcWRldl9pbml0X25vZmFpbChkZXYpOwogICAgIGlmIChpbnRlcmNl cHRfaXJxKSB7CkBAIC05ODEsOSArOTgwLDggQEAgSVNBRGV2aWNlICptYzE0NjgxOF9ydGNfaW5p dChJU0FCdXMgKmJ1cywgaW50IGJhc2VfeWVhciwgcWVtdV9pcnEgaW50ZXJjZXB0X2lycSkKICAg ICB9IGVsc2UgewogICAgICAgICBpc2FfY29ubmVjdF9ncGlvX291dChpc2FkZXYsIDAsIFJUQ19J U0FfSVJRKTsKICAgICB9Ci0gICAgUUxJU1RfSU5TRVJUX0hFQUQoJnJ0Y19kZXZpY2VzLCBzLCBs aW5rKTsKIAotICAgIG9iamVjdF9wcm9wZXJ0eV9hZGRfYWxpYXMocWRldl9nZXRfbWFjaGluZSgp LCAicnRjLXRpbWUiLCBPQkpFQ1QocyksCisgICAgb2JqZWN0X3Byb3BlcnR5X2FkZF9hbGlhcyhx ZGV2X2dldF9tYWNoaW5lKCksICJydGMtdGltZSIsIE9CSkVDVChpc2FkZXYpLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgImRhdGUiLCBOVUxMKTsKIAogICAgIHJldHVybiBpc2FkZXY7 CkBAIC0xMDE1LDggKzEwMTMsNiBAQCBzdGF0aWMgdm9pZCBydGNfY2xhc3NfaW5pdGZuKE9iamVj dENsYXNzICprbGFzcywgdm9pZCAqZGF0YSkKICAgICBkYy0+cmVzZXQgPSBydGNfcmVzZXRkZXY7 CiAgICAgZGMtPnZtc2QgPSAmdm1zdGF0ZV9ydGM7CiAgICAgZGMtPnByb3BzID0gbWMxNDY4MThy dGNfcHJvcGVydGllczsKLSAgICAvKiBSZWFzb246IG5lZWRzIHRvIGJlIHdpcmVkIHVwIGJ5IHJ0 Y19pbml0KCkgKi8KLSAgICBkYy0+dXNlcl9jcmVhdGFibGUgPSBmYWxzZTsKIH0KIAogc3RhdGlj IGNvbnN0IFR5cGVJbmZvIG1jMTQ2ODE4cnRjX2luZm8gPSB7Ci0tIAoyLjIxLjAKCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D96C10F14 for ; Tue, 15 Oct 2019 16:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14BE720872 for ; Tue, 15 Oct 2019 16:28:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729663AbfJOQ2m (ORCPT ); Tue, 15 Oct 2019 12:28:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727766AbfJOQ2m (ORCPT ); Tue, 15 Oct 2019 12:28:42 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9115A20FF; Tue, 15 Oct 2019 16:28:41 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-35.brq.redhat.com [10.40.204.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5778C19C69; Tue, 15 Oct 2019 16:28:22 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Markovic , Aurelien Jarno , Eduardo Habkost , Thomas Huth , Igor Mammedov , Anthony Perard , Stefano Stabellini , Paul Durrant , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Rikalo , xen-devel@lists.xenproject.org, Laurent Vivier , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , kvm@vger.kernel.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 06/32] mc146818rtc: always register rtc to rtc list Date: Tue, 15 Oct 2019 18:26:39 +0200 Message-Id: <20191015162705.28087-7-philmd@redhat.com> In-Reply-To: <20191015162705.28087-1-philmd@redhat.com> References: <20191015162705.28087-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 15 Oct 2019 16:28:41 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Hervé Poussineau We are not required anymore to use rtc_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-5-hpoussin@reactos.org> [PMD: rebased, fix OBJECT() value] Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/mc146818rtc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c index 0c04b74c2e..8f7d3a9cdf 100644 --- a/hw/timer/mc146818rtc.c +++ b/hw/timer/mc146818rtc.c @@ -963,17 +963,16 @@ static void rtc_realizefn(DeviceState *dev, Error **errp) object_property_add_tm(OBJECT(s), "date", rtc_get_date, NULL); qdev_init_gpio_out(dev, &s->irq, 1); + QLIST_INSERT_HEAD(&rtc_devices, s, link); } ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) { DeviceState *dev; ISADevice *isadev; - RTCState *s; isadev = isa_create(bus, TYPE_MC146818_RTC); dev = DEVICE(isadev); - s = MC146818_RTC(isadev); qdev_prop_set_int32(dev, "base_year", base_year); qdev_init_nofail(dev); if (intercept_irq) { @@ -981,9 +980,8 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) } else { isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ); } - QLIST_INSERT_HEAD(&rtc_devices, s, link); - object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(s), + object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isadev), "date", NULL); return isadev; @@ -1015,8 +1013,6 @@ static void rtc_class_initfn(ObjectClass *klass, void *data) dc->reset = rtc_resetdev; dc->vmsd = &vmstate_rtc; dc->props = mc146818rtc_properties; - /* Reason: needs to be wired up by rtc_init() */ - dc->user_creatable = false; } static const TypeInfo mc146818rtc_info = { -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB97C10F14 for ; Tue, 15 Oct 2019 16:36:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93861214AE for ; Tue, 15 Oct 2019 16:36:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93861214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKPo8-0000eB-Hz for qemu-devel@archiver.kernel.org; Tue, 15 Oct 2019 12:36:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41031) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKPgh-0000zR-U2 for qemu-devel@nongnu.org; Tue, 15 Oct 2019 12:28:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKPgg-0004g8-Ti for qemu-devel@nongnu.org; Tue, 15 Oct 2019 12:28:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40298) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKPgg-0004fk-O1 for qemu-devel@nongnu.org; Tue, 15 Oct 2019 12:28:42 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9115A20FF; Tue, 15 Oct 2019 16:28:41 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-35.brq.redhat.com [10.40.204.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5778C19C69; Tue, 15 Oct 2019 16:28:22 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 06/32] mc146818rtc: always register rtc to rtc list Date: Tue, 15 Oct 2019 18:26:39 +0200 Message-Id: <20191015162705.28087-7-philmd@redhat.com> In-Reply-To: <20191015162705.28087-1-philmd@redhat.com> References: <20191015162705.28087-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Tue, 15 Oct 2019 16:28:41 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Stefano Stabellini , Eduardo Habkost , kvm@vger.kernel.org, Paul Durrant , "Michael S. Tsirkin" , Paolo Bonzini , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Markovic , xen-devel@lists.xenproject.org, Anthony Perard , Igor Mammedov , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Herv=C3=A9 Poussineau We are not required anymore to use rtc_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Herv=C3=A9 Poussineau Message-Id: <20171216090228.28505-5-hpoussin@reactos.org> [PMD: rebased, fix OBJECT() value] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/mc146818rtc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c index 0c04b74c2e..8f7d3a9cdf 100644 --- a/hw/timer/mc146818rtc.c +++ b/hw/timer/mc146818rtc.c @@ -963,17 +963,16 @@ static void rtc_realizefn(DeviceState *dev, Error *= *errp) object_property_add_tm(OBJECT(s), "date", rtc_get_date, NULL); =20 qdev_init_gpio_out(dev, &s->irq, 1); + QLIST_INSERT_HEAD(&rtc_devices, s, link); } =20 ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq interc= ept_irq) { DeviceState *dev; ISADevice *isadev; - RTCState *s; =20 isadev =3D isa_create(bus, TYPE_MC146818_RTC); dev =3D DEVICE(isadev); - s =3D MC146818_RTC(isadev); qdev_prop_set_int32(dev, "base_year", base_year); qdev_init_nofail(dev); if (intercept_irq) { @@ -981,9 +980,8 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_ye= ar, qemu_irq intercept_irq) } else { isa_connect_gpio_out(isadev, 0, RTC_ISA_IRQ); } - QLIST_INSERT_HEAD(&rtc_devices, s, link); =20 - object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(s), + object_property_add_alias(qdev_get_machine(), "rtc-time", OBJECT(isa= dev), "date", NULL); =20 return isadev; @@ -1015,8 +1013,6 @@ static void rtc_class_initfn(ObjectClass *klass, vo= id *data) dc->reset =3D rtc_resetdev; dc->vmsd =3D &vmstate_rtc; dc->props =3D mc146818rtc_properties; - /* Reason: needs to be wired up by rtc_init() */ - dc->user_creatable =3D false; } =20 static const TypeInfo mc146818rtc_info =3D { --=20 2.21.0