Re: [Outreachy kernel] [PATCH 2/2] staging: sm750fb: Fix comments and assignments over 80 chars

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Oct 14, 2019 at 08:12:13PM -0700, Jamal Shareef wrote:
> Fixes block comments and variable assignments
> that were over 80 characters in length. Issue
> found by checkpatch.
> 
> Fix typo "mean" to "means". Add comment for
> ROP value in sm750_accel.h as it is in
> sm750_accel.c file.
> 
> Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
> ---
>  drivers/staging/sm750fb/sm750.c       | 22 +++++----
>  drivers/staging/sm750fb/sm750_accel.c | 69 ++++++++++++++++++++-------
>  drivers/staging/sm750fb/sm750_accel.h | 51 ++++++++++++++++----
>  3 files changed, 108 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 59568d18ce23..7eb3f7b0a86b 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -133,13 +133,15 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)
>  		/* get the 16bit color of kernel means */
>  		u16 fg, bg;
>  
> -		fg = ((info->cmap.red[fbcursor->image.fg_color] & 0xf800)) |
> -		     ((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> 5) |
> -		     ((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> 11);
> +		fg =
> +		((info->cmap.red[fbcursor->image.fg_color] & 0xf800)) |
> +		((info->cmap.green[fbcursor->image.fg_color] & 0xfc00) >> 5) |
> +		((info->cmap.blue[fbcursor->image.fg_color] & 0xf800) >> 11);

No, never indent this far to the left for these lines.  You just made
this code harder to understand, the original is fine.

thanks,

greg k-h