From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "Input: elantech - enable SMBus on new (2018+) systems"
Date: Tue, 15 Oct 2019 17:51:07 -0700 [thread overview]
Message-ID: <20191016005107.GA35946@dtor-ws> (raw)
In-Reply-To: <CAO-hwJJ_hjL8=D+BDTW6LQRhd86NawORuY-jnDF71mD88woiDw@mail.gmail.com>
On Fri, Oct 11, 2019 at 05:26:05PM +0200, Benjamin Tissoires wrote:
> Hi Kai-Heng,
>
> On Tue, Oct 1, 2019 at 9:09 AM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
> >
> > This reverts commit 883a2a80f79ca5c0c105605fafabd1f3df99b34c.
> >
> > Apparently use dmi_get_bios_year() as manufacturing date isn't accurate
> > and this breaks older laptops with new BIOS update.
> >
> > So let's revert this patch.
> >
> > There are still new HP laptops still need to use SMBus to support all
> > features, but it'll be enabled via a whitelist.
> >
>
> You might want to add here:
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=204771
>
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> Oops, seems like you are missing my acked by:
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Also, don't we want to send this one to stable as well? I can't
> remember if we reverted it in all the released kernels.
It looks like we need it for 5.3 so I marked it for stable.
Thanks.
--
Dmitry
prev parent reply other threads:[~2019-10-16 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 7:08 [PATCH] Revert "Input: elantech - enable SMBus on new (2018+) systems" Kai-Heng Feng
2019-10-01 11:20 ` Kai-Heng Feng
2019-10-11 15:26 ` Benjamin Tissoires
2019-10-16 0:51 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016005107.GA35946@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.