From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: lorenzo.pieralisi@arm.com, bhelgaas@google.com,
robh+dt@kernel.org, jonathanh@nvidia.com, andrew.murray@arm.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH 2/2] arm64: tegra: Assume no CLKREQ presence by default
Date: Wed, 16 Oct 2019 18:19:52 +0200 [thread overview]
Message-ID: <20191016161952.GB2526111@ulmo> (raw)
In-Reply-To: <20191005164212.3646-2-vidyas@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2227 bytes --]
On Sat, Oct 05, 2019 at 10:12:12PM +0530, Vidya Sagar wrote:
> Although Tegra194 has support for CLKREQ sideband signal and P2972
> has routing of the same till the slot, it is the case most of the time
> that the connected device doesn't have CLKREQ support. Hence, it makes
> sense to assume that there is no CLKREQ support by default and it can
> be enabled on need basis when a card with CLKREQ support is connected.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 6 ------
> 1 file changed, 6 deletions(-)
Applied to for-5.5/arm64/dt, thanks.
Thierry
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> index a312c051448b..11220d97adb8 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> @@ -1186,7 +1186,6 @@
>
> nvidia,bpmp = <&bpmp 1>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1232,7 +1231,6 @@
>
> nvidia,bpmp = <&bpmp 2>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1278,7 +1276,6 @@
>
> nvidia,bpmp = <&bpmp 3>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1324,7 +1321,6 @@
>
> nvidia,bpmp = <&bpmp 4>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1370,7 +1366,6 @@
>
> nvidia,bpmp = <&bpmp 0>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1420,7 +1415,6 @@
> interrupt-map-mask = <0 0 0 0>;
> interrupt-map = <0 0 0 0 &gic GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Vidya Sagar <vidyas@nvidia.com>
Cc: devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
mmaddireddy@nvidia.com, kthota@nvidia.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
robh+dt@kernel.org, bhelgaas@google.com, andrew.murray@arm.com,
linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com
Subject: Re: [PATCH 2/2] arm64: tegra: Assume no CLKREQ presence by default
Date: Wed, 16 Oct 2019 18:19:52 +0200 [thread overview]
Message-ID: <20191016161952.GB2526111@ulmo> (raw)
In-Reply-To: <20191005164212.3646-2-vidyas@nvidia.com>
[-- Attachment #1.1: Type: text/plain, Size: 2227 bytes --]
On Sat, Oct 05, 2019 at 10:12:12PM +0530, Vidya Sagar wrote:
> Although Tegra194 has support for CLKREQ sideband signal and P2972
> has routing of the same till the slot, it is the case most of the time
> that the connected device doesn't have CLKREQ support. Hence, it makes
> sense to assume that there is no CLKREQ support by default and it can
> be enabled on need basis when a card with CLKREQ support is connected.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 6 ------
> 1 file changed, 6 deletions(-)
Applied to for-5.5/arm64/dt, thanks.
Thierry
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194.dtsi b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> index a312c051448b..11220d97adb8 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194.dtsi
> @@ -1186,7 +1186,6 @@
>
> nvidia,bpmp = <&bpmp 1>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1232,7 +1231,6 @@
>
> nvidia,bpmp = <&bpmp 2>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1278,7 +1276,6 @@
>
> nvidia,bpmp = <&bpmp 3>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1324,7 +1321,6 @@
>
> nvidia,bpmp = <&bpmp 4>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1370,7 +1366,6 @@
>
> nvidia,bpmp = <&bpmp 0>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> @@ -1420,7 +1415,6 @@
> interrupt-map-mask = <0 0 0 0>;
> interrupt-map = <0 0 0 0 &gic GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
>
> - supports-clkreq;
> nvidia,aspm-cmrt-us = <60>;
> nvidia,aspm-pwr-on-t-us = <20>;
> nvidia,aspm-l0s-entrance-latency-us = <3>;
> --
> 2.17.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-16 16:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 16:42 [PATCH 1/2] PCI: tegra: Fix CLKREQ dependency programming Vidya Sagar
2019-10-05 16:42 ` Vidya Sagar
2019-10-05 16:42 ` Vidya Sagar
2019-10-05 16:42 ` [PATCH 2/2] arm64: tegra: Assume no CLKREQ presence by default Vidya Sagar
2019-10-05 16:42 ` Vidya Sagar
2019-10-05 16:42 ` Vidya Sagar
2019-10-16 16:19 ` Thierry Reding [this message]
2019-10-16 16:19 ` Thierry Reding
2019-10-16 16:19 ` [PATCH 1/2] PCI: tegra: Fix CLKREQ dependency programming Thierry Reding
2019-10-16 16:19 ` Thierry Reding
2019-10-18 9:01 ` Lorenzo Pieralisi
2019-10-18 9:01 ` Lorenzo Pieralisi
2019-10-18 9:01 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016161952.GB2526111@ulmo \
--to=thierry.reding@gmail.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.