From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux admin Subject: Re: [PATCHv8 2/2] drm: tda998x: set the connector info Date: Wed, 16 Oct 2019 17:22:32 +0100 Message-ID: <20191016162232.GY25745@shell.armlinux.org.uk> References: <20191016133916.21475-1-hverkuil-cisco@xs4all.nl> <20191016133916.21475-3-hverkuil-cisco@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69F986E9A5 for ; Wed, 16 Oct 2019 16:22:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20191016133916.21475-3-hverkuil-cisco@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: Dariusz Marcinkiewicz , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMTYsIDIwMTkgYXQgMDM6Mzk6MTZQTSArMDIwMCwgSGFucyBWZXJrdWlsIHdy b3RlOgo+IEZyb206IERhcml1c3ogTWFyY2lua2lld2ljeiA8ZGFyZWttQGdvb2dsZS5jb20+Cj4g Cj4gRmlsbCBpbiB0aGUgY2VjX2Nvbm5lY3Rvcl9pbmZvIHdoZW4gY2FsbGluZyBjZWNfbm90aWZp ZXJfY29ubl9yZWdpc3RlcigpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhcml1c3ogTWFyY2lua2ll d2ljeiA8ZGFyZWttQGdvb2dsZS5jb20+Cj4gVGVzdGVkLWJ5OiBIYW5zIFZlcmt1aWwgPGh2ZXJr dWlsLWNpc2NvQHhzNGFsbC5ubD4KPiBTaWduZWQtb2ZmLWJ5OiBIYW5zIFZlcmt1aWwgPGh2ZXJr dWlsLWNpc2NvQHhzNGFsbC5ubD4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4 X2Rydi5jIHwgMzEgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMv dGRhOTk4eF9kcnYuYwo+IGluZGV4IDgyNjJiNDRiNzc2ZS4uYjA2MjA4NDJmYTNhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYwo+IEBAIC0xMzM3LDYgKzEzMzcsOCBAQCBzdGF0aWMg aW50IHRkYTk5OHhfY29ubmVjdG9yX2luaXQoc3RydWN0IHRkYTk5OHhfcHJpdiAqcHJpdiwKPiAg CQkJCSAgc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiAgewo+ICAJc3RydWN0IGRybV9jb25uZWN0 b3IgKmNvbm5lY3RvciA9ICZwcml2LT5jb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgY2VjX2Nvbm5lY3Rv cl9pbmZvIGNvbm5faW5mbzsKPiArCXN0cnVjdCBjZWNfbm90aWZpZXIgKm5vdGlmaWVyOwo+ICAJ aW50IHJldDsKPiAgCj4gIAljb25uZWN0b3ItPmludGVybGFjZV9hbGxvd2VkID0gMTsKPiBAQCAt MTM1Myw2ICsxMzU1LDE3IEBAIHN0YXRpYyBpbnQgdGRhOTk4eF9jb25uZWN0b3JfaW5pdChzdHJ1 Y3QgdGRhOTk4eF9wcml2ICpwcml2LAo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAK PiArCWNlY19maWxsX2Nvbm5faW5mb19mcm9tX2RybSgmY29ubl9pbmZvLCBjb25uZWN0b3IpOwo+ ICsKPiArCW5vdGlmaWVyID0gY2VjX25vdGlmaWVyX2Nvbm5fcmVnaXN0ZXIocHJpdi0+Y2VjX2ds dWUucGFyZW50LAo+ICsJCQkJCSAgICAgIE5VTEwsICZjb25uX2luZm8pOwo+ICsJaWYgKCFub3Rp ZmllcikKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwltdXRleF9sb2NrKCZwcml2LT5jZWNf bm90aWZ5X211dGV4KTsKPiArCXByaXYtPmNlY19ub3RpZnkgPSBub3RpZmllcjsKPiArCW11dGV4 X3VubG9jaygmcHJpdi0+Y2VjX25vdGlmeV9tdXRleCk7CgpBcyBwZXIgbXkgcHJldmlvdXMgY29t bWVudHMsIHRoaXMgaXMgYSBzaW5nbGUtY29weSBhdG9taWMgb3BlcmF0aW9uLgpFaXRoZXIgcHJp di0+Y2VjX25vdGlmeSBpcyBzZXQgb3IgaXQgaXNuJ3Q7IHRoZXJlIGlzIG5vIGludGVybWVkaWF0 ZQp2YWx1ZS4gIEl0IGNhbid0IGJlIHNldCB0byBhIHZhbHVlIHVudGlsIGNlY19ub3RpZmllcl9j b25uX3JlZ2lzdGVyKCkKaGFzIGNvbXBsZXRlZC4gIFNvIHRoZSBsb2NrIGRvZXNuJ3QgaGVscC4K Cj4gKwo+ICAJZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfZW5jb2RlcigmcHJpdi0+Y29ubmVjdG9yLAo+ ICAJCQkJICAgICBwcml2LT5icmlkZ2UuZW5jb2Rlcik7Cj4gIAo+IEBAIC0xMzcyLDYgKzEzODUs MTEgQEAgc3RhdGljIHZvaWQgdGRhOTk4eF9icmlkZ2VfZGV0YWNoKHN0cnVjdCBkcm1fYnJpZGdl ICpicmlkZ2UpCj4gIHsKPiAgCXN0cnVjdCB0ZGE5OTh4X3ByaXYgKnByaXYgPSBicmlkZ2VfdG9f dGRhOTk4eF9wcml2KGJyaWRnZSk7Cj4gIAo+ICsJbXV0ZXhfbG9jaygmcHJpdi0+Y2VjX25vdGlm eV9tdXRleCk7Cj4gKwljZWNfbm90aWZpZXJfY29ubl91bnJlZ2lzdGVyKHByaXYtPmNlY19ub3Rp ZnkpOwo+ICsJcHJpdi0+Y2VjX25vdGlmeSA9IE5VTEw7Cj4gKwltdXRleF91bmxvY2soJnByaXYt PmNlY19ub3RpZnlfbXV0ZXgpOwoKVGhpcyBpcyB0aGUgb25seSBjYXNlIHdoZXJlIHRoZSBsb2Nr IG1ha2VzIHNlbnNlIC0gdG8gZW5zdXJlIHRoYXQgYW55Cm9mIHRoZSBjZWNfbm90aWZpZXJfc2V0 X3BoeXNfYWRkciooKSBmdW5jdGlvbnMgYXJlbid0IGNhbGxlZApjb25jdXJyZW50bHkgd2l0aCBp dC4gIEhvd2V2ZXIsIHRoZXJlJ3Mgbm8gbG9ja2luZyBhcm91bmQgdGhlIGluc3RhbmNlCmluIHRk YTk5OHhfY29ubmVjdG9yX2dldF9tb2RlcygpLCBzbyBoYXZlIHlvdSBlbnN1cmVkIHRoYXQgdGhh dApmdW5jdGlvbiBjYW4ndCBiZSBjYWxsZWQgY29uY3VycmVudGx5PwoKVGhhbmtzLgoKLS0gClJN SydzIFBhdGNoIHN5c3RlbTogaHR0cHM6Ly93d3cuYXJtbGludXgub3JnLnVrL2RldmVsb3Blci9w YXRjaGVzLwpGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBsaW5lIGluIHN1YnVyYmlhOiBzeW5j IGF0IDEyLjFNYnBzIGRvd24gNjIya2JwcyB1cApBY2NvcmRpbmcgdG8gc3BlZWR0ZXN0Lm5ldDog MTEuOU1icHMgZG93biA1MDBrYnBzIHVwCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5840FA372A for ; Wed, 16 Oct 2019 16:22:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B493620663 for ; Wed, 16 Oct 2019 16:22:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="YgsBjABZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406143AbfJPQWi (ORCPT ); Wed, 16 Oct 2019 12:22:38 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:59866 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727451AbfJPQWi (ORCPT ); Wed, 16 Oct 2019 12:22:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mrJvn3liV+DZQU5EJ5RJHD7FS7q5mla25X7BFGETVL8=; b=YgsBjABZYZX1KmRFqvLFkXUsN RBzZl0s67H5XDBRxy3ej4NMVKuWvb60ijdPj/iyk8siXmgfIHvNKvB4C7N1QxBr7zsDbcJO+5oitu 2zkj3pJ/cTjaGyFiwWD7fJDhuZN9KqikpxPZdB2NpM6vIiDDPP+NguiQW8qwUJC2eA9mcIIWQDu9R rSOsUqdsVfsRUPMP4oGZ0DXIoWDlynqbELDZchU9fU6615HxG6w15Av2sLUMSiaxO/ynf8JwkiCNd gEv+sZegWk55vEM24YIFx8bUsGFSgNw8HIP3Oxn78Ab8h6ucA6o/gUte2253/o+tga3h95hd7P5gy ocFQA9VBg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55454) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iKm4H-0003Un-TL; Wed, 16 Oct 2019 17:22:34 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iKm4G-0007Hf-VR; Wed, 16 Oct 2019 17:22:33 +0100 Date: Wed, 16 Oct 2019 17:22:32 +0100 From: Russell King - ARM Linux admin To: Hans Verkuil Cc: linux-media@vger.kernel.org, Dariusz Marcinkiewicz , dri-devel@lists.freedesktop.org, Daniel Vetter , Laurent Pinchart Subject: Re: [PATCHv8 2/2] drm: tda998x: set the connector info Message-ID: <20191016162232.GY25745@shell.armlinux.org.uk> References: <20191016133916.21475-1-hverkuil-cisco@xs4all.nl> <20191016133916.21475-3-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016133916.21475-3-hverkuil-cisco@xs4all.nl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Oct 16, 2019 at 03:39:16PM +0200, Hans Verkuil wrote: > From: Dariusz Marcinkiewicz > > Fill in the cec_connector_info when calling cec_notifier_conn_register(). > > Signed-off-by: Dariusz Marcinkiewicz > Tested-by: Hans Verkuil > Signed-off-by: Hans Verkuil > --- > drivers/gpu/drm/i2c/tda998x_drv.c | 31 ++++++++++++++++++------------- > 1 file changed, 18 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > index 8262b44b776e..b0620842fa3a 100644 > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > @@ -1337,6 +1337,8 @@ static int tda998x_connector_init(struct tda998x_priv *priv, > struct drm_device *drm) > { > struct drm_connector *connector = &priv->connector; > + struct cec_connector_info conn_info; > + struct cec_notifier *notifier; > int ret; > > connector->interlace_allowed = 1; > @@ -1353,6 +1355,17 @@ static int tda998x_connector_init(struct tda998x_priv *priv, > if (ret) > return ret; > > + cec_fill_conn_info_from_drm(&conn_info, connector); > + > + notifier = cec_notifier_conn_register(priv->cec_glue.parent, > + NULL, &conn_info); > + if (!notifier) > + return -ENOMEM; > + > + mutex_lock(&priv->cec_notify_mutex); > + priv->cec_notify = notifier; > + mutex_unlock(&priv->cec_notify_mutex); As per my previous comments, this is a single-copy atomic operation. Either priv->cec_notify is set or it isn't; there is no intermediate value. It can't be set to a value until cec_notifier_conn_register() has completed. So the lock doesn't help. > + > drm_connector_attach_encoder(&priv->connector, > priv->bridge.encoder); > > @@ -1372,6 +1385,11 @@ static void tda998x_bridge_detach(struct drm_bridge *bridge) > { > struct tda998x_priv *priv = bridge_to_tda998x_priv(bridge); > > + mutex_lock(&priv->cec_notify_mutex); > + cec_notifier_conn_unregister(priv->cec_notify); > + priv->cec_notify = NULL; > + mutex_unlock(&priv->cec_notify_mutex); This is the only case where the lock makes sense - to ensure that any of the cec_notifier_set_phys_addr*() functions aren't called concurrently with it. However, there's no locking around the instance in tda998x_connector_get_modes(), so have you ensured that that function can't be called concurrently? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up