From mboxrd@z Thu Jan 1 00:00:00 1970 From: mchehab+samsung at kernel.org (Mauro Carvalho Chehab) Date: Wed, 16 Oct 2019 16:45:03 -0300 Subject: [Linux-kernel-mentees] [PATCH] Documentation:media:v4l2:Add vivid metadata doc In-Reply-To: <3db91bd0-cfdd-6453-6e70-8567ac94d68e@xs4all.nl> References: <20191004115514.31259-1-bnvandana@gmail.com> <3db91bd0-cfdd-6453-6e70-8567ac94d68e@xs4all.nl> Message-ID: <20191016164503.01b9f037@coco.lan> List-Id: Em Fri, 4 Oct 2019 13:59:00 +0200 Hans Verkuil escreveu: > On 10/4/19 1:55 PM, Vandana BN wrote: > > Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. > > > > Signed-off-by: Vandana BN > > --- > > Documentation/media/uapi/v4l/meta-formats.rst | 1 + > > .../media/uapi/v4l/pixfmt-meta-vivid.rst | 43 +++++++++++++++++++ > > 2 files changed, 44 insertions(+) > > create mode 100644 Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > > > diff --git a/Documentation/media/uapi/v4l/meta-formats.rst b/Documentation/media/uapi/v4l/meta-formats.rst > > index b10ca9ee3968..74c8659ee9d6 100644 > > --- a/Documentation/media/uapi/v4l/meta-formats.rst > > +++ b/Documentation/media/uapi/v4l/meta-formats.rst > > @@ -24,3 +24,4 @@ These formats are used for the :ref:`metadata` interface only. > > pixfmt-meta-uvc > > pixfmt-meta-vsp1-hgo > > pixfmt-meta-vsp1-hgt > > + pixfmt-meta-vivid > > diff --git a/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst b/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > new file mode 100644 > > index 000000000000..e6c349fadf30 > > --- /dev/null > > +++ b/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > @@ -0,0 +1,43 @@ > > +.. Permission is granted to copy, distribute and/or modify this > > +.. document under the terms of the GNU Free Documentation License, > > +.. Version 1.1 or any later version published by the Free Software > > +.. Foundation, with no Invariant Sections, no Front-Cover Texts > > +.. and no Back-Cover Texts. A copy of the license is included at > > +.. Documentation/media/uapi/fdl-appendix.rst. > > +.. > > +.. TODO: replace it to GFDL-1.1-or-later WITH no-invariant-sections Could you please re-license it with dual GFDL and GPL? See for example: Documentation/media/uapi/mediactl/media-request-ioc-queue.rst For the text we're adding to all new documentation files on media. Regards, Mauro > > + > > +.. _v4l2-meta-fmt-vivid: > > + > > +******************************* > > +V4L2_META_FMT_VIVID ('VIVID') > > That's a fivecc instead of a fourcc :-) > > > +******************************* > > + > > +VIVID Metadata Format > > + > > + > > +Description > > +=========== > > + > > +This format describes metadata in vivid driver. > > Say: ...describes the metadata format used by the vivid driver. > > > + > > +It sets Brightness, Saturation, Contrast and Hue, each of which maps to > > +corresponding control in vivid driver with respect to its range and default values. > > ...controls of the... > ...respect to the range... > > > + > > +It contains the following fields: > > + > > +.. flat-table:: VIVID Metadata > > + :widths: 1 4 > > + :header-rows: 1 > > + :stub-columns: 0 > > + > > + * - Field > > + - Description > > + * - u16 brightness; > > + - Image brightness, value can be in range 0 to 255, with default value as 128. > > - Image brightness, the value is in the range 0 to 255, with the default value as 128. > > > + * - u16 contrast; > > + - Image contrast, value can be in range 0 to 255, with default value as 128. > > + * - u16 saturation; > > + - Image color saturation, value can be in range 0 to 255, with default value as 128. > > + * - s16 hue; > > + - Image color balance, value can be in range -128 to 128, with default value as 0. > > > > Ditto. > > Regards, > > Hans Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 From: mchehab+samsung@kernel.org (Mauro Carvalho Chehab) Date: Wed, 16 Oct 2019 16:45:03 -0300 Subject: [Linux-kernel-mentees] [PATCH] Documentation:media:v4l2:Add vivid metadata doc In-Reply-To: <3db91bd0-cfdd-6453-6e70-8567ac94d68e@xs4all.nl> References: <20191004115514.31259-1-bnvandana@gmail.com> <3db91bd0-cfdd-6453-6e70-8567ac94d68e@xs4all.nl> Message-ID: <20191016164503.01b9f037@coco.lan> List-Id: Content-Type: text/plain; charset="UTF-8" Message-ID: <20191016194503.8oquPCPCWeFnZISpCwqUdy6I0eQ-uZBPDEtMTHJdRck@z> Em Fri, 4 Oct 2019 13:59:00 +0200 Hans Verkuil escreveu: > On 10/4/19 1:55 PM, Vandana BN wrote: > > Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. > > > > Signed-off-by: Vandana BN > > --- > > Documentation/media/uapi/v4l/meta-formats.rst | 1 + > > .../media/uapi/v4l/pixfmt-meta-vivid.rst | 43 +++++++++++++++++++ > > 2 files changed, 44 insertions(+) > > create mode 100644 Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > > > diff --git a/Documentation/media/uapi/v4l/meta-formats.rst b/Documentation/media/uapi/v4l/meta-formats.rst > > index b10ca9ee3968..74c8659ee9d6 100644 > > --- a/Documentation/media/uapi/v4l/meta-formats.rst > > +++ b/Documentation/media/uapi/v4l/meta-formats.rst > > @@ -24,3 +24,4 @@ These formats are used for the :ref:`metadata` interface only. > > pixfmt-meta-uvc > > pixfmt-meta-vsp1-hgo > > pixfmt-meta-vsp1-hgt > > + pixfmt-meta-vivid > > diff --git a/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst b/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > new file mode 100644 > > index 000000000000..e6c349fadf30 > > --- /dev/null > > +++ b/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > @@ -0,0 +1,43 @@ > > +.. Permission is granted to copy, distribute and/or modify this > > +.. document under the terms of the GNU Free Documentation License, > > +.. Version 1.1 or any later version published by the Free Software > > +.. Foundation, with no Invariant Sections, no Front-Cover Texts > > +.. and no Back-Cover Texts. A copy of the license is included at > > +.. Documentation/media/uapi/fdl-appendix.rst. > > +.. > > +.. TODO: replace it to GFDL-1.1-or-later WITH no-invariant-sections Could you please re-license it with dual GFDL and GPL? See for example: Documentation/media/uapi/mediactl/media-request-ioc-queue.rst For the text we're adding to all new documentation files on media. Regards, Mauro > > + > > +.. _v4l2-meta-fmt-vivid: > > + > > +******************************* > > +V4L2_META_FMT_VIVID ('VIVID') > > That's a fivecc instead of a fourcc :-) > > > +******************************* > > + > > +VIVID Metadata Format > > + > > + > > +Description > > +=========== > > + > > +This format describes metadata in vivid driver. > > Say: ...describes the metadata format used by the vivid driver. > > > + > > +It sets Brightness, Saturation, Contrast and Hue, each of which maps to > > +corresponding control in vivid driver with respect to its range and default values. > > ...controls of the... > ...respect to the range... > > > + > > +It contains the following fields: > > + > > +.. flat-table:: VIVID Metadata > > + :widths: 1 4 > > + :header-rows: 1 > > + :stub-columns: 0 > > + > > + * - Field > > + - Description > > + * - u16 brightness; > > + - Image brightness, value can be in range 0 to 255, with default value as 128. > > - Image brightness, the value is in the range 0 to 255, with the default value as 128. > > > + * - u16 contrast; > > + - Image contrast, value can be in range 0 to 255, with default value as 128. > > + * - u16 saturation; > > + - Image color saturation, value can be in range 0 to 255, with default value as 128. > > + * - s16 hue; > > + - Image color balance, value can be in range -128 to 128, with default value as 0. > > > > Ditto. > > Regards, > > Hans Thanks, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA08CECE599 for ; Wed, 16 Oct 2019 19:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C13D21835 for ; Wed, 16 Oct 2019 19:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571255121; bh=S4VuUeSSmSx8oerGFKy1xcpFT3Zv+zU5B9JzI//5gj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=JzwjfqjN8kA0kn10XgXqeIFPGKQ5s/e9jk05znJzvX+2fXwzlp/OM2YFhyLV2rG8D Xfk0x6pY40Dmi+rWTyMzAhMkCZCN00n5R+QPUFGDHpKn4eNH2Gp+p2njT5oCbDDwpt k9WHw06YEEz2EdL5yOIyHGdRzUCE9XRtlrlQwlb8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391106AbfJPTpV (ORCPT ); Wed, 16 Oct 2019 15:45:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44458 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727148AbfJPTpU (ORCPT ); Wed, 16 Oct 2019 15:45:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zJzBf5k7y5y4wU6OSvT7WuZ9AQM2ptYw/lSfUsZU09U=; b=QNegE6MdeDARFRnRWiYSLMtZr w5L+vrKm/Hd0++Y0h2W8qhMnxRtzyaHuCKaQHAUjyGXCz7B2oL6qgMPf2wICr/T9uRjZBm5AUHiMY nNxRu2gqyxeqSVhDsm1TTRRzf1wD8W9WrDvkgNBEKr0EuiZJ9GaeYYOEbr/j6Ka7HMlfktWTowrTE pMTYh4TQENHQIaCNd3wM1FtVXy4nmmzn9+92bwd/DDv6sE2t115nZwi9eFyikyZt+gGOSIiQyfdbD 8+lAvdb6bAbm+qOn1oiiAqt2NaMS1uI17OaszA7FBSm2dAupEUrh3i4FEnCTkcPV9HQ6GpB6ZQEUw tX12v/MMw==; Received: from [179.95.49.118] (helo=coco.lan) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKpES-0005gS-Sx; Wed, 16 Oct 2019 19:45:17 +0000 Date: Wed, 16 Oct 2019 16:45:03 -0300 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: Vandana BN , linux-media@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH] Documentation:media:v4l2:Add vivid metadata doc Message-ID: <20191016164503.01b9f037@coco.lan> In-Reply-To: <3db91bd0-cfdd-6453-6e70-8567ac94d68e@xs4all.nl> References: <20191004115514.31259-1-bnvandana@gmail.com> <3db91bd0-cfdd-6453-6e70-8567ac94d68e@xs4all.nl> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Fri, 4 Oct 2019 13:59:00 +0200 Hans Verkuil escreveu: > On 10/4/19 1:55 PM, Vandana BN wrote: > > Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. > > > > Signed-off-by: Vandana BN > > --- > > Documentation/media/uapi/v4l/meta-formats.rst | 1 + > > .../media/uapi/v4l/pixfmt-meta-vivid.rst | 43 +++++++++++++++++++ > > 2 files changed, 44 insertions(+) > > create mode 100644 Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > > > diff --git a/Documentation/media/uapi/v4l/meta-formats.rst b/Documentation/media/uapi/v4l/meta-formats.rst > > index b10ca9ee3968..74c8659ee9d6 100644 > > --- a/Documentation/media/uapi/v4l/meta-formats.rst > > +++ b/Documentation/media/uapi/v4l/meta-formats.rst > > @@ -24,3 +24,4 @@ These formats are used for the :ref:`metadata` interface only. > > pixfmt-meta-uvc > > pixfmt-meta-vsp1-hgo > > pixfmt-meta-vsp1-hgt > > + pixfmt-meta-vivid > > diff --git a/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst b/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > new file mode 100644 > > index 000000000000..e6c349fadf30 > > --- /dev/null > > +++ b/Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst > > @@ -0,0 +1,43 @@ > > +.. Permission is granted to copy, distribute and/or modify this > > +.. document under the terms of the GNU Free Documentation License, > > +.. Version 1.1 or any later version published by the Free Software > > +.. Foundation, with no Invariant Sections, no Front-Cover Texts > > +.. and no Back-Cover Texts. A copy of the license is included at > > +.. Documentation/media/uapi/fdl-appendix.rst. > > +.. > > +.. TODO: replace it to GFDL-1.1-or-later WITH no-invariant-sections Could you please re-license it with dual GFDL and GPL? See for example: Documentation/media/uapi/mediactl/media-request-ioc-queue.rst For the text we're adding to all new documentation files on media. Regards, Mauro > > + > > +.. _v4l2-meta-fmt-vivid: > > + > > +******************************* > > +V4L2_META_FMT_VIVID ('VIVID') > > That's a fivecc instead of a fourcc :-) > > > +******************************* > > + > > +VIVID Metadata Format > > + > > + > > +Description > > +=========== > > + > > +This format describes metadata in vivid driver. > > Say: ...describes the metadata format used by the vivid driver. > > > + > > +It sets Brightness, Saturation, Contrast and Hue, each of which maps to > > +corresponding control in vivid driver with respect to its range and default values. > > ...controls of the... > ...respect to the range... > > > + > > +It contains the following fields: > > + > > +.. flat-table:: VIVID Metadata > > + :widths: 1 4 > > + :header-rows: 1 > > + :stub-columns: 0 > > + > > + * - Field > > + - Description > > + * - u16 brightness; > > + - Image brightness, value can be in range 0 to 255, with default value as 128. > > - Image brightness, the value is in the range 0 to 255, with the default value as 128. > > > + * - u16 contrast; > > + - Image contrast, value can be in range 0 to 255, with default value as 128. > > + * - u16 saturation; > > + - Image color saturation, value can be in range 0 to 255, with default value as 128. > > + * - s16 hue; > > + - Image color balance, value can be in range -128 to 128, with default value as 0. > > > > Ditto. > > Regards, > > Hans Thanks, Mauro