From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E4AFA3728 for ; Wed, 16 Oct 2019 19:14:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC81B20854 for ; Wed, 16 Oct 2019 19:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gcNBpbR+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC81B20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p81W+sfZkwDfxmWtmd1MklfmHm36BQk6uChdh8vOzDE=; b=gcNBpbR+LHJTNd XhzrhwOsM/LkjRHFDcgYOd1RDGRCaFeP9eubbfIJwa15RmwjmAFEkCXcMwifyOibisSqVcsqqVtDd aRzTX1IwralsHnZXFTRiTEhsO+IDKJQ4NCBXLihOPHcEePYEX9xApEBcHknDssb3/0yrrF3D43JrH 0An3M+y5P5MYR16HXJdErFIKsM25ZqApoB/ufw9EOUrTVMp/kdyYJ+s/grGylRAQsEk4VQ4Dl7aGn C3yTk5wxukHn1A+fr+EoLLIn+MPauGN4+FULR3TNUfd27P9T9ZEx/XSZrHHmkc56mH6XWVk03p1L6 R4rQvep7/XajaJuRJ1Xg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKokk-0000GU-61; Wed, 16 Oct 2019 19:14:34 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKokg-0000FF-Tw for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 19:14:32 +0000 X-Originating-IP: 86.202.229.42 Received: from localhost (lfbn-lyo-1-146-42.w86-202.abo.wanadoo.fr [86.202.229.42]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4C4AB40007; Wed, 16 Oct 2019 19:14:16 +0000 (UTC) Date: Wed, 16 Oct 2019 21:14:16 +0200 From: Alexandre Belloni To: David Miller Subject: Re: [PATCH 2/2] net: lpc_eth: parse phy nodes from device tree Message-ID: <20191016191416.GA3125@piout.net> References: <20191010204530.15150-1-alexandre.belloni@bootlin.com> <20191010204530.15150-2-alexandre.belloni@bootlin.com> <20191016.142359.416946718751400991.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191016.142359.416946718751400991.davem@davemloft.net> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_121431_101676_4A5FEB79 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, slemieux.tyco@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vz@mleia.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 16/10/2019 14:23:59-0400, David Miller wrote: > From: Alexandre Belloni > Date: Thu, 10 Oct 2019 22:45:30 +0200 > > > When connected to a micrel phy, phy_find_first doesn't work properly > > because the first phy found is on address 0, the broadcast address but, the > > first thing the phy driver is doing is disabling this broadcast address. > > The phy is then available only on address 1 but the mdio driver doesn't > > know about it. > > > > Instead, register the mdio bus using of_mdiobus_register and try to find > > the phy description in device tree before falling back to phy_find_first. > > > > This ultimately also allows to describe the interrupt the phy is connected > > to. > > > > Signed-off-by: Alexandre Belloni > > I asked you to address Andrew's feedback. > > You can't let this sit for days like that. > > Therefore, I'm dropping your patches. I'm planning to send a v2 to address that but I didn't have time to test today. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9A8FA372A for ; Wed, 16 Oct 2019 19:14:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D07B20854 for ; Wed, 16 Oct 2019 19:14:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394390AbfJPTOT (ORCPT ); Wed, 16 Oct 2019 15:14:19 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49027 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731321AbfJPTOT (ORCPT ); Wed, 16 Oct 2019 15:14:19 -0400 X-Originating-IP: 86.202.229.42 Received: from localhost (lfbn-lyo-1-146-42.w86-202.abo.wanadoo.fr [86.202.229.42]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4C4AB40007; Wed, 16 Oct 2019 19:14:16 +0000 (UTC) Date: Wed, 16 Oct 2019 21:14:16 +0200 From: Alexandre Belloni To: David Miller Cc: vz@mleia.com, slemieux.tyco@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] net: lpc_eth: parse phy nodes from device tree Message-ID: <20191016191416.GA3125@piout.net> References: <20191010204530.15150-1-alexandre.belloni@bootlin.com> <20191010204530.15150-2-alexandre.belloni@bootlin.com> <20191016.142359.416946718751400991.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191016.142359.416946718751400991.davem@davemloft.net> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 16/10/2019 14:23:59-0400, David Miller wrote: > From: Alexandre Belloni > Date: Thu, 10 Oct 2019 22:45:30 +0200 > > > When connected to a micrel phy, phy_find_first doesn't work properly > > because the first phy found is on address 0, the broadcast address but, the > > first thing the phy driver is doing is disabling this broadcast address. > > The phy is then available only on address 1 but the mdio driver doesn't > > know about it. > > > > Instead, register the mdio bus using of_mdiobus_register and try to find > > the phy description in device tree before falling back to phy_find_first. > > > > This ultimately also allows to describe the interrupt the phy is connected > > to. > > > > Signed-off-by: Alexandre Belloni > > I asked you to address Andrew's feedback. > > You can't let this sit for days like that. > > Therefore, I'm dropping your patches. I'm planning to send a v2 to address that but I didn't have time to test today. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com