Re: [PATCH 1/4] staging: sm750fb: Edit CamelCase in ddk750_dvi.c

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Oct 16, 2019 at 02:20:45PM -0700, Jamal Shareef wrote:
> Edit CamelCase naming convention in ddk750_dvi.c file.
> Issue found by checkpatch.
> 
> Edit depends on related files which are also being patched
> as part of the patchset.
> 
> Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c | 68 ++++++++++++++--------------
>  1 file changed, 34 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index cd564ea40779..6fa77d4effef 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -11,50 +11,50 @@
>   * function API. Please set the function pointer to NULL whenever the function
>   * is not supported.
>   */
> -static struct dvi_ctrl_device g_dcftSupportedDviController[] = {
> +static struct dvi_ctrl_device g_dcft_supported_dvi_controller[] = {
>  #ifdef DVI_CTRL_SII164
>  	{
> -		.pfnInit = sii164InitChip,
> -		.pfnGetVendorId = sii164GetVendorID,
> -		.pfnGetDeviceId = sii164GetDeviceID,
> +	    .pfn_init = sii164_init_chip,
> +	    .pfn_get_vendor_id = sii164_get_vendor_id,
> +	    .pfn_get_device_id = sii164_get_device_id,
>  #ifdef SII164_FULL_FUNCTIONS
> -		.pfnResetChip = sii164ResetChip,
> -		.pfnGetChipString = sii164GetChipString,
> -		.pfnSetPower = sii164SetPower,
> -		.pfnEnableHotPlugDetection = sii164EnableHotPlugDetection,
> -		.pfnIsConnected = sii164IsConnected,
> -		.pfnCheckInterrupt = sii164CheckInterrupt,
> -		.pfnClearInterrupt = sii164ClearInterrupt,
> +	    .pfn_reset_chip = sii164_reset_chip,
> +	    .pfn_get_chip_string = sii164_get_chip_string,
> +	    .pfn_set_power = sii164_set_power,
> +	    .pfn_enable_hot_plug_detection = sii164_enable_hot_plug_detection,
> +	    .pfn_is_connected = sii164_is_connected,
> +	    .pfn_check_interrupt = sii164_check_interrupt,
> +	    .pfn_clear_interrupt = sii164_clear_interrupt,
>  #endif
>  	},
>  #endif
>  };
>  
> -int dviInit(unsigned char edge_select,
> -	    unsigned char bus_select,
> -	    unsigned char dual_edge_clk_select,
> -	    unsigned char hsync_enable,
> -	    unsigned char vsync_enable,
> -	    unsigned char deskew_enable,
> -	    unsigned char deskew_setting,
> -	    unsigned char continuous_sync_enable,
> -	    unsigned char pll_filter_enable,
> -	    unsigned char pll_filter_value)
> +int dvi_init(unsigned char edge_select,

You didn't also change the .h file at the same time, how did this build?

You can't break the build at any point in time, every patch must work
properly.

Ah, no one even calls this function, maybe that's why this works?  If
so, just delete the function entirely!

thanks,

greg k-h