From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113D2FA372B for ; Wed, 16 Oct 2019 21:37:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1105222BE for ; Wed, 16 Oct 2019 21:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571261851; bh=BToQdUBx9qY6hKY0xdSe3TOGO3X2grELTDzYygtGQfA=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=oPJzzwVJsCWzgegb7rKBBUlv6qpiGQFN2hlTJQFwPxBetUA4cVBGEFhrpVSzm+BKc p25IqPCcrd0wNl+mSizsS+5nvYOm25EH2zf7rIP0J0nOgn8OqDcvS1gyONUTudLyAh 5jHCGOfbm9JpdSUEM9J1d5g4T81Mife1LLiBbX7M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389344AbfJPVh1 (ORCPT ); Wed, 16 Oct 2019 17:37:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727447AbfJPVh1 (ORCPT ); Wed, 16 Oct 2019 17:37:27 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4099F21848; Wed, 16 Oct 2019 21:37:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571261846; bh=BToQdUBx9qY6hKY0xdSe3TOGO3X2grELTDzYygtGQfA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=CquTfipJy7CeJWhIfYJrex5ZRZriKyKFRQ4Z9hrHwAq8C1bbYFsPdKyxuKi6OyK3w tEandPPvX0AeSMyVuiD/Ut/X9Tsp8l+EwWib1Ht3T9kJzknTCn08VK19eu8+1g3YCX w+LW8/XbftpjDMgtgObUI9N2BDQHjdxvnna1AhuQ= Date: Wed, 16 Oct 2019 16:37:22 -0500 From: Bjorn Helgaas To: Karol Herbst , "Rafael J . Wysocki" Cc: LKML , Lyude Paul , Mika Westerberg , Linux PCI , Linux PM , dri-devel , nouveau , linux-acpi@vger.kernel.org Subject: Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Message-ID: <20191016213722.GA72810@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org [+cc linux-acpi] On Wed, Oct 16, 2019 at 09:18:32PM +0200, Karol Herbst wrote: > but setting the PCI_DEV_FLAGS_NO_D3 flag does prevent using the > platform means of putting the device into D3cold, right? That's > actually what should still happen, just the D3hot step should be > skipped. If I understand correctly, when we put a device in D3cold on an ACPI system, we do something like this: pci_set_power_state(D3cold) if (PCI_DEV_FLAGS_NO_D3) return 0 <-- nothing at all if quirked pci_raw_set_power_state pci_write_config_word(PCI_PM_CTRL, D3hot) <-- set to D3hot __pci_complete_power_transition(D3cold) pci_platform_power_transition(D3cold) platform_pci_set_power_state(D3cold) acpi_pci_set_power_state(D3cold) acpi_device_set_power(ACPI_STATE_D3_COLD) ... acpi_evaluate_object("_OFF") <-- set to D3cold I did not understand the connection with platform (ACPI) power management from your patch. It sounds like you want this entire path except that you want to skip the PCI_PM_CTRL write? That seems like something Rafael should weigh in on. I don't know why we set the device to D3hot with PCI_PM_CTRL before using the ACPI methods, and I don't know what the effect of skipping that is. It seems a little messy to slice out this tiny piece from the middle, but maybe it makes sense. > On Wed, Oct 16, 2019 at 9:14 PM Bjorn Helgaas wrote: > > > > On Wed, Oct 16, 2019 at 04:44:49PM +0200, Karol Herbst wrote: > > > Fixes state transitions of Nvidia Pascal GPUs from D3cold into higher device > > > states. > > > > > > v2: convert to pci_dev quirk > > > put a proper technical explanation of the issue as a in-code comment > > > v3: disable it only for certain combinations of intel and nvidia hardware > > > > > > Signed-off-by: Karol Herbst > > > Cc: Bjorn Helgaas > > > Cc: Lyude Paul > > > Cc: Rafael J. Wysocki > > > Cc: Mika Westerberg > > > Cc: linux-pci@vger.kernel.org > > > Cc: linux-pm@vger.kernel.org > > > Cc: dri-devel@lists.freedesktop.org > > > Cc: nouveau@lists.freedesktop.org > > > --- > > > drivers/pci/pci.c | 11 ++++++++++ > > > drivers/pci/quirks.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ > > > include/linux/pci.h | 1 + > > > 3 files changed, 64 insertions(+) > > > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > > index b97d9e10c9cc..8e056eb7e6ff 100644 > > > --- a/drivers/pci/pci.c > > > +++ b/drivers/pci/pci.c > > > @@ -805,6 +805,13 @@ static inline bool platform_pci_bridge_d3(struct pci_dev *dev) > > > return pci_platform_pm ? pci_platform_pm->bridge_d3(dev) : false; > > > } > > > > > > +static inline bool parent_broken_child_pm(struct pci_dev *dev) > > > +{ > > > + if (!dev->bus || !dev->bus->self) > > > + return false; > > > + return dev->bus->self->broken_nv_runpm && dev->broken_nv_runpm; > > > +} > > > + > > > /** > > > * pci_raw_set_power_state - Use PCI PM registers to set the power state of > > > * given PCI device > > > @@ -850,6 +857,10 @@ static int pci_raw_set_power_state(struct pci_dev *dev, pci_power_t state) > > > || (state == PCI_D2 && !dev->d2_support)) > > > return -EIO; > > > > > > + /* check if the bus controller causes issues */ > > > + if (state != PCI_D0 && parent_broken_child_pm(dev)) > > > + return 0; > > > + > > > pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); > > > > > > /* > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > > index 44c4ae1abd00..c2f20b745dd4 100644 > > > --- a/drivers/pci/quirks.c > > > +++ b/drivers/pci/quirks.c > > > @@ -5268,3 +5268,55 @@ static void quirk_reset_lenovo_thinkpad_p50_nvgpu(struct pci_dev *pdev) > > > DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, 0x13b1, > > > PCI_CLASS_DISPLAY_VGA, 8, > > > quirk_reset_lenovo_thinkpad_p50_nvgpu); > > > + > > > +/* > > > + * Some Intel PCIe bridges cause devices to disappear from the PCIe bus after > > > + * those were put into D3cold state if they were put into a non D0 PCI PM > > > + * device state before doing so. > > > + * > > > + * This leads to various issue different issues which all manifest differently, > > > + * but have the same root cause: > > > + * - AIML code execution hits an infinite loop (as the coe waits on device > > > + * memory to change). > > > + * - kernel crashes, as all pci reads return -1, which most code isn't able > > > + * to handle well enough. > > > + * - sudden shutdowns, as the kernel identified an unrecoverable error after > > > + * userspace tries to access the GPU. > > > + * > > > + * In all cases dmesg will contain at least one line like this: > > > + * 'nouveau 0000:01:00.0: Refused to change power state, currently in D3' > > > + * followed by a lot of nouveau timeouts. > > > + * > > > + * ACPI code writes bit 0x80 to the not documented PCI register 0x248 of the > > > + * PCIe bridge controller in order to power down the GPU. > > > + * Nonetheless, there are other code paths inside the ACPI firmware which use > > > + * other registers, which seem to work fine: > > > + * - 0xbc bit 0x20 (publicly available documentation claims 'reserved') > > > + * - 0xb0 bit 0x10 (link disable) > > > + * Changing the conditions inside the firmware by poking into the relevant > > > + * addresses does resolve the issue, but it seemed to be ACPI private memory > > > + * and not any device accessible memory at all, so there is no portable way of > > > + * changing the conditions. > > > + * > > > + * The only systems where this behavior can be seen are hybrid graphics laptops > > > + * with a secondary Nvidia Pascal GPU. It cannot be ruled out that this issue > > > + * only occurs in combination with listed Intel PCIe bridge controllers and > > > + * the mentioned GPUs or if it's only a hw bug in the bridge controller. > > > + * > > > + * But because this issue was NOT seen on laptops with an Nvidia Pascal GPU > > > + * and an Intel Coffee Lake SoC, there is a higher chance of there being a bug > > > + * in the bridge controller rather than in the GPU. > > > + * > > > + * This issue was not able to be reproduced on non laptop systems. > > > + */ > > > + > > > +static void quirk_broken_nv_runpm(struct pci_dev *dev) > > > +{ > > > + dev->broken_nv_runpm = 1; > > > > Can you use the existing PCI_DEV_FLAGS_NO_D3 flag for this instead of > > adding a new flag? > > > > I would put the parent_broken_child_pm() logic here, if possible, > > e.g., something like: > > > > struct pci_dev *bridge = pci_upstream_bridge(dev); > > > > if (bridge && > > bridge->vendor == PCI_VENDOR_ID_INTEL && bridge->device == 0x1901) > > dev->dev_flags |= PCI_DEV_FLAGS_NO_D3; > > > > > +} > > > +DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, > > > + PCI_BASE_CLASS_DISPLAY, 16, > > > + quirk_broken_nv_runpm); > > > +/* kaby lake */ > > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x1901, > > > + quirk_broken_nv_runpm); > > > diff --git a/include/linux/pci.h b/include/linux/pci.h > > > index ac8a6c4e1792..903a0b3a39ec 100644 > > > --- a/include/linux/pci.h > > > +++ b/include/linux/pci.h > > > @@ -416,6 +416,7 @@ struct pci_dev { > > > unsigned int __aer_firmware_first_valid:1; > > > unsigned int __aer_firmware_first:1; > > > unsigned int broken_intx_masking:1; /* INTx masking can't be used */ > > > + unsigned int broken_nv_runpm:1; /* some combinations of intel bridge controller and nvidia GPUs break rtd3 */ > > > unsigned int io_window_1k:1; /* Intel bridge 1K I/O windows */ > > > unsigned int irq_managed:1; > > > unsigned int has_secondary_link:1; > > > -- > > > 2.21.0 > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH v3] pci: prevent putting nvidia GPUs into lower device states on certain intel bridges Date: Wed, 16 Oct 2019 16:37:22 -0500 Message-ID: <20191016213722.GA72810@google.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Karol Herbst , "Rafael J . Wysocki" Cc: Linux PM , Linux PCI , Mika Westerberg , LKML , dri-devel , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nouveau List-Id: nouveau.vger.kernel.org WytjYyBsaW51eC1hY3BpXQoKT24gV2VkLCBPY3QgMTYsIDIwMTkgYXQgMDk6MTg6MzJQTSArMDIw MCwgS2Fyb2wgSGVyYnN0IHdyb3RlOgo+IGJ1dCBzZXR0aW5nIHRoZSBQQ0lfREVWX0ZMQUdTX05P X0QzIGZsYWcgZG9lcyBwcmV2ZW50IHVzaW5nIHRoZQo+IHBsYXRmb3JtIG1lYW5zIG9mIHB1dHRp bmcgdGhlIGRldmljZSBpbnRvIEQzY29sZCwgcmlnaHQ/IFRoYXQncwo+IGFjdHVhbGx5IHdoYXQg c2hvdWxkIHN0aWxsIGhhcHBlbiwganVzdCB0aGUgRDNob3Qgc3RlcCBzaG91bGQgYmUKPiBza2lw cGVkLgoKSWYgSSB1bmRlcnN0YW5kIGNvcnJlY3RseSwgd2hlbiB3ZSBwdXQgYSBkZXZpY2UgaW4g RDNjb2xkIG9uIGFuIEFDUEkKc3lzdGVtLCB3ZSBkbyBzb21ldGhpbmcgbGlrZSB0aGlzOgoKICBw Y2lfc2V0X3Bvd2VyX3N0YXRlKEQzY29sZCkKICAgIGlmIChQQ0lfREVWX0ZMQUdTX05PX0QzKQog ICAgICByZXR1cm4gMCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPC0tIG5vdGhp bmcgYXQgYWxsIGlmIHF1aXJrZWQKICAgIHBjaV9yYXdfc2V0X3Bvd2VyX3N0YXRlCiAgICAgIHBj aV93cml0ZV9jb25maWdfd29yZChQQ0lfUE1fQ1RSTCwgRDNob3QpICA8LS0gc2V0IHRvIEQzaG90 CiAgICBfX3BjaV9jb21wbGV0ZV9wb3dlcl90cmFuc2l0aW9uKEQzY29sZCkKICAgICAgcGNpX3Bs YXRmb3JtX3Bvd2VyX3RyYW5zaXRpb24oRDNjb2xkKQogICAgICAgIHBsYXRmb3JtX3BjaV9zZXRf cG93ZXJfc3RhdGUoRDNjb2xkKQogICAgICAgICAgYWNwaV9wY2lfc2V0X3Bvd2VyX3N0YXRlKEQz Y29sZCkKICAgICAgICAgICAgYWNwaV9kZXZpY2Vfc2V0X3Bvd2VyKEFDUElfU1RBVEVfRDNfQ09M RCkKICAgICAgICAgICAgICAuLi4KICAgICAgICAgICAgICAgIGFjcGlfZXZhbHVhdGVfb2JqZWN0 KCJfT0ZGIikgICAgIDwtLSBzZXQgdG8gRDNjb2xkCgpJIGRpZCBub3QgdW5kZXJzdGFuZCB0aGUg Y29ubmVjdGlvbiB3aXRoIHBsYXRmb3JtIChBQ1BJKSBwb3dlcgptYW5hZ2VtZW50IGZyb20geW91 ciBwYXRjaC4gIEl0IHNvdW5kcyBsaWtlIHlvdSB3YW50IHRoaXMgZW50aXJlIHBhdGgKZXhjZXB0 IHRoYXQgeW91IHdhbnQgdG8gc2tpcCB0aGUgUENJX1BNX0NUUkwgd3JpdGU/CgpUaGF0IHNlZW1z IGxpa2Ugc29tZXRoaW5nIFJhZmFlbCBzaG91bGQgd2VpZ2ggaW4gb24uICBJIGRvbid0IGtub3cK d2h5IHdlIHNldCB0aGUgZGV2aWNlIHRvIEQzaG90IHdpdGggUENJX1BNX0NUUkwgYmVmb3JlIHVz aW5nIHRoZSBBQ1BJCm1ldGhvZHMsIGFuZCBJIGRvbid0IGtub3cgd2hhdCB0aGUgZWZmZWN0IG9m IHNraXBwaW5nIHRoYXQgaXMuICBJdApzZWVtcyBhIGxpdHRsZSBtZXNzeSB0byBzbGljZSBvdXQg dGhpcyB0aW55IHBpZWNlIGZyb20gdGhlIG1pZGRsZSwgYnV0Cm1heWJlIGl0IG1ha2VzIHNlbnNl LgoKPiBPbiBXZWQsIE9jdCAxNiwgMjAxOSBhdCA5OjE0IFBNIEJqb3JuIEhlbGdhYXMgPGhlbGdh YXNAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gT24gV2VkLCBPY3QgMTYsIDIwMTkgYXQgMDQ6 NDQ6NDlQTSArMDIwMCwgS2Fyb2wgSGVyYnN0IHdyb3RlOgo+ID4gPiBGaXhlcyBzdGF0ZSB0cmFu c2l0aW9ucyBvZiBOdmlkaWEgUGFzY2FsIEdQVXMgZnJvbSBEM2NvbGQgaW50byBoaWdoZXIgZGV2 aWNlCj4gPiA+IHN0YXRlcy4KPiA+ID4KPiA+ID4gdjI6IGNvbnZlcnQgdG8gcGNpX2RldiBxdWly awo+ID4gPiAgICAgcHV0IGEgcHJvcGVyIHRlY2huaWNhbCBleHBsYW5hdGlvbiBvZiB0aGUgaXNz dWUgYXMgYSBpbi1jb2RlIGNvbW1lbnQKPiA+ID4gdjM6IGRpc2FibGUgaXQgb25seSBmb3IgY2Vy dGFpbiBjb21iaW5hdGlvbnMgb2YgaW50ZWwgYW5kIG52aWRpYSBoYXJkd2FyZQo+ID4gPgo+ID4g PiBTaWduZWQtb2ZmLWJ5OiBLYXJvbCBIZXJic3QgPGtoZXJic3RAcmVkaGF0LmNvbT4KPiA+ID4g Q2M6IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+Cj4gPiA+IENjOiBMeXVkZSBQ YXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4gPiBDYzogUmFmYWVsIEouIFd5c29ja2kgPHJqd0By and5c29ja2kubmV0Pgo+ID4gPiBDYzogTWlrYSBXZXN0ZXJiZXJnIDxtaWthLndlc3RlcmJlcmdA aW50ZWwuY29tPgo+ID4gPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9yZwo+ID4gPiBDYzog bGludXgtcG1Admdlci5rZXJuZWwub3JnCj4gPiA+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPiA+IENjOiBub3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiAt LS0KPiA+ID4gIGRyaXZlcnMvcGNpL3BjaS5jICAgIHwgMTEgKysrKysrKysrKwo+ID4gPiAgZHJp dmVycy9wY2kvcXVpcmtzLmMgfCA1MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwo+ID4gPiAgaW5jbHVkZS9saW51eC9wY2kuaCAgfCAgMSArCj4gPiA+ICAzIGZp bGVzIGNoYW5nZWQsIDY0IGluc2VydGlvbnMoKykKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvcGNpL3BjaS5jIGIvZHJpdmVycy9wY2kvcGNpLmMKPiA+ID4gaW5kZXggYjk3ZDllMTBj OWNjLi44ZTA1NmViN2U2ZmYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvcGNpL3BjaS5jCj4g PiA+ICsrKyBiL2RyaXZlcnMvcGNpL3BjaS5jCj4gPiA+IEBAIC04MDUsNiArODA1LDEzIEBAIHN0 YXRpYyBpbmxpbmUgYm9vbCBwbGF0Zm9ybV9wY2lfYnJpZGdlX2QzKHN0cnVjdCBwY2lfZGV2ICpk ZXYpCj4gPiA+ICAgICAgIHJldHVybiBwY2lfcGxhdGZvcm1fcG0gPyBwY2lfcGxhdGZvcm1fcG0t PmJyaWRnZV9kMyhkZXYpIDogZmFsc2U7Cj4gPiA+ICB9Cj4gPiA+Cj4gPiA+ICtzdGF0aWMgaW5s aW5lIGJvb2wgcGFyZW50X2Jyb2tlbl9jaGlsZF9wbShzdHJ1Y3QgcGNpX2RldiAqZGV2KQo+ID4g PiArewo+ID4gPiArICAgICBpZiAoIWRldi0+YnVzIHx8ICFkZXYtPmJ1cy0+c2VsZikKPiA+ID4g KyAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiA+ICsgICAgIHJldHVybiBkZXYtPmJ1cy0+ c2VsZi0+YnJva2VuX252X3J1bnBtICYmIGRldi0+YnJva2VuX252X3J1bnBtOwo+ID4gPiArfQo+ ID4gPiArCj4gPiA+ICAvKioKPiA+ID4gICAqIHBjaV9yYXdfc2V0X3Bvd2VyX3N0YXRlIC0gVXNl IFBDSSBQTSByZWdpc3RlcnMgdG8gc2V0IHRoZSBwb3dlciBzdGF0ZSBvZgo+ID4gPiAgICogICAg ICAgICAgICAgICAgICAgICAgICBnaXZlbiBQQ0kgZGV2aWNlCj4gPiA+IEBAIC04NTAsNiArODU3 LDEwIEBAIHN0YXRpYyBpbnQgcGNpX3Jhd19zZXRfcG93ZXJfc3RhdGUoc3RydWN0IHBjaV9kZXYg KmRldiwgcGNpX3Bvd2VyX3Qgc3RhdGUpCj4gPiA+ICAgICAgICAgIHx8IChzdGF0ZSA9PSBQQ0lf RDIgJiYgIWRldi0+ZDJfc3VwcG9ydCkpCj4gPiA+ICAgICAgICAgICAgICAgcmV0dXJuIC1FSU87 Cj4gPiA+Cj4gPiA+ICsgICAgIC8qIGNoZWNrIGlmIHRoZSBidXMgY29udHJvbGxlciBjYXVzZXMg aXNzdWVzICovCj4gPiA+ICsgICAgIGlmIChzdGF0ZSAhPSBQQ0lfRDAgJiYgcGFyZW50X2Jyb2tl bl9jaGlsZF9wbShkZXYpKQo+ID4gPiArICAgICAgICAgICAgIHJldHVybiAwOwo+ID4gPiArCj4g PiA+ICAgICAgIHBjaV9yZWFkX2NvbmZpZ193b3JkKGRldiwgZGV2LT5wbV9jYXAgKyBQQ0lfUE1f Q1RSTCwgJnBtY3NyKTsKPiA+ID4KPiA+ID4gICAgICAgLyoKPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvcGNpL3F1aXJrcy5jIGIvZHJpdmVycy9wY2kvcXVpcmtzLmMKPiA+ID4gaW5kZXggNDRj NGFlMWFiZDAwLi5jMmYyMGI3NDVkZDQgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvcGNpL3F1 aXJrcy5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvcGNpL3F1aXJrcy5jCj4gPiA+IEBAIC01MjY4LDMg KzUyNjgsNTUgQEAgc3RhdGljIHZvaWQgcXVpcmtfcmVzZXRfbGVub3ZvX3RoaW5rcGFkX3A1MF9u dmdwdShzdHJ1Y3QgcGNpX2RldiAqcGRldikKPiA+ID4gIERFQ0xBUkVfUENJX0ZJWFVQX0NMQVNT X0ZJTkFMKFBDSV9WRU5ET1JfSURfTlZJRElBLCAweDEzYjEsCj4gPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBQQ0lfQ0xBU1NfRElTUExBWV9WR0EsIDgsCj4gPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBxdWlya19yZXNldF9sZW5vdm9fdGhpbmtwYWRfcDUwX252Z3B1KTsK PiA+ID4gKwo+ID4gPiArLyoKPiA+ID4gKyAqIFNvbWUgSW50ZWwgUENJZSBicmlkZ2VzIGNhdXNl IGRldmljZXMgdG8gZGlzYXBwZWFyIGZyb20gdGhlIFBDSWUgYnVzIGFmdGVyCj4gPiA+ICsgKiB0 aG9zZSB3ZXJlIHB1dCBpbnRvIEQzY29sZCBzdGF0ZSBpZiB0aGV5IHdlcmUgcHV0IGludG8gYSBu b24gRDAgUENJIFBNCj4gPiA+ICsgKiBkZXZpY2Ugc3RhdGUgYmVmb3JlIGRvaW5nIHNvLgo+ID4g PiArICoKPiA+ID4gKyAqIFRoaXMgbGVhZHMgdG8gdmFyaW91cyBpc3N1ZSBkaWZmZXJlbnQgaXNz dWVzIHdoaWNoIGFsbCBtYW5pZmVzdCBkaWZmZXJlbnRseSwKPiA+ID4gKyAqIGJ1dCBoYXZlIHRo ZSBzYW1lIHJvb3QgY2F1c2U6Cj4gPiA+ICsgKiAgLSBBSU1MIGNvZGUgZXhlY3V0aW9uIGhpdHMg YW4gaW5maW5pdGUgbG9vcCAoYXMgdGhlIGNvZSB3YWl0cyBvbiBkZXZpY2UKPiA+ID4gKyAqICAg IG1lbW9yeSB0byBjaGFuZ2UpLgo+ID4gPiArICogIC0ga2VybmVsIGNyYXNoZXMsIGFzIGFsbCBw Y2kgcmVhZHMgcmV0dXJuIC0xLCB3aGljaCBtb3N0IGNvZGUgaXNuJ3QgYWJsZQo+ID4gPiArICog ICAgdG8gaGFuZGxlIHdlbGwgZW5vdWdoLgo+ID4gPiArICogIC0gc3VkZGVuIHNodXRkb3ducywg YXMgdGhlIGtlcm5lbCBpZGVudGlmaWVkIGFuIHVucmVjb3ZlcmFibGUgZXJyb3IgYWZ0ZXIKPiA+ ID4gKyAqICAgIHVzZXJzcGFjZSB0cmllcyB0byBhY2Nlc3MgdGhlIEdQVS4KPiA+ID4gKyAqCj4g PiA+ICsgKiBJbiBhbGwgY2FzZXMgZG1lc2cgd2lsbCBjb250YWluIGF0IGxlYXN0IG9uZSBsaW5l IGxpa2UgdGhpczoKPiA+ID4gKyAqICdub3V2ZWF1IDAwMDA6MDE6MDAuMDogUmVmdXNlZCB0byBj aGFuZ2UgcG93ZXIgc3RhdGUsIGN1cnJlbnRseSBpbiBEMycKPiA+ID4gKyAqIGZvbGxvd2VkIGJ5 IGEgbG90IG9mIG5vdXZlYXUgdGltZW91dHMuCj4gPiA+ICsgKgo+ID4gPiArICogQUNQSSBjb2Rl IHdyaXRlcyBiaXQgMHg4MCB0byB0aGUgbm90IGRvY3VtZW50ZWQgUENJIHJlZ2lzdGVyIDB4MjQ4 IG9mIHRoZQo+ID4gPiArICogUENJZSBicmlkZ2UgY29udHJvbGxlciBpbiBvcmRlciB0byBwb3dl ciBkb3duIHRoZSBHUFUuCj4gPiA+ICsgKiBOb25ldGhlbGVzcywgdGhlcmUgYXJlIG90aGVyIGNv ZGUgcGF0aHMgaW5zaWRlIHRoZSBBQ1BJIGZpcm13YXJlIHdoaWNoIHVzZQo+ID4gPiArICogb3Ro ZXIgcmVnaXN0ZXJzLCB3aGljaCBzZWVtIHRvIHdvcmsgZmluZToKPiA+ID4gKyAqICAtIDB4YmMg Yml0IDB4MjAgKHB1YmxpY2x5IGF2YWlsYWJsZSBkb2N1bWVudGF0aW9uIGNsYWltcyAncmVzZXJ2 ZWQnKQo+ID4gPiArICogIC0gMHhiMCBiaXQgMHgxMCAobGluayBkaXNhYmxlKQo+ID4gPiArICog Q2hhbmdpbmcgdGhlIGNvbmRpdGlvbnMgaW5zaWRlIHRoZSBmaXJtd2FyZSBieSBwb2tpbmcgaW50 byB0aGUgcmVsZXZhbnQKPiA+ID4gKyAqIGFkZHJlc3NlcyBkb2VzIHJlc29sdmUgdGhlIGlzc3Vl LCBidXQgaXQgc2VlbWVkIHRvIGJlIEFDUEkgcHJpdmF0ZSBtZW1vcnkKPiA+ID4gKyAqIGFuZCBu b3QgYW55IGRldmljZSBhY2Nlc3NpYmxlIG1lbW9yeSBhdCBhbGwsIHNvIHRoZXJlIGlzIG5vIHBv cnRhYmxlIHdheSBvZgo+ID4gPiArICogY2hhbmdpbmcgdGhlIGNvbmRpdGlvbnMuCj4gPiA+ICsg Kgo+ID4gPiArICogVGhlIG9ubHkgc3lzdGVtcyB3aGVyZSB0aGlzIGJlaGF2aW9yIGNhbiBiZSBz ZWVuIGFyZSBoeWJyaWQgZ3JhcGhpY3MgbGFwdG9wcwo+ID4gPiArICogd2l0aCBhIHNlY29uZGFy eSBOdmlkaWEgUGFzY2FsIEdQVS4gSXQgY2Fubm90IGJlIHJ1bGVkIG91dCB0aGF0IHRoaXMgaXNz dWUKPiA+ID4gKyAqIG9ubHkgb2NjdXJzIGluIGNvbWJpbmF0aW9uIHdpdGggbGlzdGVkIEludGVs IFBDSWUgYnJpZGdlIGNvbnRyb2xsZXJzIGFuZAo+ID4gPiArICogdGhlIG1lbnRpb25lZCBHUFVz IG9yIGlmIGl0J3Mgb25seSBhIGh3IGJ1ZyBpbiB0aGUgYnJpZGdlIGNvbnRyb2xsZXIuCj4gPiA+ ICsgKgo+ID4gPiArICogQnV0IGJlY2F1c2UgdGhpcyBpc3N1ZSB3YXMgTk9UIHNlZW4gb24gbGFw dG9wcyB3aXRoIGFuIE52aWRpYSBQYXNjYWwgR1BVCj4gPiA+ICsgKiBhbmQgYW4gSW50ZWwgQ29m ZmVlIExha2UgU29DLCB0aGVyZSBpcyBhIGhpZ2hlciBjaGFuY2Ugb2YgdGhlcmUgYmVpbmcgYSBi dWcKPiA+ID4gKyAqIGluIHRoZSBicmlkZ2UgY29udHJvbGxlciByYXRoZXIgdGhhbiBpbiB0aGUg R1BVLgo+ID4gPiArICoKPiA+ID4gKyAqIFRoaXMgaXNzdWUgd2FzIG5vdCBhYmxlIHRvIGJlIHJl cHJvZHVjZWQgb24gbm9uIGxhcHRvcCBzeXN0ZW1zLgo+ID4gPiArICovCj4gPiA+ICsKPiA+ID4g K3N0YXRpYyB2b2lkIHF1aXJrX2Jyb2tlbl9udl9ydW5wbShzdHJ1Y3QgcGNpX2RldiAqZGV2KQo+ ID4gPiArewo+ID4gPiArICAgICBkZXYtPmJyb2tlbl9udl9ydW5wbSA9IDE7Cj4gPgo+ID4gQ2Fu IHlvdSB1c2UgdGhlIGV4aXN0aW5nIFBDSV9ERVZfRkxBR1NfTk9fRDMgZmxhZyBmb3IgdGhpcyBp bnN0ZWFkIG9mCj4gPiBhZGRpbmcgYSBuZXcgZmxhZz8KPiA+Cj4gPiBJIHdvdWxkIHB1dCB0aGUg cGFyZW50X2Jyb2tlbl9jaGlsZF9wbSgpIGxvZ2ljIGhlcmUsIGlmIHBvc3NpYmxlLAo+ID4gZS5n Liwgc29tZXRoaW5nIGxpa2U6Cj4gPgo+ID4gICBzdHJ1Y3QgcGNpX2RldiAqYnJpZGdlID0gcGNp X3Vwc3RyZWFtX2JyaWRnZShkZXYpOwo+ID4KPiA+ICAgaWYgKGJyaWRnZSAmJgo+ID4gICAgICAg YnJpZGdlLT52ZW5kb3IgPT0gUENJX1ZFTkRPUl9JRF9JTlRFTCAmJiBicmlkZ2UtPmRldmljZSA9 PSAweDE5MDEpCj4gPiAgICAgICAgIGRldi0+ZGV2X2ZsYWdzIHw9IFBDSV9ERVZfRkxBR1NfTk9f RDM7Cj4gPgo+ID4gPiArfQo+ID4gPiArREVDTEFSRV9QQ0lfRklYVVBfQ0xBU1NfRklOQUwoUENJ X1ZFTkRPUl9JRF9OVklESUEsIFBDSV9BTllfSUQsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICBQQ0lfQkFTRV9DTEFTU19ESVNQTEFZLCAxNiwKPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgIHF1aXJrX2Jyb2tlbl9udl9ydW5wbSk7Cj4gPiA+ICsvKiBrYWJ5IGxha2Ug Ki8KPiA+ID4gK0RFQ0xBUkVfUENJX0ZJWFVQX0ZJTkFMKFBDSV9WRU5ET1JfSURfSU5URUwsIDB4 MTkwMSwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgIHF1aXJrX2Jyb2tlbl9udl9ydW5wbSk7 Cj4gPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3BjaS5oIGIvaW5jbHVkZS9saW51eC9w Y2kuaAo+ID4gPiBpbmRleCBhYzhhNmM0ZTE3OTIuLjkwM2EwYjNhMzllYyAxMDA2NDQKPiA+ID4g LS0tIGEvaW5jbHVkZS9saW51eC9wY2kuaAo+ID4gPiArKysgYi9pbmNsdWRlL2xpbnV4L3BjaS5o Cj4gPiA+IEBAIC00MTYsNiArNDE2LDcgQEAgc3RydWN0IHBjaV9kZXYgewo+ID4gPiAgICAgICB1 bnNpZ25lZCBpbnQgICAgX19hZXJfZmlybXdhcmVfZmlyc3RfdmFsaWQ6MTsKPiA+ID4gICAgICAg dW5zaWduZWQgaW50ICAgIF9fYWVyX2Zpcm13YXJlX2ZpcnN0OjE7Cj4gPiA+ICAgICAgIHVuc2ln bmVkIGludCAgICBicm9rZW5faW50eF9tYXNraW5nOjE7ICAvKiBJTlR4IG1hc2tpbmcgY2FuJ3Qg YmUgdXNlZCAqLwo+ID4gPiArICAgICB1bnNpZ25lZCBpbnQgICAgYnJva2VuX252X3J1bnBtOjE7 ICAgICAgLyogc29tZSBjb21iaW5hdGlvbnMgb2YgaW50ZWwgYnJpZGdlIGNvbnRyb2xsZXIgYW5k IG52aWRpYSBHUFVzIGJyZWFrIHJ0ZDMgKi8KPiA+ID4gICAgICAgdW5zaWduZWQgaW50ICAgIGlv X3dpbmRvd18xazoxOyAgICAgICAgIC8qIEludGVsIGJyaWRnZSAxSyBJL08gd2luZG93cyAqLwo+ ID4gPiAgICAgICB1bnNpZ25lZCBpbnQgICAgaXJxX21hbmFnZWQ6MTsKPiA+ID4gICAgICAgdW5z aWduZWQgaW50ICAgIGhhc19zZWNvbmRhcnlfbGluazoxOwo+ID4gPiAtLQo+ID4gPiAyLjIxLjAK PiA+ID4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTm91 dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9ub3V2ZWF1