From: Bill Wendling <morbo@google.com>
To: kvm@vger.kernel.org, pbonzini@redhat.com,
alexandru.elisei@arm.com, thuth@redhat.com
Cc: jmattson@google.com, Bill Wendling <morbo@google.com>
Subject: [kvm-unit-tests v2 PATCH 2/2] x86: realmode: fix esp in call test
Date: Wed, 16 Oct 2019 18:25:02 -0700 [thread overview]
Message-ID: <20191017012502.186146-3-morbo@google.com> (raw)
In-Reply-To: <20191017012502.186146-1-morbo@google.com>
esp needs to point at the end of the stack, or it will corrupt memory.
Signed-off-by: Bill Wendling <morbo@google.com>
This is a port of Avi Kivity patch for the long jump test:
4aa229495b0e4159642b4a77e9adfdc81501c095.
Signed-off-by: Bill Wendling <morbo@google.com>
---
x86/realmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/realmode.c b/x86/realmode.c
index 41b8592..f318910 100644
--- a/x86/realmode.c
+++ b/x86/realmode.c
@@ -520,7 +520,7 @@ static void test_call(void)
u32 addr;
inregs = (struct regs){ 0 };
- inregs.esp = (u32)esp;
+ inregs.esp = (u32)(esp+16);
MK_INSN(call1, "mov $test_function, %eax \n\t"
"call *%eax\n\t");
--
2.23.0.700.g56cf767bdb-goog
next prev parent reply other threads:[~2019-10-17 1:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 23:58 [kvm-unit-tests PATCH 0/2] realmode test fixes for clang Bill Wendling
2019-10-12 23:58 ` [kvm-unit-tests PATCH 1/2] x86: realmode: explicitly copy structure to avoid memcpy Bill Wendling
2019-10-16 19:07 ` Jim Mattson
2019-10-21 15:38 ` Paolo Bonzini
2019-10-12 23:58 ` [kvm-unit-tests PATCH 2/2] x86: realmode: use inline asm to get stack pointer Bill Wendling
2019-10-16 19:53 ` Jim Mattson
2019-10-16 21:52 ` Jim Mattson
2019-10-21 15:41 ` Paolo Bonzini
2019-10-17 1:25 ` [kvm-unit-tests v2 PATCH 0/2] realmode test fixes for clang Bill Wendling
2019-10-17 1:25 ` [kvm-unit-tests v2 PATCH 1/2] x86: realmode: explicitly copy regs structure Bill Wendling
2019-10-17 1:25 ` Bill Wendling [this message]
2019-10-17 23:27 ` [kvm-unit-tests v2 PATCH 2/2] x86: realmode: fix esp in call test Jim Mattson
2019-10-21 15:43 ` Paolo Bonzini
2019-10-21 16:43 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017012502.186146-3-morbo@google.com \
--to=morbo@google.com \
--cc=alexandru.elisei@arm.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.