All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: qiming.yang@intel.com, dev@dpdk.org,
	Dan Nowlin <dan.nowlin@intel.com>,
	Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol
Date: Thu, 17 Oct 2019 13:46:20 +0800	[thread overview]
Message-ID: <20191017054620.GU3725@intel.com> (raw)
In-Reply-To: <20191017051854.41066-1-qi.z.zhang@intel.com>

On 10/17, Qi Zhang wrote:
>For the GTP protocol, the QFI offset used by to create the field vector
>was off by one byte. This patch corrects that offset.
>
>Fixes: febb0f877f6e ("net/ice/base: add QFI for flow director")
>
>Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
>Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
> drivers/net/ice/base/ice_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
>index f4f961167..d2dbb1177 100644
>--- a/drivers/net/ice/base/ice_flow.c
>+++ b/drivers/net/ice/base/ice_flow.c
>@@ -131,8 +131,8 @@ struct ice_flow_field_info ice_flds_info[ICE_FLOW_FIELD_IDX_MAX] = {
> 	ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_EH, 12,
> 			  ICE_FLOW_FLD_SZ_GTP_TEID),
> 	/* ICE_FLOW_FIELD_IDX_GTPU_EH_QFI */
>-	ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 20,
>-			      ICE_FLOW_FLD_SZ_GTP_QFI, 0x003f),
>+	ICE_FLOW_FLD_INFO_MSK(ICE_FLOW_SEG_HDR_GTPU_EH, 22,
>+			      ICE_FLOW_FLD_SZ_GTP_QFI, 0x3f00),
> 	/* ICE_FLOW_FIELD_IDX_GTPU_UP_TEID */
> 	ICE_FLOW_FLD_INFO(ICE_FLOW_SEG_HDR_GTPU_UP, 12,
> 			  ICE_FLOW_FLD_SZ_GTP_TEID),
>-- 
>2.13.6
>

Applied to dpdk-next-net-intel.

Thanks,
Xiaolong

  reply	other threads:[~2019-10-17  5:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  5:18 [dpdk-dev] [PATCH] net/ice/base: fix for FDIR QFI offset in GTP protocol Qi Zhang
2019-10-17  5:46 ` Ye Xiaolong [this message]
2019-10-17 10:39   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017054620.GU3725@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dan.nowlin@intel.com \
    --cc=dev@dpdk.org \
    --cc=paul.m.stillwell.jr@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.