[MPTCP] Re: [RFC 1/2] mptcp: Export low-level routines for IPv6

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Paolo Abeni <pabeni(a)redhat.com> wrote:
> > -static void inet6_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb)
> > +void inet6_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb)
> >  {
> >  	struct dst_entry *dst = skb_dst(skb);
> >  
> > @@ -111,6 +111,7 @@ static void inet6_sk_rx_dst_set(struct sock *sk, const struct sk_buff *skb)
> >  		tcp_inet6_sk(sk)->rx_dst_cookie = rt6_get_cookie(rt);
> >  	}
> >  }
> > +EXPORT_SYMBOL(inet6_sk_rx_dst_set);
> 
> I think this is not needed, as we don't build mptcp as a module.
> Dropping the 'static' scope should suffice. This should apply also to
> tcp_request_sock_ipv6_ops, tcp_v6_syn_recv_sock and ipv6_specific
> below.

Yes, but ipv6 can be built as a module, i.e. mptcp cannot call any ipv6
related symbol directly.

This will need rather ugly indirections, similar to
include/linux/netfilter_ipv6.h / "struct nf_ipv6_ops".