From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>, qemu-s390x@nongnu.org
Cc: Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org
Subject: [PATCH] hw/s390x: Emit a warning if user tried to enable USB
Date: Thu, 17 Oct 2019 16:21:23 +0200 [thread overview]
Message-ID: <20191017142123.1236-1-thuth@redhat.com> (raw)
There is no USB on s390x, so running qemu-system-s390x with
"-machine ...,usb=on" is certainly wrong. Emit a warning to make
the users aware of their misconfiguration.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
After a year or two, we could finally turn this into a hard error,
but I think we should give the users some time to fix their command
lines first, so I'm initially only emitting a warning here.
hw/s390x/s390-virtio-ccw.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index d3edeef0ad..af8c4c0daf 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -243,6 +243,10 @@ static void ccw_init(MachineState *machine)
VirtualCssBus *css_bus;
DeviceState *dev;
+ if (machine->usb) {
+ warn_report("This machine does not support USB");
+ }
+
s390_sclp_init();
/* init memory + setup max page size. Required for the CPU model */
s390_memory_init(machine->ram_size);
--
2.18.1
next reply other threads:[~2019-10-17 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:21 Thomas Huth [this message]
2019-10-17 14:34 ` [PATCH] hw/s390x: Emit a warning if user tried to enable USB Cornelia Huck
2019-10-17 14:40 ` Thomas Huth
2019-10-17 15:29 ` Cornelia Huck
2019-10-18 5:20 ` Markus Armbruster
2019-10-17 18:18 ` Philippe Mathieu-Daudé
2019-10-18 6:35 ` Thomas Huth
2019-10-18 7:37 ` Philippe Mathieu-Daudé
2019-10-18 8:41 ` Cornelia Huck
2019-10-17 14:45 ` Christian Borntraeger
2019-10-17 16:14 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017142123.1236-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.