From: "J. Bruce Fields" <bfields@fieldses.org>
To: Rick Macklem <rmacklem@uoguelph.ca>
Cc: "Kornievskaia, Olga" <Olga.Kornievskaia@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"nfsv4@ietf.org" <nfsv4@ietf.org>
Subject: Re: NFSv4.2 server replies to Copy with length == 0
Date: Thu, 17 Oct 2019 11:22:53 -0400 [thread overview]
Message-ID: <20191017152253.GG32141@fieldses.org> (raw)
In-Reply-To: <YQBPR0101MB16524CABD71AACBD2D9DC651DD6D0@YQBPR0101MB1652.CANPRD01.PROD.OUTLOOK.COM>
On Thu, Oct 17, 2019 at 02:16:36AM +0000, Rick Macklem wrote:
> I have now found two cases where the Linux NFSv4.2 server does not
> conform to RFC-7862. One is as above and the other is a reply to Seek
> of NFS4ERR_NXIO when the sa_offset argument == file_size (instead of
> replying NFS_OK along with sr_eof == true).
Huh. Looks like that's documented behavior of Linux's seek. (See the
ERRORS section of the lseek(2) man page.) Looks like Solaris also
returns -ENXIO in this case:
https://docs.oracle.com/cd/E26502_01/html/E29032/lseek-2.html
And freebsd too:
https://www.freebsd.org/cgi/man.cgi?query=lseek&sektion=2
I wonder where that spec language came from?
Our NFS server could translate an -ENXIO return into 0 and sr_eof ==
true easily enough, assuming -ENXIO is really only ever returned in that
case.
I haven't tested, but from a quick check of the Linux client code I
think that would require a matching fix on the client side to translate
sr_eof == 0 *back* to ENXIO.
I don't know if it's worth it.
--b.
next prev parent reply other threads:[~2019-10-17 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 2:50 NFSv4.2 server replies to Copy with length == 0 Rick Macklem
2019-10-16 6:22 ` Rick Macklem
2019-10-16 15:58 ` J. Bruce Fields
2019-10-16 19:53 ` Kornievskaia, Olga
2019-10-16 20:31 ` J. Bruce Fields
2019-10-17 2:16 ` Rick Macklem
2019-10-17 4:43 ` Rick Macklem
2019-10-17 14:49 ` J. Bruce Fields
2019-10-17 15:22 ` J. Bruce Fields [this message]
2019-10-17 15:39 ` Tom Talpey
2019-10-17 16:20 ` Rick Macklem
2019-10-17 17:15 ` [nfsv4] " Olga Kornievskaia
2019-10-17 21:34 ` Rick Macklem
2019-10-17 15:55 ` Rick Macklem
2019-10-17 16:14 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017152253.GG32141@fieldses.org \
--to=bfields@fieldses.org \
--cc=Olga.Kornievskaia@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@ietf.org \
--cc=rmacklem@uoguelph.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.