All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>
Subject: Re: [PATCH v13 09/18] ARM: dts: n900: Add reg property to the LP5523 channel node
Date: Thu, 17 Oct 2019 09:10:57 -0700	[thread overview]
Message-ID: <20191017161057.GM5610@atomide.com> (raw)
In-Reply-To: <20191016155954.29044-10-dmurphy@ti.com>

* Dan Murphy <dmurphy@ti.com> [191016 16:01]:
> Add the reg property to each channel node.  This update is
> to accomodate the multicolor framework.  In addition to the
> accomodation this allows the LEDs to be placed on any channel
> and allow designs to skip channels as opposed to requiring
> sequential order.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Tony Lindgren <tony@atomide.com>
> CC: "Benoît Cousson" <bcousson@baylibre.com>
> 
> k# interactive rebase in progress; onto ae89cc6d4a8c

Maybe check what's up with the line above :)

Othwerwise looks good to me, best to merge this together
with the rest of the series when ready:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  arch/arm/boot/dts/omap3-n900.dts | 29 ++++++++++++++++++++---------
>  1 file changed, 20 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 84a5ade1e865..643f35619246 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -607,63 +607,74 @@
>  	};
>  
>  	lp5523: lp5523@32 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>  		compatible = "national,lp5523";
>  		reg = <0x32>;
>  		clock-mode = /bits/ 8 <0>; /* LP55XX_CLOCK_AUTO */
>  		enable-gpio = <&gpio2 9 GPIO_ACTIVE_HIGH>; /* 41 */
>  
> -		chan0 {
> +		chan@0 {
>  			chan-name = "lp5523:kb1";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <0>;
>  		};
>  
> -		chan1 {
> +		chan@1 {
>  			chan-name = "lp5523:kb2";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <1>;
>  		};
>  
> -		chan2 {
> +		chan@2 {
>  			chan-name = "lp5523:kb3";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <2>;
>  		};
>  
> -		chan3 {
> +		chan@3 {
>  			chan-name = "lp5523:kb4";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <3>;
>  		};
>  
> -		chan4 {
> +		chan@4 {
>  			chan-name = "lp5523:b";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <4>;
>  		};
>  
> -		chan5 {
> +		chan@5 {
>  			chan-name = "lp5523:g";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <5>;
>  		};
>  
> -		chan6 {
> +		chan@6 {
>  			chan-name = "lp5523:r";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <6>;
>  		};
>  
> -		chan7 {
> +		chan@7 {
>  			chan-name = "lp5523:kb5";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <7>;
>  		};
>  
> -		chan8 {
> +		chan@8 {
>  			chan-name = "lp5523:kb6";
>  			led-cur = /bits/ 8 <50>;
>  			max-cur = /bits/ 8 <100>;
> +			reg = <8>;
>  		};
>  	};
>  
> -- 
> 2.22.0.214.g8dca754b1e
> 

  reply	other threads:[~2019-10-17 16:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 15:59 [PATCH v13 00/18] Multicolor Framework v13 Dan Murphy
2019-10-16 15:59 ` [PATCH v13 01/18] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2019-10-16 15:59 ` [PATCH v13 02/18] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2019-10-16 15:59 ` [PATCH v13 03/18] " Dan Murphy
2019-10-16 15:59 ` [PATCH v13 04/18] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2019-10-19 18:33   ` Jacek Anaszewski
2019-10-16 15:59 ` [PATCH v13 05/18] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2019-10-16 15:59 ` [PATCH v13 06/18] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2019-10-16 15:59 ` [PATCH v13 07/18] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2019-10-16 15:59 ` [PATCH v13 08/18] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2019-10-16 15:59 ` [PATCH v13 09/18] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2019-10-17 16:10   ` Tony Lindgren [this message]
2019-10-16 15:59 ` [PATCH v13 10/18] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2019-10-28  2:55   ` Shawn Guo
2019-10-16 15:59 ` [PATCH v13 11/18] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2019-10-16 15:59 ` [PATCH v13 12/18] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2019-10-16 15:59 ` [PATCH v13 13/18] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2019-10-16 20:44   ` Jacek Anaszewski
2019-10-16 21:09     ` Jacek Anaszewski
2019-10-16 15:59 ` [PATCH v13 14/18] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2019-10-16 15:59 ` [PATCH v13 15/18] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2019-10-16 15:59 ` [PATCH v13 16/18] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2019-10-16 15:59 ` [PATCH v13 17/18] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2019-10-16 15:59 ` [PATCH v13 18/18] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017161057.GM5610@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.