From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13812FA372A for ; Thu, 17 Oct 2019 16:20:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA61C21A49 for ; Thu, 17 Oct 2019 16:20:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DGd/6VE6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA61C21A49 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cl15YLgIBqTGmW6Wci3OmaCWibvsOO4pXN5cokoJ59c=; b=DGd/6VE6qFsgQ1 GD77Nw0YL/xtwxgES82JrvJp6/elzRdwcY2zFO24HZrOfSSsPtZ1bB1Xdj5rrNsBaO335XZsU0FMJ UfobMidL0eYY/yr9/s846XFnC5t4kNPR9YVMqNdwL6XdvWxx2gOvZw1IYVDlQ+D5k33mkisem8aB3 bmARbwqcTgLGx9QaG0MNn7pb+kqaG3uavAoDyeym6j9GS7vl0SyDsKNOmZrgFAxsDvYHcnNvCU0Qy Ls8mEo87UldwK0vKE6mpZRRNz14rJ9tZywWSy+BjAU79iH8ZX2HvU5T9a59MQFE268S6gGie7CNmu 6avxDOcp/S8x0UqJmeqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL8WG-0004xa-Ka; Thu, 17 Oct 2019 16:20:56 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL8WE-0004ww-JH for linux-riscv@lists.infradead.org; Thu, 17 Oct 2019 16:20:55 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 34EB768BE1; Thu, 17 Oct 2019 18:20:52 +0200 (CEST) Date: Thu, 17 Oct 2019 18:20:52 +0200 From: Christoph Hellwig To: Paul Walmsley Subject: Re: [PATCH 08/20] riscv: abstract out CSR names for supervisor vs machine mode Message-ID: <20191017162052.GA10221@lst.de> References: <20190903093239.21278-1-hch@lst.de> <20190903093239.21278-9-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191017_092054_787685_BAFE04FB X-CRM114-Status: UNSURE ( 7.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal , Palmer Dabbelt , linux-kernel@vger.kernel.org, Atish Patra , linux-riscv@lists.infradead.org, Christoph Hellwig Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMTUsIDIwMTkgYXQgMDc6MDc6MTdQTSAtMDcwMCwgUGF1bCBXYWxtc2xleSB3 cm90ZToKPiA+ICB2b2lkIHN0YXJ0X3RocmVhZChzdHJ1Y3QgcHRfcmVncyAqcmVncywgdW5zaWdu ZWQgbG9uZyBwYywKPiA+ICAJdW5zaWduZWQgbG9uZyBzcCkKPiA+ICB7Cj4gPiAtCXJlZ3MtPnNz dGF0dXMgPSBTUl9TUElFOwo+ID4gKwlyZWdzLT54c3RhdHVzID0gU1JfU1BJRTsKPiAKPiBMb29r cyBsaWtlIHRoaXMgc2hvdWxkIGJlICJyZWdzLT54c3RhdHVzID0gU1JfUElFOyIKPiAKPiBXaWxs IHVwZGF0ZSBpdCBoZXJlLiAgTGV0IG1lIGtub3cgaWYgeW91IGRvbid0IGFncmVlIC0KCnRoZXJl IGlzIG5vIFNSX1BJRSwgZG8geW91IG1lYW4gU1JfWFDQhkU/ICBHb29kIGNhdGNoIGluIHRoYXQg Y2FzZSwKYnV0IHBsZWFzZSBsZXQgbWUgcmVzZW5kIHRoZSB3aG9sZSB0aGluZy4gIEkgaGF2ZSBz b21lIG1pbm9yIHVwZGF0ZXMsCmFuZCBJJ2QgYWxzbyBsaWtlIHRvIGRvIHRoZSByZWJhc2UgbXlz ZWxmLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FDBFA372A for ; Thu, 17 Oct 2019 16:20:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71E5F2089C for ; Thu, 17 Oct 2019 16:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440422AbfJQQUz (ORCPT ); Thu, 17 Oct 2019 12:20:55 -0400 Received: from verein.lst.de ([213.95.11.211]:42557 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729913AbfJQQUy (ORCPT ); Thu, 17 Oct 2019 12:20:54 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 34EB768BE1; Thu, 17 Oct 2019 18:20:52 +0200 (CEST) Date: Thu, 17 Oct 2019 18:20:52 +0200 From: Christoph Hellwig To: Paul Walmsley Cc: Christoph Hellwig , Palmer Dabbelt , Damien Le Moal , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Atish Patra Subject: Re: [PATCH 08/20] riscv: abstract out CSR names for supervisor vs machine mode Message-ID: <20191017162052.GA10221@lst.de> References: <20190903093239.21278-1-hch@lst.de> <20190903093239.21278-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 15, 2019 at 07:07:17PM -0700, Paul Walmsley wrote: > > void start_thread(struct pt_regs *regs, unsigned long pc, > > unsigned long sp) > > { > > - regs->sstatus = SR_SPIE; > > + regs->xstatus = SR_SPIE; > > Looks like this should be "regs->xstatus = SR_PIE;" > > Will update it here. Let me know if you don't agree - there is no SR_PIE, do you mean SR_XPІE? Good catch in that case, but please let me resend the whole thing. I have some minor updates, and I'd also like to do the rebase myself.