* rk3328 USB3 controller
@ 2019-10-16 18:54 Peter Geis
[not found] ` <1b0f65be-51b6-69dd-e204-6d168f17eb7d@think-future.de>
[not found] ` <CAMdYzYp9xdtb6eiUs-Tiq4jJ-jr31LTzng2o-qAbOfu_63zXVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 2 replies; 6+ messages in thread
From: Peter Geis @ 2019-10-16 18:54 UTC (permalink / raw)
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Good Afternoon,
Is there a particular reason why the USB3 controller on the rk3328 has
not been enabled?
It's enabled on the TeamFirefly source [0].
I pulled it in to my device tree and have been using a USB3 SSD as my
boot device for over a year now.
If I were to submit the patch, would y'all be open to pulling it in?
[0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <1b0f65be-51b6-69dd-e204-6d168f17eb7d@think-future.de>]
[parent not found: <1b0f65be-51b6-69dd-e204-6d168f17eb7d-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org>]
* Re: rk3328 USB3 controller [not found] ` <1b0f65be-51b6-69dd-e204-6d168f17eb7d-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org> @ 2019-10-17 16:21 ` 4omecha-Re5JQEeQqe8AvxtiuMwx3w [not found] ` <20191017162131.GH14623-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: 4omecha-Re5JQEeQqe8AvxtiuMwx3w @ 2019-10-17 16:21 UTC (permalink / raw) To: Katsuhiro Suzuki Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Peter Geis On 2019-10-17 14:07:43, Katsuhiro Suzuki wrote: >Hello Peter, > >USB3 phy driver "rockchip,rk3328-u3phy" has not been implemented on >upstream linux kernel. > >FireflyTeam use the special version of linux that is modified by Rockchip. >(It seems based on linux-4.4) > >rockchip,rk3328-u3phy is provided by > https://github.com/FireflyTeam/kernel/drivers/phy/rockchip/phy-rockchip-inno-usb3.c That's a 404 over here. > >If you want to use USB 3.0 with upstream linux, we need to port this >USB3 phy driver from rockchip-linux to upstream kernel, I think. > >Best Regards, >Katsuhiro Suzuki > > >On 2019/10/17 3:54, Peter Geis wrote: >>Good Afternoon, >> >>Is there a particular reason why the USB3 controller on the rk3328 has >>not been enabled? >>It's enabled on the TeamFirefly source [0]. >>I pulled it in to my device tree and have been using a USB3 SSD as my >>boot device for over a year now. >> >>If I were to submit the patch, would y'all be open to pulling it in? >> >>[0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> >>_______________________________________________ >>Linux-rockchip mailing list >>Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >>http://lists.infradead.org/mailman/listinfo/linux-rockchip >> > > >_______________________________________________ >Linux-rockchip mailing list >Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20191017162131.GH14623-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org>]
* Re: rk3328 USB3 controller [not found] ` <20191017162131.GH14623-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org> @ 2019-10-18 1:54 ` Katsuhiro Suzuki 0 siblings, 0 replies; 6+ messages in thread From: Katsuhiro Suzuki @ 2019-10-18 1:54 UTC (permalink / raw) To: 4omecha-Re5JQEeQqe8AvxtiuMwx3w Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Peter Geis Hello, On 2019/10/18 1:21, 4omecha@gmail.com wrote: > On 2019-10-17 14:07:43, Katsuhiro Suzuki wrote: >> Hello Peter, >> >> USB3 phy driver "rockchip,rk3328-u3phy" has not been implemented on >> upstream linux kernel. >> >> FireflyTeam use the special version of linux that is modified by Rockchip. >> (It seems based on linux-4.4) >> >> rockchip,rk3328-u3phy is provided by >> https://github.com/FireflyTeam/kernel/drivers/phy/rockchip/phy-rockchip-inno-usb3.c > That's a 404 over here. > > Oops, this URL is correct. https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/drivers/phy/rockchip/phy-rockchip-inno-usb3.c >> >> If you want to use USB 3.0 with upstream linux, we need to port this >> USB3 phy driver from rockchip-linux to upstream kernel, I think. >> >> Best Regards, >> Katsuhiro Suzuki >> >> >> On 2019/10/17 3:54, Peter Geis wrote: >>> Good Afternoon, >>> >>> Is there a particular reason why the USB3 controller on the rk3328 has >>> not been enabled? >>> It's enabled on the TeamFirefly source [0]. >>> I pulled it in to my device tree and have been using a USB3 SSD as my >>> boot device for over a year now. >>> >>> If I were to submit the patch, would y'all be open to pulling it in? >>> >>> [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAMdYzYp9xdtb6eiUs-Tiq4jJ-jr31LTzng2o-qAbOfu_63zXVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: rk3328 USB3 controller [not found] ` <CAMdYzYp9xdtb6eiUs-Tiq4jJ-jr31LTzng2o-qAbOfu_63zXVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2019-10-17 5:07 ` Katsuhiro Suzuki 2019-10-17 16:35 ` Robin Murphy 1 sibling, 0 replies; 6+ messages in thread From: Katsuhiro Suzuki @ 2019-10-17 5:07 UTC (permalink / raw) To: Peter Geis, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hello Peter, USB3 phy driver "rockchip,rk3328-u3phy" has not been implemented on upstream linux kernel. FireflyTeam use the special version of linux that is modified by Rockchip. (It seems based on linux-4.4) rockchip,rk3328-u3phy is provided by https://github.com/FireflyTeam/kernel/drivers/phy/rockchip/phy-rockchip-inno-usb3.c If you want to use USB 3.0 with upstream linux, we need to port this USB3 phy driver from rockchip-linux to upstream kernel, I think. Best Regards, Katsuhiro Suzuki On 2019/10/17 3:54, Peter Geis wrote: > Good Afternoon, > > Is there a particular reason why the USB3 controller on the rk3328 has > not been enabled? > It's enabled on the TeamFirefly source [0]. > I pulled it in to my device tree and have been using a USB3 SSD as my > boot device for over a year now. > > If I were to submit the patch, would y'all be open to pulling it in? > > [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: rk3328 USB3 controller [not found] ` <CAMdYzYp9xdtb6eiUs-Tiq4jJ-jr31LTzng2o-qAbOfu_63zXVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-10-17 5:07 ` Katsuhiro Suzuki @ 2019-10-17 16:35 ` Robin Murphy [not found] ` <65610976-8cb9-c0cd-d4a7-b8951b836fd7-5wv7dgnIgG8@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Robin Murphy @ 2019-10-17 16:35 UTC (permalink / raw) To: Peter Geis, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 16/10/2019 19:54, Peter Geis wrote: > Good Afternoon, > > Is there a particular reason why the USB3 controller on the rk3328 has > not been enabled? > It's enabled on the TeamFirefly source [0]. > I pulled it in to my device tree and have been using a USB3 SSD as my > boot device for over a year now. IIRC, the issue is that it's effectively *only* usable for a boot device (or possibly with a fixed hub), since without the phy driver, as soon as the initial device is unplugged the controller can no longer detect anything being plugged in again. Robin. > > If I were to submit the patch, would y'all be open to pulling it in? > > [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <65610976-8cb9-c0cd-d4a7-b8951b836fd7-5wv7dgnIgG8@public.gmane.org>]
* Re: rk3328 USB3 controller [not found] ` <65610976-8cb9-c0cd-d4a7-b8951b836fd7-5wv7dgnIgG8@public.gmane.org> @ 2019-10-17 17:11 ` Peter Geis 0 siblings, 0 replies; 6+ messages in thread From: Peter Geis @ 2019-10-17 17:11 UTC (permalink / raw) To: Robin Murphy; +Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, Oct 17, 2019 at 12:35 PM Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org> wrote: > > On 16/10/2019 19:54, Peter Geis wrote: > > Good Afternoon, > > > > Is there a particular reason why the USB3 controller on the rk3328 has > > not been enabled? > > It's enabled on the TeamFirefly source [0]. > > I pulled it in to my device tree and have been using a USB3 SSD as my > > boot device for over a year now. > > IIRC, the issue is that it's effectively *only* usable for a boot device > (or possibly with a fixed hub), since without the phy driver, as soon as > the initial device is unplugged the controller can no longer detect > anything being plugged in again. > > Robin. Well that's the behavior I was seeing, but I've just pulled the driver in and with very little tweaking it builds and loads fine. Need to conduct usability testing but it should be good to go. > > > > > If I were to submit the patch, would y'all be open to pulling it in? > > > > [0] https://github.com/FireflyTeam/kernel/blob/roc-rk3328-cc/arch/arm64/boot/dts/rockchip/rk3328.dtsi > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-18 1:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-16 18:54 rk3328 USB3 controller Peter Geis
[not found] ` <1b0f65be-51b6-69dd-e204-6d168f17eb7d@think-future.de>
[not found] ` <1b0f65be-51b6-69dd-e204-6d168f17eb7d-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org>
2019-10-17 16:21 ` 4omecha-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20191017162131.GH14623-ehbYDe70fqD9uQeqpI+JUg@public.gmane.org>
2019-10-18 1:54 ` Katsuhiro Suzuki
[not found] ` <CAMdYzYp9xdtb6eiUs-Tiq4jJ-jr31LTzng2o-qAbOfu_63zXVg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-10-17 5:07 ` Katsuhiro Suzuki
2019-10-17 16:35 ` Robin Murphy
[not found] ` <65610976-8cb9-c0cd-d4a7-b8951b836fd7-5wv7dgnIgG8@public.gmane.org>
2019-10-17 17:11 ` Peter Geis
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.