From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19890ECE58E for ; Thu, 17 Oct 2019 16:22:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E03AD21848 for ; Thu, 17 Oct 2019 16:22:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EAbxuCu9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2L+jAG8Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E03AD21848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c6hgralxx5uu37Z1Ccw7BttRrunwvyi7gUUIZ1EZ/oI=; b=EAbxuCu9xU5wr1 d7w9bxP5YqYjw3avR7omVh2B0W6k7k1HNu5JFIW+RBBOWDLq3V21AV/AHuVf23618Qpp/aUjFcYJ4 Ktmywuh0XTJ6wctjucUvN7fgWHXpJfOfJwujYDoj+Q8l0ky5is/LaHgMf1V69qAKPWcmkjeHQQ5Qp gr+xtyjc87vgkAYCTTMPLaUV22IhFJmlVXk1KfXl0c+UIVEZqB9+lVnPF/H3hLIxh9gb4Jd/6HgXx aJFvAq40lpoAm6zzhOjzymhik9HZWlbfR1hRa8Bxp1bGMreBzGaWDiZFr/ApVZJLcF95p8y3Jv22u jPisOBOdFTVIaKgXFNNw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL8Xc-0005JD-PA; Thu, 17 Oct 2019 16:22:20 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iL8Xa-0005In-An for linux-arm-kernel@lists.infradead.org; Thu, 17 Oct 2019 16:22:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yYGDmTWdpok/xWnLGj7w6mA7xTyvaVCtiqcsC3AJCpQ=; b=2L+jAG8Ywqn73DSlznFpAet952 vUroIflGLGIMEnu3QNwOuXpyLOY/ZGjiT7ph2pfGXhZQT98B8J/3fdzZvqx8YG07Q8c2jMQF1n8e9 BoT+kzWK4wzK04r0iA8e+q2ZdrlJO8okRbkptmRX7YAZVwz+3MWII9AgeCnMJ20Ibd8w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iL8XW-0005Du-AQ; Thu, 17 Oct 2019 18:22:14 +0200 Date: Thu, 17 Oct 2019 18:22:14 +0200 From: Andrew Lunn To: Alexandre Belloni Subject: Re: [PATCH v2 2/2] net: lpc_eth: parse phy nodes from device tree Message-ID: <20191017162214.GS17013@lunn.ch> References: <20191017094757.26885-1-alexandre.belloni@bootlin.com> <20191017094757.26885-2-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191017094757.26885-2-alexandre.belloni@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191017_092218_371384_75E54209 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Zapolskiy , Sylvain Lemieux , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2019 at 11:47:57AM +0200, Alexandre Belloni wrote: > When connected to a micrel phy, phy_find_first doesn't work properly > because the first phy found is on address 0, the broadcast address but, the > first thing the phy driver is doing is disabling this broadcast address. > The phy is then available only on address 1 but the mdio driver doesn't > know about it. > > Instead, register the mdio bus using of_mdiobus_register and try to find > the phy description in device tree before falling back to phy_find_first. > > This ultimately also allows to describe the interrupt the phy is connected > to. > > Signed-off-by: Alexandre Belloni Hi Alexandre It is normal to have a cover note for a patch series. Otherwise: Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34B8ECE58E for ; Thu, 17 Oct 2019 16:22:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CACE2089C for ; Thu, 17 Oct 2019 16:22:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2L+jAG8Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440479AbfJQQWT (ORCPT ); Thu, 17 Oct 2019 12:22:19 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50846 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391091AbfJQQWT (ORCPT ); Thu, 17 Oct 2019 12:22:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yYGDmTWdpok/xWnLGj7w6mA7xTyvaVCtiqcsC3AJCpQ=; b=2L+jAG8Ywqn73DSlznFpAet952 vUroIflGLGIMEnu3QNwOuXpyLOY/ZGjiT7ph2pfGXhZQT98B8J/3fdzZvqx8YG07Q8c2jMQF1n8e9 BoT+kzWK4wzK04r0iA8e+q2ZdrlJO8okRbkptmRX7YAZVwz+3MWII9AgeCnMJ20Ibd8w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iL8XW-0005Du-AQ; Thu, 17 Oct 2019 18:22:14 +0200 Date: Thu, 17 Oct 2019 18:22:14 +0200 From: Andrew Lunn To: Alexandre Belloni Cc: "David S . Miller" , Vladimir Zapolskiy , Sylvain Lemieux , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/2] net: lpc_eth: parse phy nodes from device tree Message-ID: <20191017162214.GS17013@lunn.ch> References: <20191017094757.26885-1-alexandre.belloni@bootlin.com> <20191017094757.26885-2-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017094757.26885-2-alexandre.belloni@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 17, 2019 at 11:47:57AM +0200, Alexandre Belloni wrote: > When connected to a micrel phy, phy_find_first doesn't work properly > because the first phy found is on address 0, the broadcast address but, the > first thing the phy driver is doing is disabling this broadcast address. > The phy is then available only on address 1 but the mdio driver doesn't > know about it. > > Instead, register the mdio bus using of_mdiobus_register and try to find > the phy description in device tree before falling back to phy_find_first. > > This ultimately also allows to describe the interrupt the phy is connected > to. > > Signed-off-by: Alexandre Belloni Hi Alexandre It is normal to have a cover note for a patch series. Otherwise: Reviewed-by: Andrew Lunn Andrew